Received-SPF: pass (google.com: domain of linux-kernel+bounces-89368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <51b6c48b-a33e-46cd-9b00-5568ccc529ca@molgen.mpg.de>
Date: Sat, 2 Mar 2024 09:19:05 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH Linux-6.8-rc5 1/1] ixgbevf: start
 negotiate with api version 1.4
To: Yifei Liu <yifei.l.liu@oracle.com>
Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, lihong.yang@intel.com, harshit.m.mogalapalli@oracle.com,
 linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
 jack.vogel@oracle.com, netdev@vger.kernel.org,
 ramanan.govindarajan@oracle.com
References: <20240301235837.3741422-1-yifei.l.liu@oracle.com>
Content-Language: en-US
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20240301235837.3741422-1-yifei.l.liu@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Dear Yifei,


Thank you very much for your patch.

Am 02.03.24 um 00:58 schrieb Yifei Liu:
> ixgbevf updates to api version to 1.5 via
> 	commit 339f28964147d ("ixgbevf: Add support for new mailbox
> 	communication between PF and VF")
> while the pf side is not updated to 1.5 properly. It will lead to a
> failure of negotiation of api version 1.5 This commit will enforce
> the negotiation to start with 1.4 which is working fine.
> 
> Normally the pf and vf side should be updated together. Example:
> 	commit adef9a26d6c39 ("ixgbevf: add defines for IPsec offload request")
> 	commit 7269824046376 ("ixgbe: add VF IPsec offload request message handling")

Why can’t the PF side not be updated to version 1.5 too?

If you don’t mind, I’d format the commit message like below.

Commit 339f28964147d ("ixgbevf: Add support for new mailbox communication
between PF and VF") updates the driver ixgbevf to API version 1.5 while the
pf side is not updated to 1.5 properly. This leads to a negotiation failure
of api version 1.5. So, enforce the negotiation to start with 1.4 which is
working fine.

Normally the pf and vf side should be updated together. Example:

1.  commit adef9a26d6c39 ("ixgbevf: add defines for IPsec offload request")
2.  commit 7269824046376 ("ixgbe: add VF IPsec offload request message 
handling")

> Reported-by: Manjunatha Gowda <manjunatha.gowda@oracle.com>
> Signed-off-by: Yifei Liu <yifei.l.liu@oracle.com>
> Reviewed-by: Jack Vogel <jack.vogel@oracle.com>

Please add a Fixes: tag.

Fixes: 39f28964147d ("ixgbevf: Add support for new mailbox communication 
between PF and VF")

Unfortunately, I am unable to find this commit hash. What archive/tree 
is it from?

> ---
>   drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index a44e4bd56142..a1b9b789d1d4 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -2286,6 +2286,12 @@ static void ixgbevf_negotiate_api(struct ixgbevf_adapter *adapter)
>   
>   	spin_lock_bh(&adapter->mbx_lock);
>   
> +	/* There is no corresponding drivers in pf for
> +	 * api version 1.5. Try to negociate with version

negotiate

> +	 * 1.5 will always fail. Start to negociate with
> +	 * version 1.4.

Could you please use the fully allowed line length, so less lines are used?

> +	 */
> +	idx = 1; >   	while (api[idx] != ixgbe_mbox_api_unknown) {
>   		err = hw->mac.ops.negotiate_api_version(hw, api[idx]);
>   		if (!err)

Where is `idx` set before?

Unrelated to the problem at hand, but enums or macros should be used for 
the API version.


Kind regards,

Paul