Received-SPF: pass (google.com: domain of linux-kernel+bounces-89370-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <6bf9f962-cf75-459d-89f4-2546063fc154@web.de>
Date: Sat, 2 Mar 2024 09:24:53 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Dmitry Torokhov <dmitry.torokhov@gmail.com>, Jeff LaBundy
 <jeff@labundy.com>, Mattijs Korpershoek <mkorpershoek@baylibre.com>,
 =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 ye xingchen <ye.xingchen@zte.com.cn>
Content-Language: en-GB
Cc: LKML <linux-kernel@vger.kernel.org>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] Input: iqs269a - Use common error handling code in
 iqs269_parse_chan()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:FRSmwSz1bmE=;ENul1wobOmr+CBbTNQETJkUvNDM
 AsjLTij0F36cjs1ms8NK65I/gPpWSEUtZhMuvEoqUDRgm5CImCgra+4bb7tK8eLxwxjyiYHDO
 Jfa7MfMo54QvXFn1F+2bkNES2YyNdx3jdq/YxodC84JrpKj28EaIUy7gv6E8DZMYVXSaaOTyT
 Hab9fOV/ftFhhIk/FATVYsJCxL75lT+qj31R3qLHLkCre5nbFqcAc0Wpd4FN9ygu58J2b6yxm
 YEAK9Y655F4JMCLpLzJzHJeJqirQhMyddilrhP166oW4j+iFCH3q+3kqNkw3f/uYmXhhrrHeU
 gYG4++xz45Ij7JZ5tdmSe83k/1MffxdLL7mdBsh3FOUWYsRamDwlElYkFgFxM4aZ98hsw62s9
 TQgPKTrNV3CqPHdqyfRPozGgIJDttHD1s9BuMXl2Ple2hFxsS44flAXAhsEJzeF3xfqo8rN5H
 evYRggqUkOu4adB4QoRutX1PNzDSO82evjnpAQcK9dBW44NFjLbfFIX5zLfRTLeulDzIhQG4I
 jkjZBXfr9+hdzjfv61YjKb9v/Ercao0q7pim6XhM4IJ6PtEiEsp0s+9ELz0mnDwQRGSFkO/n3
 WPcdDKxbAzVqhDfdCze4tKbWST9xjH7Tiohyebk+54BFbKNgRjYD4wG8kYXFWNzhO87nkBNJ3
 4NDiUjxpVeolTzqynZfMJceAdHoxK1m5qYxkXvaLBTuveA6k7pHHplf21Tv+Dzj3f4coJJG20
 Ozi+XuxQdJyWQYYYAbgdwRcYzBQfvBXnrU2qlFQniW9adSC9hNdZmFv0VJsinPbOKr//J1b0i
 iYK4aAhd0HDgJzeEvnLO2kJZgyAp+z82vimTokAt3mzM4=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Mar 2024 09:15:20 +0100

Add a jump target so that a bit of exception handling can be better reused
at the end of this function implementation.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/input/misc/iqs269a.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/input/misc/iqs269a.c b/drivers/input/misc/iqs269a.c
index cd14ff9f57cf..1379f80c00e2 100644
=2D-- a/drivers/input/misc/iqs269a.c
+++ b/drivers/input/misc/iqs269a.c
@@ -744,8 +744,7 @@ static int iqs269_parse_chan(struct iqs269_private *iq=
s269,
 				dev_err(&client->dev,
 					"Invalid channel %u threshold: %u\n",
 					reg, val);
-				fwnode_handle_put(ev_node);
-				return -EINVAL;
+				goto put_fwnode;
 			}

 			ch_reg->thresh[iqs269_events[i].th_offs] =3D val;
@@ -758,8 +757,7 @@ static int iqs269_parse_chan(struct iqs269_private *iq=
s269,
 				dev_err(&client->dev,
 					"Invalid channel %u hysteresis: %u\n",
 					reg, val);
-				fwnode_handle_put(ev_node);
-				return -EINVAL;
+				goto put_fwnode;
 			}

 			if (i =3D=3D IQS269_EVENT_DEEP_DN ||
@@ -805,6 +803,10 @@ static int iqs269_parse_chan(struct iqs269_private *i=
qs269,
 	}

 	return 0;
+
+put_fwnode:
+	fwnode_handle_put(ev_node);
+	return -EINVAL;
 }

 static int iqs269_parse_prop(struct iqs269_private *iqs269)
=2D-
2.44.0