Received-SPF: pass (google.com: domain of linux-kernel+bounces-89433-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <8a7607f8-d634-415e-8269-e26dcc0f9fdc@web.de>
Date: Sat, 2 Mar 2024 12:42:08 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Dmitry Torokhov <dmitry.torokhov@gmail.com>, Jeff LaBundy
 <jeff@labundy.com>, Rob Herring <robh@kernel.org>,
 =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Content-Language: en-GB
Cc: LKML <linux-kernel@vger.kernel.org>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] Input: iqs626a - Use common error handling code in
 iqs626_parse_events()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:pmsEEA7ll84=;dN/IpDwWFntwUoLhARGcxU797SD
 Zg1a1k0c7eO4VMzGtV6DrBvjwBqb5YJlqjVVZn0jaEzgtGg3WVKhb1RbLuF7n+xyZYsl8gFny
 1Jay2eQlONetdD+M0SF6SmVZQMj4LRCEMQ4lgOI+idzT9mLy62Rog5h4BoG6vBVD46Nx7Xv+J
 CrQjLq0ktWL6/lLhPNv1REL+H6z/I+XrFJ1Cfm/t2HhK0b97TFBnod97va3t3f4GYw9iHNtxn
 3qRl2VYU6m/K1eO3LtjPN47q2sEmKNOwRdYp5dczOCMNd/Wv7bn6nNQEYwxaduDMVS1oH49Tv
 Z60b7zH7wVtt1rlzMj5uVrTq9mCdGBHnTCqGj8+Z9nwoCsQ7nyXmnWrN1RCY4OjD9yZeja5Cw
 5PXKsTMkqq/Mhu/KpZ8WaH2kSUeoOje7x0j4w5q/FheRuNwe2L9+Z9VB3EJoAn5mXWR9VxUaE
 E23bQsqFtXZG9YUqPCk1HnbiJpioQRB5P8S7mzHcHnXLhEFHlUmwhMX1twxW7DZ0pjWx6W7Vf
 wy2xlLkpA/96MrqT2Bx8JZ8nAQtaQ8D/2HTiK3w1dG0kLaJQudQtD0ea/kAGFkwE28Rnrh/SU
 ImuYUlUBSk+GwypHnP9rAtjsqkF2COh7oZtrHxS7YR1ZbfL6VCIWfRC7llkFne7t0i6hZmouo
 5+Yo0AyO/yHU2ojsqJG+yGnmT00dzLmTgQUg7ZoRygrheL3FF0Zl9wVPtWGGWCbFFYyqKEmua
 GXp37jTM8x3aRTE/gr+v16PdOaGp3ZjVXXsWJPOL87oafeNAHL3aOlLXieoi6BsAKvMGXvaI6
 oez+RcDVLbOJAyDCTtT3Ed5feWOFn19BdTDbWySRDGNoo=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Mar 2024 11:44:17 +0100

Add a jump target so that a bit of exception handling can be better reused
at the end of this function implementation.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/input/misc/iqs626a.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/input/misc/iqs626a.c b/drivers/input/misc/iqs626a.c
index 0dab54d3a060..fa9570755f7b 100644
=2D-- a/drivers/input/misc/iqs626a.c
+++ b/drivers/input/misc/iqs626a.c
@@ -530,8 +530,7 @@ iqs626_parse_events(struct iqs626_private *iqs626,
 					dev_err(&client->dev,
 						"Invalid input type: %u\n",
 						val);
-					fwnode_handle_put(ev_node);
-					return -EINVAL;
+					goto put_fwnode;
 				}

 				iqs626->kp_type[ch_id][i] =3D val;
@@ -545,8 +544,7 @@ iqs626_parse_events(struct iqs626_private *iqs626,
 				dev_err(&client->dev,
 					"Invalid %s channel hysteresis: %u\n",
 					fwnode_get_name(ch_node), val);
-				fwnode_handle_put(ev_node);
-				return -EINVAL;
+				goto put_fwnode;
 			}

 			if (i =3D=3D IQS626_EVENT_DEEP_DN ||
@@ -566,8 +564,7 @@ iqs626_parse_events(struct iqs626_private *iqs626,
 				dev_err(&client->dev,
 					"Invalid %s channel threshold: %u\n",
 					fwnode_get_name(ch_node), val);
-				fwnode_handle_put(ev_node);
-				return -EINVAL;
+				goto put_fwnode;
 			}

 			if (ch_id =3D=3D IQS626_CH_HALL)
@@ -580,6 +577,10 @@ iqs626_parse_events(struct iqs626_private *iqs626,
 	}

 	return 0;
+
+put_fwnode:
+	fwnode_handle_put(ev_node);
+	return -EINVAL;
 }

 static noinline_for_stack int
=2D-
2.44.0