Received-SPF: pass (google.com: domain of linux-kernel+bounces-89440-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <960d9120-47b3-4961-9ce7-cd9e8b760220@gmail.com>
Date: Sat, 2 Mar 2024 19:06:20 +0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] usb-storage: Add Brain USB3-FW to IGNORE_UAS
To: Alan Stern <stern@rowland.harvard.edu>, Tom Hu <huxiaoying@kylinos.cn>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
 linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
References: <20240226075936.1744353-1-huxiaoying@kylinos.cn>
 <a960f1c2-a858-498e-a0cf-4c15d74487d5@rowland.harvard.edu>
Content-Language: en-US
From: Lars Melin <larsm17@gmail.com>
In-Reply-To: <a960f1c2-a858-498e-a0cf-4c15d74487d5@rowland.harvard.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024-03-01 23:53, Alan Stern wrote:
>>   drivers/usb/storage/unusual_uas.h | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
>> index 1f8c9b16a0fb..98b7ff2c76ba 100644
>> --- a/drivers/usb/storage/unusual_uas.h
>> +++ b/drivers/usb/storage/unusual_uas.h
>> @@ -83,6 +83,13 @@ UNUSUAL_DEV(0x0bc2, 0x331a, 0x0000, 0x9999,
>>   		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>   		US_FL_NO_REPORT_LUNS),
>>   
>> +/* Reported-by: Tom Hu <huxiaoying@kylinos.cn> */
>> +UNUSUAL_DEV(0x1234, 0x1234, 0x0000, 0x9999,
> 
> The vendor and product ID values have a suspicious look, but they appear
> to be genuine.

Hi Alan,
it is of course a bogus Id, here is another one:

"SmartWi - Multi Room Solution is a Smart Card Reader hardware device. 
This driver was developed by SmartWi International A/S. The hardware id 
of this driver is USB/VID_1234&PID_1234."

found by googling vid_1234&pid_1234.

There are others like 1234:5678 which also looks suspicious.

thanks
Lars