Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1005803lqg; Sat, 2 Mar 2024 10:42:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWSlPGjhrB3cpMx4UDZW1wJskTTjGjx3A1hp1hDaZgwsvNXM+duTjf+rZX2gdC8ywRnvEO9/RlmInOL3LZEIb2cugBKmoJTgrMcbT8mLQ== X-Google-Smtp-Source: AGHT+IFk82Q8AHYK4dCTxUFsn+wFIubWWxeD+10fj0h0SKOeRzA4BS4OZQsgBFbo8kMbploy2bxe X-Received: by 2002:a17:90a:5986:b0:299:63bd:c17d with SMTP id l6-20020a17090a598600b0029963bdc17dmr6677581pji.2.1709404923280; Sat, 02 Mar 2024 10:42:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709404923; cv=pass; d=google.com; s=arc-20160816; b=ErghPjQDneKeI2fxM82bWlAouNTdXvXMt0MBzWv9P5Eh3mvBUCGfj0ndPpC+Z/p0Zj wGr1T8V7NrUL1Rc1kI8N4YdLP17r6V8Tj/m4yvShlPFX1BDdacJg0rk/1VIF70X6e9hz RekbAx9cbAWMvZC+LjYDSS2IvCke5N6U+4aBTIq4I/8jqobqZvjGAC3DLVoKkv8DGcbp R49RU8PbiqcqFxpvSuHUmoaPx2p6LeacOF6q8njAGFV+a0uzQcnwH7x9mFBAfq/efwFg 7IMgmgNLCEMWaiZPt08RpFR+jtgfUbE2iTlVyb28OhpAg6z0TDs04v1ea9paT2TRonZW 7mHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eZ1CpsQLFW/VJzZYtPBQQ3oXQjl7nJc8YLQC8RykE18=; fh=qyEOSuVdNPu/v62bEnhivBYuLeBmDJPicmyG6Nlm8hc=; b=vM/ql2VASfV3VcilzjZnbyCnTT3UoHwY1JKUr2ztx1iUS8y8lq0owvMg2Kxj3D8zg7 yp1Hqm09Zd6vUyNarHCyvVahNo9JIt+M5LYuMR611ZS/7N2fXRhsz9guHc06bwc1LpBZ fQEYxjYUjta5xXdQN/DDGCc8qV39PlM/rO20dZs4Pb5+hIdpHltwtgbaOWeS15onvIOG FDwEv744N4MVuC6nvjYfgt1wKmBJaw1B6IZqZJ1FkiOrEC0zyXtOMWOLG506KRDCQvXJ RscovxdtQsvVsZbrdnqq9Pb6oM27AGJCQKAqanor4OjDQ7NMO6Ud5afwsvjosREgDaL4 hlhA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TVx2aGn1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89554-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89554-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id so7-20020a17090b1f8700b0029b0c8d22afsi5826642pjb.51.2024.03.02.10.42.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Mar 2024 10:42:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89554-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TVx2aGn1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89554-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89554-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 741FDB2389D for ; Sat, 2 Mar 2024 18:41:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A115136B02; Sat, 2 Mar 2024 18:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TVx2aGn1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAD4D376EB; Sat, 2 Mar 2024 18:41:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709404907; cv=none; b=tVpHUjdm/Zx9xZxeuCpabyjfxz+hEyzXNO1eRWWUajdBMl0viiZbULaNcp4eugiBAsPszNHRcNWWTVm3Xt35lCCdVEY9rmJ6VI4ysFrQUebbwQwQss9eTfolXQfUDkAkNRPlAedlkxWx38EZLintyBuFEwxxIeOvcgf3YlCs6vc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709404907; c=relaxed/simple; bh=LVXdkM0Nxq6bVW0IsDj2dHOFAaUWxzw+WVZYqgrnLvs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PI5TQh9BJTTPSBE2I4XzbRBkaCDESZhedZkjmJvt+VncVkdQUJ7Bawecr9A2pOpZff0Smb6rEfWaJaPGhiHypiKQFg/ojMGjbVQGRCZC0Euwyo+8jQgllQ0QQElksz08xSdneyLgak3yRnbMaFJ9bOum39sS44b08Z6Sl04lCOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TVx2aGn1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 276F5C433C7; Sat, 2 Mar 2024 18:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709404907; bh=LVXdkM0Nxq6bVW0IsDj2dHOFAaUWxzw+WVZYqgrnLvs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TVx2aGn12Ppv2HW9eOqIN8bs40TVMQ///mkMRM/ewkk29DnDj87Qn+QsVgR8ozbqg B4WcYL6P3FEV6H7+ae797s2XxDnCJd4lcahrNwAPsof3Uwd8vGZUwMWOdV41hsCg2N Ppj7K5liIo5MuJbS5XDF10CDpx5IchWxbr/ryfYWyavfRP3P3sQsDSjB/7VkvIequh 4EKUiRC8af7rGk6CoBp8owGojk5yK0PRVLaafUijxJ61vJ38k5KNc5Z2rcCf7HrGXo ktmQp5XvbepgWHkdKfuBaj/MlBP5Cq6qEC1+mHUnFsA6KafYWNqy7Z7F18BnWZz1sA CsdQ4NGO3CzgA== Date: Sat, 2 Mar 2024 12:41:44 -0600 From: Bjorn Andersson To: Johan Hovold Cc: Gabor Juhos , Konrad Dybcio , Michael Turquette , Stephen Boyd , Sricharan Ramabadhran , Varadarajan Narayanan , Gokul Sriram Palanisamy , Devi Priya , Anusha Rao , Bryan O'Donoghue , Georgi Djakov , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] clk: qcom: gcc-ipq5018: fix terminating of frequency table arrays Message-ID: <35zcbdj7sk6y7cdpqs7s3exsouzftzlgj6lvuglnyvuxfshvgs@m7rz5owrinud> References: <20240229-freq-table-terminator-v1-0-074334f0905c@gmail.com> <20240229-freq-table-terminator-v1-1-074334f0905c@gmail.com> <91b36da5-637d-4156-8be4-5aed55fc3c5d@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 01, 2024 at 03:03:15PM +0100, Johan Hovold wrote: > On Fri, Mar 01, 2024 at 02:37:01PM +0100, Gabor Juhos wrote: > > Hi Johan, > > > > 2024. 03. 01. 10:40 keltez?ssel, Johan Hovold ?rta: > > > On Thu, Feb 29, 2024 at 07:07:46PM +0100, Gabor Juhos wrote: > > >> The frequency table arrays are supposed to be terminated with an > > >> empty element. Add such entry to the end of the arrays where it > > >> is missing in order to avoid possible out-of-bound access when > > >> the table is traversed by functions like qcom_find_freq() or > > >> qcom_find_freq_floor(). > > >> > > >> Fixes: e3fdbef1bab8 ("clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018") > > > > > > Good find! > > > > > > Looks like these should be backported to the stable kernels as well so > > > someone should add: > > > > > > Cc: stable@vger.kernel.org > > > > > > to all patches except possibly the sc8280xp one (that camera clock > > > controller was added in 6.8-rc1 so that patch does not need it in case > > > you can these fixes in before 6.8 is released). > > > > You are right maybe, although I did not find strong enough reasons for adding > > the stable tags. > > > > Only the changes of the gcc-ipq5018 driver has been tested on real hardware the > > others are not. So those does not fit into the "It must be obviously correct and > > tested." rule. > > Since this looks like a straight-forward and obviously correct fix for a > bug which could have bad consequences, not being able to test each patch > on actual hardware is not a problem. > I agree, and I'm adding the Cc: stable while applying the patches. Thanks, Bjorn