Received-SPF: pass (google.com: domain of linux-kernel+bounces-89586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sat, 2 Mar 2024 12:20:32 -0800
From: Igor Pylypiv <ipylypiv@google.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>,
	John Garry <john.g.garry@oracle.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Jack Wang <jinpu.wang@cloud.ionos.com>,
	Hannes Reinecke <hare@suse.de>, TJ Adams <tadamsjr@google.com>,
	linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] scsi: hisi_sas: Add libsas SATA sysfs attributes
 group
Message-ID: <ZeOKEFC10lD-9Kle@google.com>
References: <20240302001603.1012084-1-ipylypiv@google.com>
 <20240302001603.1012084-6-ipylypiv@google.com>
 <e363a966-46a6-5c19-ea6c-77db43021149@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e363a966-46a6-5c19-ea6c-77db43021149@huawei.com>

On Sat, Mar 02, 2024 at 10:54:14AM +0800, Jason Yan wrote:
> On 2024/3/2 8:16, Igor Pylypiv wrote:
> > The added sysfs attributes group enables the configuration of NCQ Priority
> > feature for HBAs that rely on libsas to manage SATA devices.
> > 
> > Signed-off-by: Igor Pylypiv<ipylypiv@google.com>
> > ---
> >   drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 6 ++++++
> >   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
> >   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
> >   3 files changed, 18 insertions(+)
> 
> As John pointed out, please check aic94xx and isci driver, they also use
> libsas.

Thank you, Jason. I wasn't sure about these drivers. Added in v3.

Thanks,
Igor

> 
> Thanks,
> Jason