Received-SPF: pass (google.com: domain of linux-kernel+bounces-89657-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 2 Mar 2024 21:26:15 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, Marc Dionne <marc.dionne@auristor.com>, "David
 S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo
 Abeni <pabeni@redhat.com>, linux-afs@lists.infradead.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 13/21] rxrpc: Use rxrpc_txbuf::kvec[0] instead
 of rxrpc_txbuf::wire
Message-ID: <20240302212615.310678df@kernel.org>
In-Reply-To: <20240301163807.385573-14-dhowells@redhat.com>
References: <20240301163807.385573-1-dhowells@redhat.com>
	<20240301163807.385573-14-dhowells@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri,  1 Mar 2024 16:37:45 +0000 David Howells wrote:
> Use rxrpc_txbuf::kvec[0] instead of rxrpc_txbuf::wire to gain access to the
> Rx protocol header.  In future, the wire header will be stored in a page
> frag, not in the rxrpc_txbuf struct making it possible to use
> MSG_SPLICE_PAGES when sending it.
> 
> Similarly, access the ack header as being immediately after the wire header
> when filling out an ACK packet.

net/rxrpc/output.c:263:28: warning: unused variable 'whdr' [-Wunused-variable]
  263 |         struct rxrpc_wire_header *whdr;
      |                                   ^~~~