Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1264932lqg; Sun, 3 Mar 2024 02:15:51 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUzFTmj64BsEEMiEpJrCcNUfUDeFESxfwcQGmB/VnxmS7UdHr+KQU1Oy6Qy8W9aZGHJTkW21cichEjyTFl4QjvWtZfrrTcqu/ATClLrKQ== X-Google-Smtp-Source: AGHT+IEJZi8pxwZ7hcrsMahziYDMBaI7s+tiwX25XzmBAQzdLaemlOFkvMY5wlCAEdHMBQy5CzvN X-Received: by 2002:a05:6871:3304:b0:21f:a138:adf5 with SMTP id nf4-20020a056871330400b0021fa138adf5mr7700727oac.39.1709460950872; Sun, 03 Mar 2024 02:15:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709460950; cv=pass; d=google.com; s=arc-20160816; b=YUm8+7IfaEO8Fg3YXBa/1Sx19huZIcJQRERoR+8ayjL/W+LFRCXpdQKugsxen9SLeI /xoh5IP9sM+Pqqwpae34vO3MBBU/VTDLaxmdx1M7Td28E6pgLWXxkBmyVQ8HWHmZjncN V7HMpver1CWL6cah1Sb3RHzvyP91ahpJpZXWFIrVeTuDBCTJa4aiJLpvfTAa1LnI5BbS pciHF7/u8sY5dWT841PAPTaAMI7qyUjqZ2fY2tQHN+9JMMwFQGIFVqXgy29Hit5mMG00 /iiRiDCQi0pM6lByA0dJd0hlQodp+4Mc2BRLM2/Q4Hcm7P+A5MQd6WcTpeC8CqrGa1Ys /rJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=9U2dAMCkXRiskMUmdbbGYCvHSLFwoJhVBt80xaRbL80=; fh=XPznAPHjywHhKJCA3zzSjmtYugAvBjl32NkRZBKKmSM=; b=SEfoW2evwB7W52qEz97Lx8ATMcUuhaDKRJiVLvawX3uxYxuQXrmu8RFOT/g6ZRrBPC utQihjsdI188hbFSI0lMYTA2KTj72rLtgyZI+bGmOjSP9se02E7X1C9hkceuDY/MQSQ1 v9QLxjA2GLH4zO8VcdF5W4NDT1kOwSRvYqV2iY/SlkLAMCsPyTw+Ckqv6zHLHvKJLAnh 3lXgRHlu5VMMUxr5s45hf8XwySh5o5vX2NMQ7fCebI2Pk/BTOr9U++yZRSZUBjRZqpNf X4XgaoWsomwMg2wFpYrwP4IxaNeSpZnc33hyjx3pcSbVQP+MHQPOVNt2P3xNbzDRWCrt eYlw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=po16+Jx8; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89696-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89696-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o36-20020a635a24000000b005dc6d15c299si6856013pgb.240.2024.03.03.02.15.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 02:15:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89696-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=po16+Jx8; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89696-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89696-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 808B42831BC for ; Sun, 3 Mar 2024 10:15:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83E85BE4E; Sun, 3 Mar 2024 10:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b="po16+Jx8" Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C588EB657; Sun, 3 Mar 2024 10:15:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460935; cv=none; b=nHY0/59oK/wKUeRLUWIhY+jrB1Kkst7ejQ3pt0JlQ7mP5Kp8boX2tyyl8QG18LDIXTQF6FKxpfHt99tVLUAyYvb5Jkfcqko1bcEuiWirLDpdSMfjSCQdQi+UqGde4UUfhvJ6cVOOXI0sjQ8q9vaTlLv04+FKuY+grYs7sC4JAd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460935; c=relaxed/simple; bh=Ch2E7gNOECXJ9bCkUmp3zCVDkVJp8aC6si+oXHJMb80=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sNa+fHPSeK8Cy/7qY6gY/OFwysbaWJilJcOH2TqbnNj2a8Tdg/4UQl+hN3+bbr1sS5HuFbfic2vYQ0gvdTq9FmVQkO0AkMFZ1CC3Vkrpr7l0FDmkNogTp7RmDVIm6oL2j435z4FLliAbhi8r3l231nbsTdBhFSjoPe0VuiMGcp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b=po16+Jx8; arc=none smtp.client-ip=195.113.20.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz Received: from gimli.ms.mff.cuni.cz (gimli.ms.mff.cuni.cz [195.113.20.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by nikam.ms.mff.cuni.cz (Postfix) with ESMTPS id B1215284291; Sun, 3 Mar 2024 11:15:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gimli.ms.mff.cuni.cz; s=gen1; t=1709460929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9U2dAMCkXRiskMUmdbbGYCvHSLFwoJhVBt80xaRbL80=; b=po16+Jx8SGaCfLHrVmnz3BfcYJ9cfm50mFduIYmFXSL34VZ3fnVv81NDSQegZjGSQLEuNk fWRq8MFNJmp+KccNu2K4nSIR9UIhFNEFhVq1dWDIrCHojEmwUsMz4PzKtRI3dOznyMqydE SWgq2OAOsK71lJvtn3h1+9JE12f+MEk= Received: from localhost (internet5.mraknet.com [185.200.108.250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: karelb) by gimli.ms.mff.cuni.cz (Postfix) with ESMTPSA id 8B79D456F3E; Sun, 3 Mar 2024 11:15:29 +0100 (CET) From: Karel Balej To: Karel Balej , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: =?UTF-8?q?Duje=20Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: [RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC Date: Sun, 3 Mar 2024 11:04:23 +0100 Message-ID: <20240303101506.4187-3-karelb@gimli.ms.mff.cuni.cz> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> References: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Karel Balej Marvell 88PM886 is a PMIC which provides various functions such as onkey, battery, charger and regulators. It is found for instance in the samsung,coreprimevelte smartphone with which this was tested. Only implement basic support to allow for the use of regulators and onkey omitting the currently unused register definitions and I2C subclients which should thus be added with the subdevice drivers which need them. Signed-off-by: Karel Balej --- Notes: RFC v3: - Drop onkey cell .of_compatible. - Rename LDO page offset and regmap to REGULATORS. RFC v2: - Remove some abstraction. - Sort includes alphabetically and add linux/of.h. - Depend on OF, remove of_match_ptr and add MODULE_DEVICE_TABLE. - Use more temporaries and break long lines. - Do not initialize ret in probe. - Use the wakeup-source DT property. - Rename ret to err. - Address Lee's comments: - Drop patched in presets for base regmap and related defines. - Use full sentences in comments. - Remove IRQ comment. - Define regmap_config member values. - Rename data to sys_off_data. - Add _PMIC suffix to Kconfig. - Use dev_err_probe. - Do not store irq_data. - s/WHOAMI/CHIP_ID - Drop LINUX part of include guard name. - Merge in the regulator series modifications in order to have more devices and modify the commit message accordingly. Changes with respect to the original regulator series patches: - ret -> err - Add temporary for dev in pm88x_initialize_subregmaps. - Drop of_compatible for the regulators. - Do not duplicate LDO regmap for bucks. - Rewrite commit message. drivers/mfd/88pm886.c | 210 ++++++++++++++++++++++++++++++++++++ drivers/mfd/Kconfig | 12 +++ drivers/mfd/Makefile | 1 + include/linux/mfd/88pm886.h | 46 ++++++++ 4 files changed, 269 insertions(+) create mode 100644 drivers/mfd/88pm886.c create mode 100644 include/linux/mfd/88pm886.h diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c new file mode 100644 index 000000000000..c17220e1b7e2 --- /dev/null +++ b/drivers/mfd/88pm886.c @@ -0,0 +1,210 @@ +// SPDX-License-Identifier: GPL-2.0-only +#include +#include +#include +#include +#include +#include +#include + +#include + +#define PM886_REG_INT_STATUS1 0x05 + +#define PM886_REG_INT_ENA_1 0x0a +#define PM886_INT_ENA1_ONKEY BIT(0) + +#define PM886_REGMAP_CONF_REG_BITS 8 +#define PM886_REGMAP_CONF_VAL_BITS 8 +#define PM886_REGMAP_CONF_MAX_REG 0xfe + +enum pm886_irq_number { + PM886_IRQ_ONKEY, + + PM886_MAX_IRQ +}; + +static struct regmap_irq pm886_regmap_irqs[] = { + REGMAP_IRQ_REG(PM886_IRQ_ONKEY, 0, PM886_INT_ENA1_ONKEY), +}; + +static struct regmap_irq_chip pm886_regmap_irq_chip = { + .name = "88pm886", + .irqs = pm886_regmap_irqs, + .num_irqs = ARRAY_SIZE(pm886_regmap_irqs), + .num_regs = 4, + .status_base = PM886_REG_INT_STATUS1, + .ack_base = PM886_REG_INT_STATUS1, + .unmask_base = PM886_REG_INT_ENA_1, +}; + +static struct resource pm886_onkey_resources[] = { + DEFINE_RES_IRQ_NAMED(PM886_IRQ_ONKEY, "88pm886-onkey"), +}; + +static struct mfd_cell pm886_devs[] = { + { + .name = "88pm886-onkey", + .num_resources = ARRAY_SIZE(pm886_onkey_resources), + .resources = pm886_onkey_resources, + }, + { + .name = "88pm886-regulator", + .id = PM886_REGULATOR_ID_LDO2, + }, + { + .name = "88pm886-regulator", + .id = PM886_REGULATOR_ID_LDO15, + }, + { + .name = "88pm886-regulator", + .id = PM886_REGULATOR_ID_BUCK2, + }, +}; + +static const struct regmap_config pm886_i2c_regmap = { + .reg_bits = PM886_REGMAP_CONF_REG_BITS, + .val_bits = PM886_REGMAP_CONF_VAL_BITS, + .max_register = PM886_REGMAP_CONF_MAX_REG, +}; + +static int pm886_power_off_handler(struct sys_off_data *sys_off_data) +{ + struct pm886_chip *chip = sys_off_data->cb_data; + struct regmap *regmap = chip->regmaps[PM886_REGMAP_BASE]; + struct device *dev = &chip->client->dev; + int err; + + err = regmap_update_bits(regmap, PM886_REG_MISC_CONFIG1, PM886_SW_PDOWN, + PM886_SW_PDOWN); + if (err) { + dev_err(dev, "Failed to power off the device: %d\n", err); + return NOTIFY_BAD; + } + return NOTIFY_DONE; +} + +static int pm886_initialize_subregmaps(struct pm886_chip *chip) +{ + struct device *dev = &chip->client->dev; + struct i2c_client *page; + struct regmap *regmap; + int err; + + /* regulators page */ + page = devm_i2c_new_dummy_device(dev, chip->client->adapter, + chip->client->addr + PM886_PAGE_OFFSET_REGULATORS); + if (IS_ERR(page)) { + err = PTR_ERR(page); + dev_err(dev, "Failed to initialize regulators client: %d\n", err); + return err; + } + regmap = devm_regmap_init_i2c(page, &pm886_i2c_regmap); + if (IS_ERR(regmap)) { + err = PTR_ERR(regmap); + dev_err(dev, "Failed to initialize regulators regmap: %d\n", err); + return err; + } + chip->regmaps[PM886_REGMAP_REGULATORS] = regmap; + + return 0; +} + +static int pm886_setup_irq(struct pm886_chip *chip, + struct regmap_irq_chip_data **irq_data) +{ + struct regmap *regmap = chip->regmaps[PM886_REGMAP_BASE]; + struct device *dev = &chip->client->dev; + int err; + + /* Set interrupt clearing mode to clear on write. */ + err = regmap_update_bits(regmap, PM886_REG_MISC_CONFIG2, + PM886_INT_INV | PM886_INT_CLEAR | PM886_INT_MASK_MODE, + PM886_INT_WC); + if (err) { + dev_err(dev, "Failed to set interrupt clearing mode: %d\n", err); + return err; + } + + err = devm_regmap_add_irq_chip(dev, regmap, chip->client->irq, + IRQF_ONESHOT, -1, &pm886_regmap_irq_chip, + irq_data); + if (err) { + dev_err(dev, "Failed to request IRQ: %d\n", err); + return err; + } + + return 0; +} + +static int pm886_probe(struct i2c_client *client) +{ + struct regmap_irq_chip_data *irq_data; + struct device *dev = &client->dev; + struct pm886_chip *chip; + struct regmap *regmap; + unsigned int chip_id; + int err; + + chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); + if (!chip) + return -ENOMEM; + + chip->client = client; + chip->whoami = (uintptr_t)device_get_match_data(dev); + i2c_set_clientdata(client, chip); + + regmap = devm_regmap_init_i2c(client, &pm886_i2c_regmap); + if (IS_ERR(regmap)) { + err = PTR_ERR(regmap); + return dev_err_probe(dev, err, "Failed to initialize regmap\n"); + } + chip->regmaps[PM886_REGMAP_BASE] = regmap; + + err = regmap_read(regmap, PM886_REG_ID, &chip_id); + if (err) + return dev_err_probe(dev, err, "Failed to read chip ID\n"); + if (chip->whoami != chip_id) + return dev_err_probe(dev, -EINVAL, "Device reported wrong chip ID: %u\n", + chip_id); + + err = pm886_initialize_subregmaps(chip); + if (err) + return err; + + err = pm886_setup_irq(chip, &irq_data); + if (err) + return err; + + err = devm_mfd_add_devices(dev, 0, pm886_devs, ARRAY_SIZE(pm886_devs), + NULL, 0, regmap_irq_get_domain(irq_data)); + if (err) + return dev_err_probe(dev, err, "Failed to add devices\n"); + + err = devm_register_power_off_handler(dev, pm886_power_off_handler, chip); + if (err) + return dev_err_probe(dev, err, "Failed to register power off handler\n"); + + device_init_wakeup(dev, device_property_read_bool(dev, "wakeup-source")); + + return 0; +} + +const struct of_device_id pm886_of_match[] = { + { .compatible = "marvell,88pm886-a1", .data = (void *)PM886_A1_CHIP_ID }, + { }, +}; +MODULE_DEVICE_TABLE(of, pm886_of_match); + +static struct i2c_driver pm886_i2c_driver = { + .driver = { + .name = "88pm886", + .of_match_table = pm886_of_match, + }, + .probe = pm886_probe, +}; +module_i2c_driver(pm886_i2c_driver); + +MODULE_DESCRIPTION("Marvell 88PM886 PMIC driver"); +MODULE_AUTHOR("Karel Balej "); +MODULE_LICENSE("GPL"); diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index e7a6e45b9fac..9ef921c59f30 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -794,6 +794,18 @@ config MFD_88PM860X select individual components like voltage regulators, RTC and battery-charger under the corresponding menus. +config MFD_88PM886_PMIC + bool "Marvell 88PM886 PMIC" + depends on I2C=y + depends on OF + select REGMAP_I2C + select REGMAP_IRQ + select MFD_CORE + help + This enables support for Marvell 88PM886 Power Management IC. + This includes the I2C driver and the core APIs _only_, you have to + select individual components like onkey under the corresponding menus. + config MFD_MAX14577 tristate "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" depends on I2C diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index c66f07edcd0e..d016b7fed354 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -7,6 +7,7 @@ obj-$(CONFIG_MFD_88PM860X) += 88pm860x.o obj-$(CONFIG_MFD_88PM800) += 88pm800.o 88pm80x.o obj-$(CONFIG_MFD_88PM805) += 88pm805.o 88pm80x.o +obj-$(CONFIG_MFD_88PM886_PMIC) += 88pm886.o obj-$(CONFIG_MFD_ACT8945A) += act8945a.o obj-$(CONFIG_MFD_SM501) += sm501.o obj-$(CONFIG_ARCH_BCM2835) += bcm2835-pm.o diff --git a/include/linux/mfd/88pm886.h b/include/linux/mfd/88pm886.h new file mode 100644 index 000000000000..c7527bab0fba --- /dev/null +++ b/include/linux/mfd/88pm886.h @@ -0,0 +1,46 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __MFD_88PM886_H +#define __MFD_88PM886_H + +#include + +#define PM886_A1_CHIP_ID 0xa1 + +#define PM886_REG_ID 0x00 + +#define PM886_REG_STATUS1 0x01 +#define PM886_ONKEY_STS1 BIT(0) + +#define PM886_REG_MISC_CONFIG1 0x14 +#define PM886_SW_PDOWN BIT(5) + +#define PM886_REG_MISC_CONFIG2 0x15 +#define PM886_INT_INV BIT(0) +#define PM886_INT_CLEAR BIT(1) +#define PM886_INT_RC 0x00 +#define PM886_INT_WC BIT(1) +#define PM886_INT_MASK_MODE BIT(2) + +#define PM886_PAGE_OFFSET_REGULATORS 1 + +enum pm886_regulator_id { + PM886_REGULATOR_ID_LDO2, + PM886_REGULATOR_ID_LDO15, + PM886_REGULATOR_ID_BUCK2, + + PM886_REGULATOR_ID_SENTINEL +}; + +enum pm886_regmap_index { + PM886_REGMAP_BASE, + PM886_REGMAP_REGULATORS, + + PM886_REGMAP_NR +}; + +struct pm886_chip { + struct i2c_client *client; + unsigned int whoami; + struct regmap *regmaps[PM886_REGMAP_NR]; +}; +#endif /* __MFD_88PM886_H */ -- 2.44.0