Received-SPF: pass (google.com: domain of linux-kernel+bounces-89718-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sun, 3 Mar 2024 11:56:33 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Frank Rowand
 <frowand.list@gmail.com>, linux-kernel@vger.kernel.org, Julia Lawall
 <Julia.Lawall@inria.fr>, Peter Zijlstra <peterz@infradead.org>, Andy
 Shevchenko <andriy.shevchenko@linux.intel.com>, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, marek.vasut@gmail.com, Jonathan Cameron
 <Jonathan.Cameron@huawei.com>
Subject: Re: [RESEND PATCH v2 0/4] of: automate of_node_put() - new approach
 to loops.
Message-ID: <20240303115633.41128a62@jic23-huawei>
In-Reply-To: <20240301223942.GA3179769-robh@kernel.org>
References: <20240225142714.286440-1-jic23@kernel.org>
	<20240301223942.GA3179769-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 1 Mar 2024 16:39:42 -0600
Rob Herring <robh@kernel.org> wrote:

> On Sun, Feb 25, 2024 at 02:27:10PM +0000, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Some discussion occured on previous posting.
> > https://lore.kernel.org/linux-iio/20240223124432.26443-1-Jonathan.Cameron@huawei.com/
> > 
> > Summary:
> > * fwnode conversions should be considered when applying this
> >   infrastructure to a driver. Perhaps better to move directly to
> >   the generic FW property handling rather than improve existing
> >   of specific code.
> > * There are lots of potential places to use this based on detections
> >   from Julia's coccinelle scripts linked below.
> > 
> > The equivalent device_for_each_child_node_scoped() series for
> > fwnode will be queued up in IIO for the merge window shortly as
> > it has gathered sufficient tags. Hopefully the precdent set there
> > for the approach will reassure people that instantiating the
> > child variable inside the macro definition is the best approach.
> > https://lore.kernel.org/linux-iio/20240217164249.921878-1-jic23@kernel.org/
> > 
> > v2: Andy suggested most of the original converted set should move to
> >     generic fwnode / property.h handling.  Within IIO that was
> >     a reasonable observation given we've been trying to move away from
> >     firmware specific handling for some time. Patches making that change
> >     to appropriate drivers posted.
> >     As we discussed there are cases which are not suitable for such
> >     conversion and this infrastructure still provides clear benefits
> >     for them.
> > 
> > Ideally it would be good if this introductory series adding the
> > infrastructure makes the 6.9 merge window. There are no dependencies
> > on work queued in the IIO tree, so this can go via devicetree
> > if the maintainers would prefer. I've had some off list messages
> > asking when this would be merged, as there is interest in building
> > on it next cycle for other parts of the kernel (where conversion to
> > fwnode handling may be less appropriate).  
> 
> I'll let you take it. For the series:
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> I've got some drivers/of/ conversions too, but they are probably next 
> cycle at this point.
> 
> Rob

Thanks Rob,

Whether this makes it for this cycle is probably dependent on whether
Linus does decide to do got to rc8 as hinted at as a possibility
+ whether Greg feels comfortable taking these through his tree
(char-misc is the normal path for IIO).  I know various people
are hoping this series makes it, but if doesn't we can do an immutable
tree early next cycle (though obviously that may reduce speed of adoption).

We are discussing the equivalent pull request for the fwnode version here:

https://lore.kernel.org/linux-iio/2024030239-gift-cabdriver-266b@gregkh/T/#m87e7208820ebf6416a77a2973773b65a087b4796

I've optimistically applied this series to my togreg-cleanup branch
and merged that into the togreg branch of iio.git for linux-next to pick up.

Thanks,

Jonathan