Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1327492lqg; Sun, 3 Mar 2024 05:24:10 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUMjA8z4Sl5e6rfsK8VPE3f0iqwvgdM2Lwyv/DbKk5MIZhpXZqjDMTvBFcGIRQJ9mXqr/LBh5WhSssVKEyv81SrZVOL9i1qPu0JTs/wng== X-Google-Smtp-Source: AGHT+IF2yAjDzhdiIpMOkkgGwpDX7DLUL8KilyOSJWTOyPtQQIM4GsoKkWGG03laQi6flhEWl/h4 X-Received: by 2002:a05:6402:1d91:b0:566:b09e:8d24 with SMTP id dk17-20020a0564021d9100b00566b09e8d24mr3884724edb.12.1709472250512; Sun, 03 Mar 2024 05:24:10 -0800 (PST) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v16-20020a50d590000000b0056738ed3e4dsi370896edi.399.2024.03.03.05.24.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 05:24:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89748-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=K9naefPk; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-89748-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89748-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4005B1F21603 for ; Sun, 3 Mar 2024 13:24:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E279EDDBD; Sun, 3 Mar 2024 13:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K9naefPk" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04CA1B641; Sun, 3 Mar 2024 13:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709472241; cv=none; b=UawQYFvpclbS6YdvSEAkYI6ByKyMeqClrq0sBTBBmzmsTk9OssqAVAeXmyFYjREzUlqZyvf/BFLqFcqRijMG8Hxn0v8xC5dklXU9StwCiSyF/4MFCCifGU21Leu/KIbI8mCz3MSfkzeMM5rUbicRRd2pw0u88boUHg6nGeTWjXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709472241; c=relaxed/simple; bh=5HABLV55vqFa2+LegG4ZksipXRJADsbLdJAjy9nIQ+U=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h40/7y7fn5sqpq1B6mYDsOmEWnNSQSIs0av2aveZPCD0hh6gSm/ahTHZ3dZJUyzv/c2nm/Xwl4qOylZ4O86GgOyAqFzpv7incZcYHBcpIOVenOVN4XrFqMG19QN1IT4F7Xv8BtglphetRSZgkp1GM2vV6fx9oo7AIimV0qAJt2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K9naefPk; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EB8BC433F1; Sun, 3 Mar 2024 13:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709472240; bh=5HABLV55vqFa2+LegG4ZksipXRJADsbLdJAjy9nIQ+U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K9naefPkvKMLjWvIuGRit0366N+wl1LWzPPQWhwVcS41ZSW6cb8MI9J64A3LU2wK5 UAaux1cgpqerz0jeQ8MjItQmvyEP+vwY4F7Slrw/RByq8AuYhKUMQEyhSJy1VbU5gr LJoQx1CmjZgAn3+PMAtNXGyJQjTZEmrWrHnysw3OUL1IrRzSv3ki23vg//o2TiHsbf +OOPq71O0kKVhrJABjZ4teTddDc+ToC8RUo7pQcXAENCwPWkdtipDvtxLCjeiw48h5 2metudhex+DFbTMxedtLbbC6pbap5ZOcP5aLDNN/dgwRb3+54kNH4El/JB/p3K/bfw z1/00aB2jVf4Q== Date: Sun, 3 Mar 2024 13:23:46 +0000 From: Jonathan Cameron To: David Lechner Cc: linux-iio@vger.kernel.org, Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nuno =?UTF-8?B?U8Oh?= , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: add ad7944 ADCs Message-ID: <20240303132346.3db77d20@jic23-huawei> In-Reply-To: <20240229-ad7944-mainline-v4-1-f88b5ec4baed@baylibre.com> References: <20240229-ad7944-mainline-v4-0-f88b5ec4baed@baylibre.com> <20240229-ad7944-mainline-v4-1-f88b5ec4baed@baylibre.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 29 Feb 2024 10:25:50 -0600 David Lechner wrote: > This adds a new binding for the Analog Devices, Inc. AD7944, AD7985, and > AD7986 ADCs. > > Signed-off-by: David Lechner Hi David, One trivial comment. If this is all that comes up I can tweak that whilst applying. Jonathan .. > + adi,spi-mode: > + $ref: /schemas/types.yaml#/definitions/string > + enum: [ single, chain ] > + description: | > + This property indicates the SPI wiring configuration. > + > + When this property is omitted, it is assumed that the device is using what > + the he datasheet calls "4-wire mode". This is the conventional SPI mode Stray "he"? > + used when there are multiple devices on the same bus. In this mode, the > + CNV line is used to initiate the conversion and the SDI line is connected > + to CS on the SPI controller. >