Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759494AbYADF60 (ORCPT ); Fri, 4 Jan 2008 00:58:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758193AbYADF5W (ORCPT ); Fri, 4 Jan 2008 00:57:22 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:59442 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1757236AbYADF5U (ORCPT ); Fri, 4 Jan 2008 00:57:20 -0500 Message-ID: <477DC9C1.2000209@cn.fujitsu.com> Date: Fri, 04 Jan 2008 13:53:05 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Andrew Morton CC: Evgeniy Polyakov , LKML Subject: [PATCH 5/5] CONNECTOR: return proper error code in cn_call_callback() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 31 Error code should be set to EINVAL instead of ENODEV if !queue_work(). There's another call of queue_work() which may set err to EINVAL. Signed-off-by: Li Zefan --- drivers/connector/connector.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c index 865303b..37976dc 100644 --- a/drivers/connector/connector.c +++ b/drivers/connector/connector.c @@ -146,6 +146,8 @@ static int cn_call_callback(struct cn_msg *msg, void (*destruct_data)(void *), v if (queue_work(dev->cbdev->cn_queue, &__cbq->work)) err = 0; + else + err = -EINVAL; } else { struct cn_callback_data *d; -- 1.5.3.rc7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/