Received-SPF: pass (google.com: domain of linux-kernel+bounces-89948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20240302212702.15b04552@kernel.org>
References: <20240302212702.15b04552@kernel.org> <20240301163807.385573-1-dhowells@redhat.com> <20240301163807.385573-19-dhowells@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
    Marc Dionne <marc.dionne@auristor.com>,
    "David S.
 Miller" <davem@davemloft.net>,
    Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
    linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 18/21] rxrpc: Use ktimes for call timeout tracking and set the timer lazily
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <645801.1709510325.1@warthog.procyon.org.uk>
Date: Sun, 03 Mar 2024 23:58:45 +0000
Message-ID: <645802.1709510325@warthog.procyon.org.uk>

Jakub Kicinski <kuba@kernel.org> wrote:

> > Track the call timeouts as ktimes rather than jiffies as the latter's
> > granularity is too high and only set the timer at the end of the event
> > handling function.
> 
> This one has a 64b div somewhere, breaks 32b builds.

Ah - in the trace functions to make the ns-level durations into ms-level ones.

I wonder if it's better to just divide by 1024 - so something close to
microseconds - or whether ktime_to_us() can be used there.

David