Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1571789lqg; Sun, 3 Mar 2024 17:25:41 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVP3lD9U+4yzFgZjHtpTcQziJGCO+2G9Le4/4YWkK6Rq3+AvaXbHh3ZcBwuptAfIXG7KaKZ7j3HqpgfmSzhzo6r7cnxYISASNTtjS+yWg== X-Google-Smtp-Source: AGHT+IE0ynCgOphtBPoksYb+Li75SjbRfbwXbh/3I2/HTB4+FbYsAg9d6cUrmFqT+BFcSFQMxpj3 X-Received: by 2002:a17:903:1111:b0:1db:edfa:7713 with SMTP id n17-20020a170903111100b001dbedfa7713mr7439311plh.18.1709515540750; Sun, 03 Mar 2024 17:25:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709515540; cv=pass; d=google.com; s=arc-20160816; b=uP3mBoLvRQm3JcVrvKf/1gftISUozMVRwHu4vi0cq/qqF4e2ntFVIGpQtW++gbG8av 7SU8M9tJ0+dGnKVfzIMANxx+PAcVtpNrtm4cRJBdtrEgPR5kyVCVdFEkcwn0rUGsVfAq ue3XYIQCeHZrENJwyPXpKt17luaQrdH0eLg2shE1XN6OKSc2Ayxv0z60uguWI5ZKpI/L OwggRc5QfyeyoPub7sXVJp+eOnzt1Etn8UMpOfEtvQTvg62nvPN+IHZ5IEByG/Qc1sRJ t0UGa3nO7tT/Xjuc0kEAm/JBytdQeOF8dwS7jEFdqsETihStQwAyX6xGQR3SR0EfXqDu osAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=rHYCZBqAmBX0CoFcujP2wCeuu/jRNClBVT5hnT6MToo=; fh=W6COFBd4BX4Q4YpnsinfP4Lifuq45kIfChsHXFM1YEQ=; b=yqAifoWEkvAP5GTQqSKDIDn/FwLcU4LPZybt+uAU6Z5rq54J4wUwLUqkAEaj7nGLfi 9WTh8TiXvRllCytuTyYlSckVEJPfnCcJz88yg6zJWZ0spdUif5JZLvkaIYfcoWntJZE0 pXmH4AJHiU5KRIOtiJzDITGl4ql6C4zIu+A5t6V2JQqbhOpfSmQ98HZL/NrbSaMsmzns InW09h3S4xzfzygtEBFT5X3/tmdiJMsiDmuKHeZpbcZc7qwPz91kSqG7klDi0BQfeYs4 mxkFimGaGaP0FLkEHsRKKk3O/t0jVmfckN7Y2ZGkmU5Z2tpDNhqnS/bI30nBYI7cCTFZ V9IA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BcgTMRwF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89961-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89961-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id n13-20020a170902f60d00b001d7561e0e8fsi7564808plg.263.2024.03.03.17.25.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 17:25:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89961-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BcgTMRwF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89961-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89961-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 61760B20BF7 for ; Mon, 4 Mar 2024 01:25:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 112B21362; Mon, 4 Mar 2024 01:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BcgTMRwF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 375F0399 for ; Mon, 4 Mar 2024 01:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709515529; cv=none; b=okRa0AbvWjxMiKGdFzFqjsNhkxW9zhDq1W3auoZlenwY/tu2SoEnOUSeNpsuPsJ2JZMA6fuEMsRSYqYCnPKBOdPzdd1nFJ4Y0Du5afaCPZF0v9uHXOZHwLYV3hf4nr8GGpFMlOEcRHB/bF1TFrNpuSVplOQ+1Znhvcq6Y7JAiko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709515529; c=relaxed/simple; bh=pbEla8fsO5S9tFM5YQ5Jg2RZxp5KAhMIEyBCKb7QDe4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oHr/Fdtnph+qMUUhiB4bhlTLen2qB5ktxh97Z5iiwgU61VrWi3OgTK83e7YQixl1Di5JmotLIrfC3R7SeO+x6ydLArCAA29O9jlt9+1VgaVF79asXkSqD8ytZ76SVUq6v/9iDoY164pKwwqSW1ifJAYx0Z0ELArlHBsI+YT1oi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BcgTMRwF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08882C433C7; Mon, 4 Mar 2024 01:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709515528; bh=pbEla8fsO5S9tFM5YQ5Jg2RZxp5KAhMIEyBCKb7QDe4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BcgTMRwFyru1beE1rEGlZwJaFGcYHbNTONO6IkTTlZAClcIMhuLylkUcRgIbu7l5b 50JNRkZfAghoksI7SsizTo6a8UWwjjcOrGZS76DioS7PNC9LnaIgirwYkEvM+oy6sJ ZALp3Wnvz0wXZxuxqPFXi0TFx1X35rPjYfLFVh1QW7IqcZcghrfvWBIdOanGQ23oin o4nLGBOtUQQF1ITzEWUM5kuK/t32nzF3KEb5ONzFU5KlX25T0WJD/A3uY/R2upVi6i +omJnCXHPPbExL3tEVvgCFOAxIzc4fxrNzY27Rzpd1j4pXanuS7AuHYA/+LCorUokG pi6yx322q93Nw== Message-ID: <70320312-de6e-48a1-8074-c4e16e65555e@kernel.org> Date: Mon, 4 Mar 2024 09:25:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] f2fs: fix to check return value __allocate_new_segment Content-Language: en-US To: Zhiguo Niu , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, niuzhiguo84@gmail.com, ke.wang@unisoc.com, hongyu.jin@unisoc.com References: <1709281555-11373-1-git-send-email-zhiguo.niu@unisoc.com> From: Chao Yu In-Reply-To: <1709281555-11373-1-git-send-email-zhiguo.niu@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/3/1 16:25, Zhiguo Niu wrote: > __allocate_new_segment may return error when get_new_segment > fails, so its caller should check its return value. > > Signed-off-by: Zhiguo Niu Reviewed-by: Chao Yu Thanks,