Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1572475lqg; Sun, 3 Mar 2024 17:28:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUqf8lO9zkxmWwObKVtFQ5I2a2IGnnrHgbXRpLNEaOOJ08XaXd/6ECIHoXbDkacEVybyH3IXet42YDBAaMtublbx59BafrC9Hk+NTa6XA== X-Google-Smtp-Source: AGHT+IH6m93Q6favz+XN8eafmbpKiiSJbKSJGApR4drS7aok+ej5VD7EJxQ7f3nmztDbIu1Z/8pw X-Received: by 2002:a17:90a:4402:b0:29a:a378:ce88 with SMTP id s2-20020a17090a440200b0029aa378ce88mr4526897pjg.27.1709515697009; Sun, 03 Mar 2024 17:28:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709515696; cv=pass; d=google.com; s=arc-20160816; b=fu7Lp3wXhnp+0JfHt1p9atY24/Bj7wcryrfqMMqIVig90sa/zMFYjA4NmOghsC/jo8 Dm0iOjcOGzh4qOKdAgJezzpp+r2IINFlCVuCeMebUOojDlPyBN/HL/SuTWnxCvTz0keM ZrPSbXV6X7o77JjTyLysvtcq/cCQePBTaUTYNoVTrbFvN8qqDebpZT2OdQBoMjZQGtIb slyQ8/SS8qzgfnR9nsLV1raFBEd7CLzzsXuphJeLnwtpRRefgfkA12BFwLflaegGLN8U k8d4Gb9w3nF/fpkDMo2vbIIsBd/eG00/upOLill2wy0Snu8oPIEofhSqUyjzRaRnOwhw fKFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=KS2t3X2x/N0cF8rwnb74rrQmnOVt6RMpfqor/sAB510=; fh=W6COFBd4BX4Q4YpnsinfP4Lifuq45kIfChsHXFM1YEQ=; b=S5ozhSS/cKAhBbQB2mbMqLrNQNpEEgnf40lufNrvZVpWjyNjUJraH9XrBnLwgxUWFJ 39dZSEpiiEECyO3eaf54U6PCRIrf86RUNx4+3g95to896uuj1y8F0I1xIzWCCwwnPwqD fMLtvy3/LgJYC24nm4cuZ6PuTqTltsPZhm2kJAH6QjiI1HdeKXrRWJfyA2qa9OEY28BQ GyOec0CEFMPjzutEhE1w8UgTFHz/0pf0IXswOOxFo8WJ+W8ugdE0o44qHfbvVUxkMupi eJaGX1d2sD6wHs+tfKePaniHw+f5yN2jOqyQqlKvKPDqACVu9OiV/MxTRU4kctFgmc1g IJKw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nz29fLeJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89964-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89964-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id mh10-20020a17090b4aca00b0029abe2b9066si7812913pjb.172.2024.03.03.17.28.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 17:28:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89964-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nz29fLeJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-89964-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89964-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9C101B20BF7 for ; Mon, 4 Mar 2024 01:28:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5ED5B1378; Mon, 4 Mar 2024 01:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nz29fLeJ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86EB1A31 for ; Mon, 4 Mar 2024 01:28:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709515684; cv=none; b=cOVEN7zod+BfGULFJnXTOOpHaOJxvilcKGDDjs0oPA7gOolR02FxKYcgTCHtGpSIcmVHNTYZVJNDclGVqI50rui+WzCco3tDu/anA6ZTLxbrzJnLf2MrZXSYYLM0VE7Syp/CYM4VsL3r/amY0G2WxyFJLEIUy07jIu8CwBg1o0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709515684; c=relaxed/simple; bh=dfi6Q19o4dtW5X91PjmnXBLO706D9dkUvPeGb9h+fM0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ELDXI/oaoLBM8QoCPArHHT2SV/zQJTxXcnrm3233HgtNhNNvTfRIKVlghpkoFO+ogTBAMUg+GnPlg6gaYQS8Oq3izALb33UBKc3FyxwAGsnzg2OS8X9aYtlwIR/Ngq0vfZkYKkVUckDYYsze0p30//Dtqekr3JuDlPwDzrK54nI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nz29fLeJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BBCAC433F1; Mon, 4 Mar 2024 01:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709515684; bh=dfi6Q19o4dtW5X91PjmnXBLO706D9dkUvPeGb9h+fM0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Nz29fLeJg+Usw8Crmrfb+4d9bClJ5zrgPI9LizBUHJL7PoIi4RW+Dsn3qimX+zpUH 0rtSimQcwEyNA/G+sk6thdQ8DYySOFyrHMlz3IuhtnJRvhBfm00+D8QW+kkUK/cHz5 R83PpJw1cDO4B/5ta/Jp6gNiNrBxfgEALAgEQfkotCds4iYuluddciuqmC2mjt1x0O CanSonz0YjFZ0ERgJs5HjgC+lSXFVQEzXTwt4SsT7dmOQ0o9q+XuCfkGqKIIsSL6NP 1pZfC2Y6Kuiw53kVUUTmvczzE6OdLnAGz3MDZsCi1WHlD+UNdn2kpfOSiCX/0Ze9In ixd7VHC3hewxw== Message-ID: <4ee229e6-53d6-41a0-99a3-49b8f99ea7f2@kernel.org> Date: Mon, 4 Mar 2024 09:27:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] f2fs: fix to check return value of f2fs_gc_range Content-Language: en-US To: Zhiguo Niu , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, niuzhiguo84@gmail.com, ke.wang@unisoc.com, hongyu.jin@unisoc.com References: <1709281555-11373-1-git-send-email-zhiguo.niu@unisoc.com> <1709281555-11373-2-git-send-email-zhiguo.niu@unisoc.com> From: Chao Yu In-Reply-To: <1709281555-11373-2-git-send-email-zhiguo.niu@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/3/1 16:25, Zhiguo Niu wrote: > f2fs_gc_range may return error, so its caller > f2fs_allocate_pinning_section should determine whether > to do retry based on ist return value. > > Also just do f2fs_gc_range when f2fs_allocate_new_section > return -EAGAIN, and check cp error case in f2fs_gc_range. > > Signed-off-by: Zhiguo Niu Reviewed-by: Chao Yu Thanks,