Received-SPF: pass (google.com: domain of linux-kernel+bounces-89974-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 4 Mar 2024 10:13:00 +0800
From: Oliver Sang <oliver.sang@intel.com>
To: Frederic Weisbecker <frederic@kernel.org>
CC: Anna-Maria Behnsen <anna-maria@linutronix.de>, <oe-lkp@lists.linux.dev>,
	<lkp@intel.com>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>, "Thomas
 Gleixner" <tglx@linutronix.de>, <ying.huang@intel.com>,
	<feng.tang@intel.com>, <fengwei.yin@intel.com>, <oliver.sang@intel.com>
Subject: Re: [tip:timers/core] [timers]  7ee9887703:  netperf.Throughput_Mbps
 -1.2% regression
Message-ID: <ZeUuLPXfLCmB39qq@xsang-OptiPlex-9020>
References: <202403011511.24defbbd-oliver.sang@intel.com>
 <ZeUWreWcp4UWQ081@pavilion.home>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZeUWreWcp4UWQ081@pavilion.home>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?qelgy+pCwvMQFUvhL2gdxQsdBoJwj+k0dmYdCRkzI83MbiqyEnIb4KTl2l?=
 =?iso-8859-1?Q?ENuwaQIE7zXhnPtuWvTgYtXK/Fnb5JB6iVaqAlzvutOXEGDFMf9t4Y6iLG?=
 =?iso-8859-1?Q?VeEP6bzQR2OCAApWp3WdV+2sKTjUQ46W6zNeg8hHxhzL1kpjOzla3ygj0I?=
 =?iso-8859-1?Q?/C+ly7cx/ysXDRC8F0NwMOaHeWnLNwJ5ppbUBC8iYRwz9GBkhjq42YU0/q?=
 =?iso-8859-1?Q?TMx2PmsBLLhViMDdU0hd6SZpJYDVPPX0+jzsj2FAAG7/cd8B9p/C5CJjqj?=
 =?iso-8859-1?Q?ESF5aOpwHblbSFXIIBp/hR/kgtNnYvvkLTTsENE4qXT7emHGHZK0y5K2gJ?=
 =?iso-8859-1?Q?k18KZmZoEE6i+r8AsMzeBHy2Jqa7FQ7s3g8H17nnEPz3WtxvigbpJsISqj?=
 =?iso-8859-1?Q?tuaoRpZ1o80/bW2xTVdLtVq72yICYsrjIy4MFZVLFamoqQt61AzHUfM4SU?=
 =?iso-8859-1?Q?4Z6eZEihEKbWn2kOxxflPXp1kaZvXKsca3GMx6Eb81qsGsK8nOJCmp+EFM?=
 =?iso-8859-1?Q?QC6jLFtnsP96RE7Bl6bc1jh8BaO1/3mKNrFZJ00Jl9lPVXq4CfRLMVsXJt?=
 =?iso-8859-1?Q?L7YYfV2ci7xylGbThC6YeRusp3tOT3SGmp96AhmawElkKCJTAIKRcrxYZz?=
 =?iso-8859-1?Q?B/XijUuksXOWGoXFF7oKLrO1st+P1uwiNJI0NnxfC27CYDL3GYYzI7nMEb?=
 =?iso-8859-1?Q?dkXb9QD5KcUZvnmwF9m6b8Vy8PP/WwYNdJA3h3BxavUVZR6rY2rH1g9b0p?=
 =?iso-8859-1?Q?a/DBPqPNACByw005TwGUSCW9Mn0Me3tG048w+LP53OA5XtNXVoTSLHPOKH?=
 =?iso-8859-1?Q?8pzOpQCZNFk1mRCIwQYhBDPq0YrVD7DcBvSKxJBYu6VKd01wF8HF+7V+Wl?=
 =?iso-8859-1?Q?nfimMF12hkL8OEZ/cBEtHS95jL2GXg8lHztqz0t1VrudvMkkP738CzOHel?=
 =?iso-8859-1?Q?wb17mvDbapxwmWvQXLWorejPOMiU5haGK/+TD7qO/EwkLERiKz323h3W8e?=
 =?iso-8859-1?Q?skBlBMUY+BMKxoAhLLLDNP3M5PhpnKUiIDFuw2JCohp4IAAFUCv3HFpsYL?=
 =?iso-8859-1?Q?YvpIWFoyqHlJKqFhreZPD1RWlcMOqgnziYgYfQ1TiMevnvOoBjO0CicYUd?=
 =?iso-8859-1?Q?CZay2Taa405tzo559kPKporrsIk271Q+xU/Q4nln6kSLN+iHw/PmyfoWpv?=
 =?iso-8859-1?Q?Yz2I1seBpu1NVk0AONcaHd0GEHoY+rxJ87Xt0HFVCkooOOPKHc7iSkcJ6P?=
 =?iso-8859-1?Q?+UWwRS6w4cwLHJ+iEYpmpV/XBckz7TRMX6zzVY6GVBaoq1jzdz1Os1YNUE?=
 =?iso-8859-1?Q?9337sBarqqdoRQXnlKw/Xpfyj+ND4/o8PYL0vkNpxV9KH66FhsvwUJgiop?=
 =?iso-8859-1?Q?eaWVkPveW3cGE3fGDrpSNCfoGMD8YtE1PynAIOO7UW7+iE1kkVNXRVBKTI?=
 =?iso-8859-1?Q?vijfr5GmG6oFhzg/q9H+OxJynJA+f+isdOxAH8YzzWGEBxpm+xpl/EaoLc?=
 =?iso-8859-1?Q?nphpFcOfNvNCNJAv+fKFby1tPne4Jzn7oYHNu59bERTL7iNsOWJQFkUGDl?=
 =?iso-8859-1?Q?c34yNEgsaPg+ldTPosTHPyRkxivlO6K8yie35UP2AcX4/ydZID+jOAnNAI?=
 =?iso-8859-1?Q?OmDkO4zFV5NkCRHiWIfIXELOO1ye/x2mga?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aa8b6b9c-893a-452b-82d9-08dc3bf0a2b9
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 02:13:09.1118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lJi0ADTmtD16HbxR4HlX5LpjMVsS7zI9udVMTPXQSwe/00qrNZbkmOhYMYIxKScvlKsaR+Xf+FTGuAWGZ3JBwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8535
X-OriginatorOrg: intel.com


hi, Frederic Weisbecker,


On Mon, Mar 04, 2024 at 01:32:45AM +0100, Frederic Weisbecker wrote:
> Le Fri, Mar 01, 2024 at 04:09:24PM +0800, kernel test robot a ?crit :
> > 
> > 
> > Hello,
> > 
> > kernel test robot noticed a -1.2% regression of netperf.Throughput_Mbps on:
> > 
> > 
> > commit: 7ee988770326fca440472200c3eb58935fe712f6 ("timers: Implement the hierarchical pull model")
> > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git timers/core
> > 
> > testcase: netperf
> > test machine: 128 threads 2 sockets Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz (Ice Lake) with 256G memory
> > parameters:
> > 
> > 	ip: ipv4
> > 	runtime: 300s
> > 	nr_threads: 200%
> > 	cluster: cs-localhost
> > 	test: SCTP_STREAM
> > 	cpufreq_governor: performance
> > 
> > 
> > 
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <oliver.sang@intel.com>
> > | Closes: https://lore.kernel.org/oe-lkp/202403011511.24defbbd-oliver.sang@intel.com
> > 
> > 
> > Details are as below:
> > -------------------------------------------------------------------------------------------------->
> > 
> > 
> > The kernel config and materials to reproduce are available at:
> > https://download.01.org/0day-ci/archive/20240301/202403011511.24defbbd-oliver.sang@intel.com
> > 
> > =========================================================================================
> > cluster/compiler/cpufreq_governor/ip/kconfig/nr_threads/rootfs/runtime/tbox_group/test/testcase:
> >   cs-localhost/gcc-12/performance/ipv4/x86_64-rhel-8.3/200%/debian-12-x86_64-20240206.cgz/300s/lkp-icl-2sp2/SCTP_STREAM/netperf
> > 
> > commit: 
> >   57e95a5c41 ("timers: Introduce function to check timer base is_idle flag")
> >   7ee9887703 ("timers: Implement the hierarchical pull model")
> 
> Is this something that is observed also with the commits that follow in this
> branch?

when this bisect done, we also tested the tip of timers/core branch at that time
8b3843ae3634b vdso/datapage: Quick fix - use asm/page-def.h for ARM64

the regression still exists on it:

57e95a5c4117dc6a 7ee988770326fca440472200c3e 8b3843ae3634b472530fb69c386
---------------- --------------------------- ---------------------------
         %stddev     %change         %stddev     %change         %stddev
             \          |                \          |                \
      4.10            -1.2%       4.05            -1.2%       4.05        netperf.ThroughputBoth_Mbps
      1049            -1.2%       1037            -1.2%       1036        netperf.ThroughputBoth_total_Mbps
      4.10            -1.2%       4.05            -1.2%       4.05        netperf.Throughput_Mbps
      1049            -1.2%       1037            -1.2%       1036        netperf.Throughput_total_Mbps


> 
> Ie: would it be possible to compare instead:
> 
>     57e95a5c4117 (timers: Introduce function to check timer base is_idle flag)
> VS
>     b2cf7507e186 (timers: Always queue timers on the local CPU)
> 
> Because the improvements introduced by 7ee9887703 are mostly relevant after
> b2cf7507e186.

got it. will test.

at the same time, we noticed current tip of timers/core is
a184d9835a0a6 (tip/timers/core) tick/sched: Fix build failure for CONFIG_NO_HZ_COMMON=n

though it seems irelevant, we will still get data for it.

> 
> Thanks.