Received-SPF: pass (google.com: domain of linux-kernel+bounces-89988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 4 Mar 2024 10:19:35 +0800
From: Yan Zhao <yan.y.zhao@intel.com>
To: Sagi Shahar <sagis@google.com>
CC: <linux-kselftest@vger.kernel.org>, Ackerley Tng <ackerleytng@google.com>,
	Ryan Afranji <afranji@google.com>, Erdem Aktas <erdemaktas@google.com>,
	"Isaku Yamahata" <isaku.yamahata@intel.com>, Sean Christopherson
	<seanjc@google.com>, Paolo Bonzini <pbonzini@redhat.com>, Shuah Khan
	<shuah@kernel.org>, "Peter Gonda" <pgonda@google.com>, Haibo Xu
	<haibo1.xu@intel.com>, Chao Peng <chao.p.peng@linux.intel.com>, Vishal
 Annapurve <vannapurve@google.com>, Roger Wang <runanwang@google.com>, Vipin
 Sharma <vipinsh@google.com>, <jmattson@google.com>, <dmatlack@google.com>,
	<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [RFC PATCH v5 10/29] KVM: selftests: TDX: Adding test case for
 TDX port IO
Message-ID: <ZeUvtzHmMo9jdMnu@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20231212204647.2170650-1-sagis@google.com>
 <20231212204647.2170650-11-sagis@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231212204647.2170650-11-sagis@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?45a9a2mGA2JvfqnFCXcU3vPCMEWAPGM6wcGjKRTRRqj5eqThzS909PrwqXeW?=
 =?us-ascii?Q?wi3MPfsmKbp0u3dfodVCbLjsDXuPTZ0VpMnZwT57uUKupZmeO8Uk1+WbnLAS?=
 =?us-ascii?Q?Df4nSxiU2/har1Jzfihc8c9Bz9XvqAd0wM2XCtIrkbwkMDnvAzSFPV4G6RZ0?=
 =?us-ascii?Q?nMN2qOe0RKSNGWVDd5lgmd8jDbXQCFsHgw3leXgfc56Tnl0wD0zHIPDg0wN6?=
 =?us-ascii?Q?9tUussFQsHI7krVYxLw5P6rkyYcw4SznDkozlYvsndp4jwE4FyiQRv+enPP5?=
 =?us-ascii?Q?1SgMDhNx1qZtCCRCQnvY9DmAa1NUq3oOt5wPQ8KK1S4xRXsqCwvWwyMV/YGH?=
 =?us-ascii?Q?c9r/ozg3gpnI0IxFPisr7tcOJe85rofdbU4qTEiVvUq5g2ObuWoFLCpzHr07?=
 =?us-ascii?Q?m2Q4/SjQtk7tpax2aR5S6IIpPU7DCbYf2zDeUYbBaJvU2Xl8OjbjAmHJjvf6?=
 =?us-ascii?Q?af+lguS0QRyg9pFhdtfmA1GBajuQVZB0RoC4N0k2AbbvUnjs4vRPt5qBTQt9?=
 =?us-ascii?Q?nrLsFyw4JcWqh2xsoiPMYwh/qu5+aC1uWq+bwEuV05GdMdEIsoFP1KQLlKbK?=
 =?us-ascii?Q?Z65pAJNxq661Yomu5HI12/seyLaV+txz26gdMXpvjvSgEvsTCMKQLg1+Ekz/?=
 =?us-ascii?Q?09J0LtrKY5GfLMHXtGCEXKNIluHCf3k8VdGcRuBHkBQND7tgrwDI1PzzRh8r?=
 =?us-ascii?Q?mYA+gtOQ1XWqszKSqUROd07d98EmttdNykDjHPZg8P+5VWxEKQPZ9J3EWThC?=
 =?us-ascii?Q?RxQace8pcUS6RvZFNB8YMgng6kdsMCp0qALC5Ga1fjCQ0+lVS+fGbnNc98/5?=
 =?us-ascii?Q?wLkdOwaak4YWcGWRe5lBvRJaiRLeqqU1IQ+07RCjLRXWoyKkp7Ju1Ae5awip?=
 =?us-ascii?Q?fRx8oYsI4TTwwQe2kWQrkBnoZpYFa6p3tETNQhL3WsoUABFIZHtNULjfsZTl?=
 =?us-ascii?Q?Cfa9TbUd4EIGykyCadYHJ5I6zIp6W4Ju2wRELpl+5PFBviRWgKiaqzRHE1++?=
 =?us-ascii?Q?q2O+CBVlSouNq4GgzQ2+J33bNhpTsy0gnEf2EKupUq64XxJcTxqxd4qZhWIg?=
 =?us-ascii?Q?Rfbjc6MGvHFs4Ee+Uk38vlQWCTJ9HBhOjj4vYnzCcQZqn+lehfloBvacafpp?=
 =?us-ascii?Q?LCBUbqbJCGRSNzZK5g2ZhhE2+zzwPeaULSB2ibs9aX1g851u9H/cUJ09OxUz?=
 =?us-ascii?Q?FPJWwRBeWAwvsRhRTm0l/DZzfFP8G8J5Of4V7Lo9Xm5/L8zLxBy8YCnkOtzQ?=
 =?us-ascii?Q?B5x/mPVjQMw4m/qnOYoU4ZnyWHuPl/DQf1zCwA0assbUIbH06lOR2ykdz4Lo?=
 =?us-ascii?Q?TB1R/p8cXVwOnUH4vinCAUCeVhsF3V22bWAe8IM5QACnR8KVn+lJDCHxTRAB?=
 =?us-ascii?Q?CrFraiNQZlZkpmhmQtdlJMwKdg704lyoQQQvmHLbKXebtL+AegI93xQThICC?=
 =?us-ascii?Q?EoKImgsUA6PoNzAh/qcWKSZmegGfas/REaodsyfBpako+a7AGT/oVi+GeINW?=
 =?us-ascii?Q?/solB5I6+TQYxTr7q4dHZ0vpfZ8p345an5azBSGvHt0F5CCceFGgR8sUTQeX?=
 =?us-ascii?Q?YE4bK1cNceMl0W3X7eoM1h1WmHMGD7ZPlVG1I1vQ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e2c705d3-f419-4f19-0fdd-08dc3bf5b485
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 02:49:26.3183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A1ymtJf9Q7qfPnPq0/uQeWDmD4vuk1UPjCg/F8k1IifqyTb2+QvQSiHqv2UI8XeIVaO/WIcN2nwqj0+83S2orw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7248
X-OriginatorOrg: intel.com

On Tue, Dec 12, 2023 at 12:46:25PM -0800, Sagi Shahar wrote:
> From: Erdem Aktas <erdemaktas@google.com>
> 
> Verifies TDVMCALL<INSTRUCTION.IO> READ and WRITE operations.
> 
> Signed-off-by: Erdem Aktas <erdemaktas@google.com>
> Signed-off-by: Sagi Shahar <sagis@google.com>
> Signed-off-by: Ackerley Tng <ackerleytng@google.com>
> Signed-off-by: Ryan Afranji <afranji@google.com>
> ---
>  .../kvm/include/x86_64/tdx/test_util.h        | 34 ++++++++
>  .../selftests/kvm/x86_64/tdx_vm_tests.c       | 82 +++++++++++++++++++
>  2 files changed, 116 insertions(+)
> 
> diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h
> index 6d69921136bd..95a5d5be7f0b 100644
> --- a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h
> +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h
> @@ -9,6 +9,40 @@
>  #define TDX_TEST_SUCCESS_PORT 0x30
>  #define TDX_TEST_SUCCESS_SIZE 4
>  
> +/**
> + * Assert that some IO operation involving tdg_vp_vmcall_instruction_io() was
> + * called in the guest.
> + */
> +#define TDX_TEST_ASSERT_IO(VCPU, PORT, SIZE, DIR)			\
> +	do {								\
> +		TEST_ASSERT((VCPU)->run->exit_reason == KVM_EXIT_IO,	\
> +			"Got exit_reason other than KVM_EXIT_IO: %u (%s)\n", \
> +			(VCPU)->run->exit_reason,			\
> +			exit_reason_str((VCPU)->run->exit_reason));	\
> +									\
> +		TEST_ASSERT(((VCPU)->run->exit_reason == KVM_EXIT_IO) && \
> +			((VCPU)->run->io.port == (PORT)) &&		\
> +			((VCPU)->run->io.size == (SIZE)) &&		\
> +			((VCPU)->run->io.direction == (DIR)),		\
> +			"Got unexpected IO exit values: %u (%s) %d %d %d\n", \
> +			(VCPU)->run->exit_reason,			\
> +			exit_reason_str((VCPU)->run->exit_reason),	\
> +			(VCPU)->run->io.port, (VCPU)->run->io.size,	\
> +			(VCPU)->run->io.direction);			\
> +	} while (0)
> +
> +/**
> + * Check and report if there was some failure in the guest, either an exception
> + * like a triple fault, or if a tdx_test_fatal() was hit.
> + */
> +#define TDX_TEST_CHECK_GUEST_FAILURE(VCPU)				\
> +	do {								\
> +		if ((VCPU)->run->exit_reason == KVM_EXIT_SYSTEM_EVENT)	\
> +			TEST_FAIL("Guest reported error. error code: %lld (0x%llx)\n", \
> +				(VCPU)->run->system_event.data[1],	\
> +				(VCPU)->run->system_event.data[1]);	\
> +	} while (0)
> +
>  /**
>   * Assert that tdx_test_success() was called in the guest.
>   */
> diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c
> index 8638c7bbedaa..75467c407ca7 100644
> --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c
> +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c
> @@ -2,6 +2,7 @@
>  
>  #include <signal.h>
>  #include "kvm_util_base.h"
> +#include "tdx/tdcall.h"
>  #include "tdx/tdx.h"
>  #include "tdx/tdx_util.h"
>  #include "tdx/test_util.h"
> @@ -74,6 +75,86 @@ void verify_report_fatal_error(void)
>  	printf("\t ... PASSED\n");
>  }
>  
> +#define TDX_IOEXIT_TEST_PORT 0x50
> +
> +/*
> + * Verifies IO functionality by writing a |value| to a predefined port.
> + * Verifies that the read value is |value| + 1 from the same port.
> + * If all the tests are passed then write a value to port TDX_TEST_PORT
> + */
> +void guest_ioexit(void)
> +{
> +	uint64_t data_out, data_in, delta;
> +	uint64_t ret;
> +
> +	data_out = 0xAB;
> +	ret = tdg_vp_vmcall_instruction_io(TDX_IOEXIT_TEST_PORT, 1,
> +					TDG_VP_VMCALL_INSTRUCTION_IO_WRITE,
> +					&data_out);
> +	if (ret)
> +		tdx_test_fatal(ret);
> +
> +	ret = tdg_vp_vmcall_instruction_io(TDX_IOEXIT_TEST_PORT, 1,
> +					TDG_VP_VMCALL_INSTRUCTION_IO_READ,
> +					&data_in);
> +	if (ret)
> +		tdx_test_fatal(ret);
> +
> +	delta = data_in - data_out;
> +	if (delta != 1)
> +		tdx_test_fatal(ret);
> +
> +	tdx_test_success();
> +}
> +
> +void verify_td_ioexit(void)
> +{
> +	struct kvm_vm *vm;
> +	struct kvm_vcpu *vcpu;
> +
> +	uint32_t port_data;
> +
> +	vm = td_create();
> +	td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0);
> +	vcpu = td_vcpu_add(vm, 0, guest_ioexit);
> +	td_finalize(vm);
> +
> +	printf("Verifying TD IO Exit:\n");
> +
> +	/* Wait for guest to do a IO write */
> +	td_vcpu_run(vcpu);
> +	TDX_TEST_CHECK_GUEST_FAILURE(vcpu);
This check is a vain, because the first VMExit from vcpu run is always
KVM_EXIT_IO caused by tdg_vp_vmcall_instruction_io().


> +	TDX_TEST_ASSERT_IO(vcpu, TDX_IOEXIT_TEST_PORT, 1,
> +			TDG_VP_VMCALL_INSTRUCTION_IO_WRITE);
> +	port_data = *(uint8_t *)((void *)vcpu->run + vcpu->run->io.data_offset);
> +
> +	printf("\t ... IO WRITE: OK\n");
So,  even if there's an error in emulating writing of TDX_IOEXIT_TEST_PORT,
and guest would then find a failure and trigger tdx_test_fatal(), this line
will still print "IO WRITE: OK", which is not right.

> +
> +	/*
> +	 * Wait for the guest to do a IO read. Provide the previous written data
> +	 * + 1 back to the guest
> +	 */
> +	td_vcpu_run(vcpu);
> +	TDX_TEST_CHECK_GUEST_FAILURE(vcpu);
This check is a vain, too, as in  write case.

> +	TDX_TEST_ASSERT_IO(vcpu, TDX_IOEXIT_TEST_PORT, 1,
> +			TDG_VP_VMCALL_INSTRUCTION_IO_READ);
> +	*(uint8_t *)((void *)vcpu->run + vcpu->run->io.data_offset) = port_data + 1;
> +
> +	printf("\t ... IO READ: OK\n");
Same as in write case, this line should not be printed until after guest
finishing checking return code.

> +
> +	/*
> +	 * Wait for the guest to complete execution successfully. The read
> +	 * value is checked within the guest.
> +	 */
> +	td_vcpu_run(vcpu);
> +	TDX_TEST_CHECK_GUEST_FAILURE(vcpu);
> +	TDX_TEST_ASSERT_SUCCESS(vcpu);
> +
> +	printf("\t ... IO verify read/write values: OK\n");
> +	kvm_vm_free(vm);
> +	printf("\t ... PASSED\n");
> +}
> +
>  int main(int argc, char **argv)
>  {
>  	setbuf(stdout, NULL);
> @@ -85,6 +166,7 @@ int main(int argc, char **argv)
>  
>  	run_in_new_process(&verify_td_lifecycle);
>  	run_in_new_process(&verify_report_fatal_error);
> +	run_in_new_process(&verify_td_ioexit);
>  
>  	return 0;
>  }
> -- 
> 2.43.0.472.g3155946c3a-goog
> 
>