Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1605395lqg; Sun, 3 Mar 2024 19:24:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUC7GKZh4a6InWb8E0SaOB9G+zvP+NwkRH9JLZsw3mOAJkKI7q2Rzu4Dg+5a+pQSe/SoVi6AmTD/EdgNbh47L5/r4II0o6wv8l1Dy4IVg== X-Google-Smtp-Source: AGHT+IFFCDOeRmld0StqeC335I/aGMvUqyO7WJXjZwyrEX85cewnhV5ykOvXbVgkkpms16KZg+8m X-Received: by 2002:ac8:7d54:0:b0:42e:d5a3:e03e with SMTP id h20-20020ac87d54000000b0042ed5a3e03emr8412578qtb.53.1709522696907; Sun, 03 Mar 2024 19:24:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709522696; cv=pass; d=google.com; s=arc-20160816; b=Veas4q0L2EiwjegKFyLxIS1tYVYi+XWe6Uy0vrQo3m5mAkPxf9Eb1Qowk0DNApSds/ w9OVWYvxOUVHYEKnM+J/k0JN2xSsH7O6skiYHQD0ijT3Yjbp1wMx/pYQy2fUhcJn5eye 9Wgba1l9hDOFYQx+B9rQuXPOSTEmYyCz+2vJ7Pp42xNzho4f0h56zGTpS7ZNCJW1HPMe wHWQQbWv/Ava6q78IRVpYSzWu3C+9CFnR2jRzpJYbiaiqsoN6JnPjP0BQA5oAIzuvHMW URbGHwAR18pROUs1CHa4J6EYZTPqPd9w5KfH46+DCv29Z08MljtLXENPkDftYUYE2Q2Y Tq6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=BzTSepAuqFk2iwTMwG1megTwsCGBNZgyhxfUaw1EYww=; fh=pf8+5YHJc8rVJ+a5bQ/tNZlqgH0/SM4jiETxUPyk0qk=; b=l5caciFH0leYzPpyelMlG/MtZAgR6tgvqz6fCsodxHRPKFcyY7uScg/B7WM0O2ub1H TncNRzw/XMKlv1RDNTinSOHfw6j8GD7vApMFJhKppaC4BBl2OYtgkUMm7h+8PzxIZ9Vb SV++wrLWNC8MqLGB2kyGnIGUeDLnLEM8Nzi5bGFxTChi5i1MONL8dJbqcDF99RrbhC3x 5ObVpiEfNk06G/OGoaRM3GF0tyqBJyRvXPbfbeZnESqNOPubT5GDljGj95740HIbC6LR cpO2tleP3jLyIPjDsQ1x5tkPXSQjKSaklYTULywI1pXB3VKcSx8upl3ave3V9OvRj0EQ 860w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KhB8Z4At; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-90009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90009-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j6-20020a05622a038600b0042d24a32838si9106908qtx.54.2024.03.03.19.24.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 19:24:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KhB8Z4At; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-90009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90009-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A274D1C20A2A for ; Mon, 4 Mar 2024 03:24:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 026B14696; Mon, 4 Mar 2024 03:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KhB8Z4At" Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A1FE4409 for ; Mon, 4 Mar 2024 03:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709522690; cv=none; b=WHbEkjv3KJMPkVAg+C3fsxKRnI/TyMNiSRHcR0QjgjS0XsQKYFhxDC/r12w83haiNCHRS+aINqGoxnXhNvo01eBMwLDaMTKox6D+UyHPYtwTmy/KzJnvYNCxvdUJi8GWBpvDzjVvQjDTR5NWiV2PVwJkaPxCXlSMqb17/pTnIK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709522690; c=relaxed/simple; bh=BzTSepAuqFk2iwTMwG1megTwsCGBNZgyhxfUaw1EYww=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=UBMzynMfujVgkRGWzdkyuTrLpwl8qPWTf7me/ucwnWPBDzAte5xK4VLlgkH8SGUrtR0qZC0fnWngIel+lfdJfXbQxVhShKhrhfH0QjYtlwtjFNEd6c6alvfGy2q1TW2eUFiner6IzTbKotwF2NSGNjAAnxCLzU2opaLgDudTh9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=KhB8Z4At; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2d3b93e992aso6237681fa.1 for ; Sun, 03 Mar 2024 19:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709522687; x=1710127487; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BzTSepAuqFk2iwTMwG1megTwsCGBNZgyhxfUaw1EYww=; b=KhB8Z4AthnVazVBZVAEjV1VhR6ABdg/FOZhEbUSSUCto9mw3eNQwZHBiJGRv+JnpiA g8LCBQrPhmsMkO9oqSLJrnMzf0kF9Hx8aUwW4PiNGYrVYA3CMPQrQzcsRepHvkUNNZmK OwiQigh+IphXWBA6AgCvD1SXR7wVUTh7M/nOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709522687; x=1710127487; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BzTSepAuqFk2iwTMwG1megTwsCGBNZgyhxfUaw1EYww=; b=cyrxJHK/5Y3GJ6xRhRUSR01aHEpBd64MCdF+eFbHhwkXf9zqgPWuh//YcgK0ZfSXR5 JK90CjWYl4A4IjfJONnXUD80wD/m1JM9vQyVlfz1isQdOBBWe2M6r0M+4SvHjH1n1Oqs KzGlMp3PslyHe/R1/s+unXjXX8aEwNkh+eNYXCzDe+O7JmFP2tDBdsL6MUsG5SoSCW8f r8v1vwANWKkvzlE+ju52aJT12ynh9ACQ+QjhBpRJ8Ejn2R38rahW0Yoij6OfTDCCknKN k5dquyOYZnKIMNzldJKCo85cqRiUI2dUgoBbRK0MSaFW+2yf08FgcAFFR7fWVtDPdGeX OP2w== X-Forwarded-Encrypted: i=1; AJvYcCVtOhZmXT+ezf3FaBhxQGvA2BHrYWVl2jvDxlHO8hDDU2jkGabPOQPOZhE3INlky1athWCk3NhPQJSIL4cG/Koj20BO+Cvetpzd+f6I X-Gm-Message-State: AOJu0YyebY4VyVbu9R4Ysx8rdA8rB7j9i24zH1Tl59vzZ9j+9Xcvz+hr HEWd+b3rLN2fk9PFl0AAW52H7w7Hs5t+rxpTpkbTxOFxQX8e1JhzyjV2Ea629WvMuQHZYL5AB1K gP5aF/NhOH3Cv1DPI61QwZhhPoay3zK3BzWKF X-Received: by 2002:a2e:720c:0:b0:2d2:f429:3a93 with SMTP id n12-20020a2e720c000000b002d2f4293a93mr5725775ljc.42.1709522686619; Sun, 03 Mar 2024 19:24:46 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240303120732.240355-1-andy.shevchenko@gmail.com> In-Reply-To: <20240303120732.240355-1-andy.shevchenko@gmail.com> From: Chen-Yu Tsai Date: Mon, 4 Mar 2024 11:24:35 +0800 Message-ID: Subject: Re: [PATCH v1 1/1] clk: fractional-divider: Use bit operations consistently To: Andy Shevchenko Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Mar 3, 2024 at 8:07=E2=80=AFPM Andy Shevchenko wrote: > > Use BIT() where makes sense. This alings usage of bit operations > in the same pieces of code. Moreover, strictly speaking by the > letter of the C standard, left shift of 1 by 31 bits is UB (undefined > behaviour), switching to BIT() addresses that as well. > > Signed-off-by: Andy Shevchenko Reviewed-by: Chen-Yu Tsai