Received-SPF: pass (google.com: domain of linux-kernel+bounces-90039-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Frank Li <Frank.Li@nxp.com>
Date: Sun, 03 Mar 2024 23:32:53 -0500
Subject: [PATCH 1/4] dmaengine: imx-sdma: Support allocate memory from
 internal SRAM (iram)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240303-sdma_upstream-v1-1-869cd0165b09@nxp.com>
References: <20240303-sdma_upstream-v1-0-869cd0165b09@nxp.com>
In-Reply-To: <20240303-sdma_upstream-v1-0-869cd0165b09@nxp.com>
To: Vinod Koul <vkoul@kernel.org>, Shawn Guo <shawnguo@kernel.org>, 
 Sascha Hauer <s.hauer@pengutronix.de>, 
 Pengutronix Kernel Team <kernel@pengutronix.de>, 
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>
Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
 linux-kernel@vger.kernel.org, imx@lists.linux.dev, 
 Frank Li <Frank.Li@nxp.com>, Nicolin Chen <b42378@freescale.com>, 
 Shengjiu Wang <shengjiu.wang@nxp.com>, Joy Zou <joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c0JVbHcvaU5QZWpSTFp4YWRoZmdFam9Lb2IvRkF5dW1JVHpld2pBZEwxM2pS?=
 =?utf-8?B?NVF5czZmckV5NmpKRUQxa3FJOE9vQ3FPZzdVZGc1d0tEU2s3b2YrV3JVd0RH?=
 =?utf-8?B?NDFNbmNZQnZiK1RGYkpqck1KRVlXZ3J2b21Qc0t5blM0RFFpUFRFLzgzUDhs?=
 =?utf-8?B?L05UUUtMck96QkFQUXdVb2ZVTGVKUDRUcXhHeWFxNmszb1ZzREZBbkRPU0hN?=
 =?utf-8?B?V21IVncyVCtOeXJoUFFRQVc2ZFQxMmY2dVJwc0RqOFBsVCtqSUUrZGdsei9n?=
 =?utf-8?B?QTVWK1hZODFVMU52Nld5WHMzNFc2Sm5seVRYdmZHZzdySVBjRGc3QlE2WnAy?=
 =?utf-8?B?SExmdWw3ME4yUUliN0txcC9RcFpJaSs0Zy9HNThWZ1FsVmFWZlNQOWlIYjRi?=
 =?utf-8?B?QkNVTlFqUUZhMzExUGgzV3pvSTlmM01IeURKR1pubW4xblNHSHF2QWtLNWFK?=
 =?utf-8?B?bWZadEkrUS9YdGRyRk8vNTNscUNCNitoQzBTZDk3TThjanEwazlNaU1UZk1t?=
 =?utf-8?B?SGlmanJBa3ZSSUEwUTE3c3g0eUdRRFgxTEJwNWpJTWs5NExzaEVWbXVnUllw?=
 =?utf-8?B?dEQ3Sjl4bUR5WkxlSEU3UW1qajdzUTcrdnJzNkpMVWF5UEw0RXRUNC9ZVjYy?=
 =?utf-8?B?OWhpeHdvRDFIMmpLK3dQMk95bzN5VVdHcVIxRUxGaFQ0WUQ2VWNyMVZRVVJa?=
 =?utf-8?B?bjBjclIxOVJ1bjdFT3pQNGFnK2Z2dG1SWDZUdTJISmIvbGlIdWd4Vlg2blhv?=
 =?utf-8?B?azlTZDJVVHRpenZ5T3A1ZkdCQkNBenYvOXBUb0V2SWVzWmMwODlGOGw5cU5O?=
 =?utf-8?B?VGRCb2tEbjYyMEcwbnZUYUZZTDZQUVd5TXB6aXFZbnh3Ri95eStkVkhQWXBF?=
 =?utf-8?B?MTZRVlQvU3dQbFlqclVQUlpZS0VZV09DQk1wb1RETDdZdytzQlI1cks0Ylc0?=
 =?utf-8?B?VGl1ZEppczdSbk4vOStBT0JBUDh6SW5SbnhPZEgvdGtoL0RYWFk3b1NHZzZL?=
 =?utf-8?B?MkxkN1ZUOFpVTERkWkhOVmd5THdvZC80UGR5SVRxU2NtNDY0MTFGSTBJbGdy?=
 =?utf-8?B?ZXFGTXkvbTdUM3dHL0I3TitsSjdYUk03S2pvN0s5TU03U1pYSHd5UjNOZlZ3?=
 =?utf-8?B?RUo3bElKZ2hpL2M5ME5QZGoyR1VWM2ZRVFEzc3dsdnhpYWZteDlYSXFDcW9o?=
 =?utf-8?B?aUNTQS9ReW5FeGRIeVhQYW8xZVNKVjRJclZMOTd6K2Y5NWc0elFtdUsraDhn?=
 =?utf-8?B?MnhVZ2wzdFEzTWRTVkxhbWlqWEVrT3NjMzB0RUNwQmlhZ0F6MGw2dElJVFBL?=
 =?utf-8?B?d0VUc2ErRGwweHBCMDRjaGd4cUdlYkdxTGQwZUFRNzBYN3dGdDU4RERWK1lH?=
 =?utf-8?B?QlAwbTZ2L0dxdWZRYlc0NVFoNTlGc3N0cDk5OWw2dWMzZzZvcXYwWHdlTTZj?=
 =?utf-8?B?Tkk0VEpNaGd3NmRhTjk0clF2SGxYME4wQ0UvWFZGRGo0MW1ab2U2ZlJydTFC?=
 =?utf-8?B?d2dIMzZoRkZPbHZpWFpaYzVuZ0pBMUxoaVlZY0ZoUCsvOXZHYnIzVDBYNTJM?=
 =?utf-8?B?Q01LNlR4Z2hkNXJLdFEwbkFjeGNxVGRleWdMbVpTWUlXZ0FHUHN1Nko3QU84?=
 =?utf-8?B?eHo4dml0eGI4MUx6Z0xiV1VlbUtEaTl1ME9ZeUU0d2wxdW9Od0ZWWEtMb3VV?=
 =?utf-8?B?UUEwTjNzbFR2WFhmaVFLNS9NYW55a0luZEpsbXhnNFdNdThlalVWSHRHZ0JF?=
 =?utf-8?B?VlpoaXc3OS9ONmdXQ2pkTGdhb3d6UzNLNjRsUmp4cXBIaVNralAzRkJPYzEw?=
 =?utf-8?B?RDVpV1FDN3AycWJKQW9kQVhPZm56VXk2UU1EVXJKRVlubHdUS084ZFBQcFZu?=
 =?utf-8?B?bEhGd3JRc25nVHN3OTNrdURuM0JyUHVIOGtKVEVCUjdBcWcxNzNpVWNVOE1V?=
 =?utf-8?B?Z2tyQkZwTGU2akZMakdENGZHMXdvd2ZjamRiblQ5YjVuVXVHOEdvdXJkdlBS?=
 =?utf-8?B?TEZRT3FVQ3F5ZWdaWUdXRkVyU0RseTByVjVTOVBnMHlYbHMyaW1WYmNuUHkw?=
 =?utf-8?B?bVo2NzI0VWdQWUJnNCthNU5LampiUko1V2JreENQb1JBMWNKQW1rcm84ZWg1?=
 =?utf-8?Q?70bh1IZ01NU8pM04cywKoTcSm?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c06f30a-ed89-46a0-9222-08dc3c043fae
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 04:33:32.6432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Rf34KZ85aq60n3DVYEqru+pTAT1ODS1fOBfEJFj2B6MiHoHkswC0vPm1zssynXW6pIs8R0AmfjmcE5m85vGkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8234

From: Nicolin Chen <b42378@freescale.com>

Allocate memory from SoC internal SRAM to reduce DDR access and keep DDR in
lower power state (such as self-referesh) longer.

Check iram_pool before sdma_init() so that ccb/context could be allocated
from iram because DDR maybe in self-referesh in lower power audio case
while sdma still running.

Reviewed-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Signed-off-by: Nicolin Chen <b42378@freescale.com>
Signed-off-by: Joy Zou <joy.zou@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/dma/imx-sdma.c | 53 +++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 40 insertions(+), 13 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 9b42f5e96b1e0..9a6d8f1e9ff63 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -24,6 +24,7 @@
 #include <linux/semaphore.h>
 #include <linux/spinlock.h>
 #include <linux/device.h>
+#include <linux/genalloc.h>
 #include <linux/dma-mapping.h>
 #include <linux/firmware.h>
 #include <linux/slab.h>
@@ -516,6 +517,7 @@ struct sdma_engine {
 	void __iomem			*regs;
 	struct sdma_context_data	*context;
 	dma_addr_t			context_phys;
+	dma_addr_t			ccb_phys;
 	struct dma_device		dma_device;
 	struct clk			*clk_ipg;
 	struct clk			*clk_ahb;
@@ -531,6 +533,7 @@ struct sdma_engine {
 	/* clock ratio for AHB:SDMA core. 1:1 is 1, 2:1 is 0*/
 	bool				clk_ratio;
 	bool                            fw_loaded;
+	struct gen_pool			*iram_pool;
 };
 
 static int sdma_config_write(struct dma_chan *chan,
@@ -1358,8 +1361,14 @@ static int sdma_request_channel0(struct sdma_engine *sdma)
 {
 	int ret = -EBUSY;
 
-	sdma->bd0 = dma_alloc_coherent(sdma->dev, PAGE_SIZE, &sdma->bd0_phys,
-				       GFP_NOWAIT);
+	if (sdma->iram_pool)
+		sdma->bd0 = gen_pool_dma_alloc(sdma->iram_pool,
+					sizeof(struct sdma_buffer_descriptor),
+					&sdma->bd0_phys);
+	else
+		sdma->bd0 = dma_alloc_coherent(sdma->dev,
+					sizeof(struct sdma_buffer_descriptor),
+					&sdma->bd0_phys, GFP_NOWAIT);
 	if (!sdma->bd0) {
 		ret = -ENOMEM;
 		goto out;
@@ -1379,10 +1388,14 @@ static int sdma_request_channel0(struct sdma_engine *sdma)
 static int sdma_alloc_bd(struct sdma_desc *desc)
 {
 	u32 bd_size = desc->num_bd * sizeof(struct sdma_buffer_descriptor);
+	struct sdma_engine *sdma = desc->sdmac->sdma;
 	int ret = 0;
 
-	desc->bd = dma_alloc_coherent(desc->sdmac->sdma->dev, bd_size,
-				      &desc->bd_phys, GFP_NOWAIT);
+	if (sdma->iram_pool)
+		desc->bd = gen_pool_dma_alloc(sdma->iram_pool, bd_size, &desc->bd_phys);
+	else
+		desc->bd = dma_alloc_coherent(sdma->dev, bd_size, &desc->bd_phys, GFP_NOWAIT);
+
 	if (!desc->bd) {
 		ret = -ENOMEM;
 		goto out;
@@ -1394,9 +1407,12 @@ static int sdma_alloc_bd(struct sdma_desc *desc)
 static void sdma_free_bd(struct sdma_desc *desc)
 {
 	u32 bd_size = desc->num_bd * sizeof(struct sdma_buffer_descriptor);
+	struct sdma_engine *sdma = desc->sdmac->sdma;
 
-	dma_free_coherent(desc->sdmac->sdma->dev, bd_size, desc->bd,
-			  desc->bd_phys);
+	if (sdma->iram_pool)
+		gen_pool_free(sdma->iram_pool, (unsigned long)desc->bd, bd_size);
+	else
+		dma_free_coherent(desc->sdmac->sdma->dev, bd_size, desc->bd, desc->bd_phys);
 }
 
 static void sdma_desc_free(struct virt_dma_desc *vd)
@@ -2066,8 +2082,8 @@ static int sdma_get_firmware(struct sdma_engine *sdma,
 
 static int sdma_init(struct sdma_engine *sdma)
 {
+	int ccbsize;
 	int i, ret;
-	dma_addr_t ccb_phys;
 
 	ret = clk_enable(sdma->clk_ipg);
 	if (ret)
@@ -2083,10 +2099,15 @@ static int sdma_init(struct sdma_engine *sdma)
 	/* Be sure SDMA has not started yet */
 	writel_relaxed(0, sdma->regs + SDMA_H_C0PTR);
 
-	sdma->channel_control = dma_alloc_coherent(sdma->dev,
-			MAX_DMA_CHANNELS * sizeof(struct sdma_channel_control) +
-			sizeof(struct sdma_context_data),
-			&ccb_phys, GFP_KERNEL);
+	ccbsize = MAX_DMA_CHANNELS * (sizeof(struct sdma_channel_control)
+		  + sizeof(struct sdma_context_data));
+
+	if (sdma->iram_pool)
+		sdma->channel_control = gen_pool_dma_alloc(sdma->iram_pool,
+							   ccbsize, &sdma->ccb_phys);
+	else
+		sdma->channel_control = dma_alloc_coherent(sdma->dev, ccbsize, &sdma->ccb_phys,
+							   GFP_KERNEL);
 
 	if (!sdma->channel_control) {
 		ret = -ENOMEM;
@@ -2095,7 +2116,7 @@ static int sdma_init(struct sdma_engine *sdma)
 
 	sdma->context = (void *)sdma->channel_control +
 		MAX_DMA_CHANNELS * sizeof(struct sdma_channel_control);
-	sdma->context_phys = ccb_phys +
+	sdma->context_phys = sdma->ccb_phys +
 		MAX_DMA_CHANNELS * sizeof(struct sdma_channel_control);
 
 	/* disable all channels */
@@ -2121,7 +2142,7 @@ static int sdma_init(struct sdma_engine *sdma)
 	else
 		writel_relaxed(0, sdma->regs + SDMA_H_CONFIG);
 
-	writel_relaxed(ccb_phys, sdma->regs + SDMA_H_C0PTR);
+	writel_relaxed(sdma->ccb_phys, sdma->regs + SDMA_H_C0PTR);
 
 	/* Initializes channel's priorities */
 	sdma_set_channel_priority(&sdma->channel[0], 7);
@@ -2272,6 +2293,12 @@ static int sdma_probe(struct platform_device *pdev)
 			vchan_init(&sdmac->vc, &sdma->dma_device);
 	}
 
+	if (np) {
+		sdma->iram_pool = of_gen_pool_get(np, "iram", 0);
+		if (sdma->iram_pool)
+			dev_info(&pdev->dev, "alloc bd from iram.\n");
+	}
+
 	ret = sdma_init(sdma);
 	if (ret)
 		goto err_init;

-- 
2.34.1