Received-SPF: pass (google.com: domain of linux-kernel+bounces-90108-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
 Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
 Stephen Boyd <sboyd@kernel.org>,
 Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 Andy Shevchenko <andy.shevchenko@gmail.com>
Subject:
 Re: [PATCH v1 1/1] clk: fractional-divider: Move mask calculations out of
 lock
Date: Mon, 04 Mar 2024 08:05:54 +0100
Message-ID: <2254891.Dhsi8hcfAM@diego>
In-Reply-To: <20240303121410.240761-1-andy.shevchenko@gmail.com>
References: <20240303121410.240761-1-andy.shevchenko@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Am Sonntag, 3. M=E4rz 2024, 13:14:10 CET schrieb Andy Shevchenko:
> There is no need to calculate masks under the lock taken.
> Move them out of it.
>=20
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/clk/clk-fractional-divider.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fract=
ional-divider.c
> index a0178182fc72..da057172cc90 100644
> --- a/drivers/clk/clk-fractional-divider.c
> +++ b/drivers/clk/clk-fractional-divider.c
> @@ -195,14 +195,14 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsig=
ned long rate,
>  		n--;
>  	}
> =20
> +	mmask =3D GENMASK(fd->mwidth - 1, 0) << fd->mshift;
> +	nmask =3D GENMASK(fd->nwidth - 1, 0) << fd->nshift;
> +
>  	if (fd->lock)
>  		spin_lock_irqsave(fd->lock, flags);
>  	else
>  		__acquire(fd->lock);
> =20
> -	mmask =3D GENMASK(fd->mwidth - 1, 0) << fd->mshift;
> -	nmask =3D GENMASK(fd->nwidth - 1, 0) << fd->nshift;
> -
>  	val =3D clk_fd_readl(fd);
>  	val &=3D ~(mmask | nmask);
>  	val |=3D (m << fd->mshift) | (n << fd->nshift);
>=20