Received-SPF: pass (google.com: domain of linux-kernel+bounces-90148-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e2e14cc2-50f9-408b-8b42-cd32eb9f4b5e@intel.com>
Date: Mon, 4 Mar 2024 15:39:33 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 101/130] KVM: TDX: handle ept violation/misconfig exit
Content-Language: en-US
To: <isaku.yamahata@intel.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: <isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
	<erdemaktas@google.com>, Sean Christopherson <seanjc@google.com>, Sagi Shahar
	<sagis@google.com>, Kai Huang <kai.huang@intel.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <f05b978021522d70a259472337e0b53658d47636.1708933498.git.isaku.yamahata@intel.com>
From: Chenyi Qiang <chenyi.qiang@intel.com>
In-Reply-To: <f05b978021522d70a259472337e0b53658d47636.1708933498.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2JzNlRVY0NGWkhUWU5QWDM4V3I5MGs4QVpLckQwaFJWSFRLVVhPZGtpNGR1?=
 =?utf-8?B?ZlZuLzR1ZFlwZkN5Z2dKczNKVFVJVFBFQ3BwdEFXNGg5NWxya2JNcUQwZWZF?=
 =?utf-8?B?MlB1K0grdHlxSUdiT2EycVZWTUZrNDFXNGp3UGxTemFORE8reUxWakdXVm1n?=
 =?utf-8?B?b2kwZTkyY2xSMjRrMmlzWVhvLzlWWXQ2N3VRV1dnL3htcW11NkppUDRiWVVZ?=
 =?utf-8?B?N0FIZU11dzA3RGFuNUtKaVAxbmFCSHNpWExKR2pwOVRsWHJjNlQ2eDhhWEFr?=
 =?utf-8?B?RndDR1huWWo0SzlRcmgvM2tpWlBqWUJFc2tnZEdwUlAvUUZNRXVoS3g4eUcv?=
 =?utf-8?B?emMvMDZRL1doL29XWHNBc2tnWmNCaHRKMkZjakpWdWpqYlhqdU91UHRZNkw0?=
 =?utf-8?B?Y3hqc2FwWFVLWnFrNTRkYlN1aytRVUtsNTdFMEtxa0dlV1FNS2RkbHlzb0JU?=
 =?utf-8?B?U0lZOEE4cUErU1NvZ1p6M0hnSkV1L0g5N2kxRFFoSmZubjlNeDEzbGM2MklM?=
 =?utf-8?B?QVlPbnAwUGk3bTdTdHpyOTlwUmRkRDhvSFY3Q2gvMHVCSVZuQWY0UlJ3enRp?=
 =?utf-8?B?T2ErMnZsa3pkUlNGbXJ1OUxFb2RBdXFmZlQrUndrRk9Gb1JoL0dxejB0UTFF?=
 =?utf-8?B?L2VuTHltQ2VyampTbC8rOXRDUWxBTjBZSjJaNTFNZitOUTdySzBjRXVDdE9k?=
 =?utf-8?B?WWdsZmFwb2RhK2Zkc1dWZXZ2Vmw0MnE0b3pNKzdONVZJdThDT0xHZnpDRlRR?=
 =?utf-8?B?amJDczIzQnpDdHNZV2E4SnRjZHZrY0dOeTRJZDZiS0xBSzdJQ2ZaTXBHbEtD?=
 =?utf-8?B?RWVFR1ljTnhIN1o5Wm1tY3hmbG9aa0liQkZ2QXJvWHFUeTN2OFFRTDVWdmU4?=
 =?utf-8?B?NDdwRDZmU2NlWnNJVDU3MHBTT2VWOHFwQUR4SVJya0xpcS9ac0dBejJkb2Vo?=
 =?utf-8?B?Yi9mMThUUWx0cHZnMm9vYmExZThESGk1eGhYaEcrY3lZNjhuSngyMm1BdnJR?=
 =?utf-8?B?bWVFKzkycDhSWG1pYU5ubnZLQlBBY3pLRkIxZnRLTDBETGx3UysxeWJjeVlw?=
 =?utf-8?B?eFpYbnZJOVErTmZhYU5WZlQyM1R1aHJFeUthZGs2UUR6TGcyMWlSZmdoMGRK?=
 =?utf-8?B?S1hLT1hDb09KNzlwLytUM09EYnd5YUoxL0dLcUtuOUR4NjNpYUd1eHgvaFpU?=
 =?utf-8?B?S09BckRSeUhNMkJxMng5NFdQVVpQa2UyNzVFWWcxNFZtbDlrTVN6USt0czRI?=
 =?utf-8?B?bVRZUmM4ZjIxUGFtaU40UDBWOWdNSU9RTVJEbFgybVpMWVd0bDh6OXhoWU1L?=
 =?utf-8?B?cG1Vb3VPbkNzS0ROdlQ4UzFyR0lDWm5PbFkzcW92eW84QVQ3QzhXSjd2SXhk?=
 =?utf-8?B?OFplaGN1UWJaVy9sTU9RcVlTVzFCSTk5U1ZKVjFxay9CZjlTSGVxbGJkdDdD?=
 =?utf-8?B?TDBCMjk0d2o5RUtPQ2I2WU0yREpYdTNPSGNNVFFGNnJBNGZFeTRqcUNJZFVt?=
 =?utf-8?B?bkE5ZHlLd0h5QkRzdHFac2p6QVZUYVp2TFUxSUxOU2RmM0p1a3lCMmxFbCsy?=
 =?utf-8?B?eTVMMjFURVovV21pNzFBV1FCV0tMRGkwYTFVWDdsM3l1NGUvam5ubXI1N0dC?=
 =?utf-8?B?cVArZkk2S1R2YUxGT2tSYlUrQXRrd2RXVStMbktmWEplVUYydnFVV09uUnpy?=
 =?utf-8?B?c1pXM2VuN3hxQ2VmMnFEWjJ1RDdCTVcza2t0UlN6dEZRY1FzWWlOSUV4bDY0?=
 =?utf-8?B?UXh3VFNVTnRjbVRqZ1d2MVZkTmNDU09Pc21aSHRSUXk3U1NGcXp5R0loczFv?=
 =?utf-8?B?L2tHU1YzcmlpVFNRMU05ak9PaFZzLzVzZkRTbktlcWszenV6eGVFNzlXbWpX?=
 =?utf-8?B?djJ6Q1NuNHovQXJkNEE1YnhMYXl6OFJna0FoTU9JYVBIaDJmbzNRL0h1Sngz?=
 =?utf-8?B?N0hjbVI3Q1lDeWNINm40MW90NWVyejRldlZ3TFp5c3I0OTl6U0NsV2VQZG5B?=
 =?utf-8?B?cUtabHFiMVJDWHdMSGpqVmdaZWtwMmRkekloZW1Sa05FWms0RFdjalJVQUV0?=
 =?utf-8?B?cWs4andsYlhlblhhY3lSdFRJbURTWTFoenRqb1BKUTRqUVMyaFVjZWpVZWVC?=
 =?utf-8?Q?/XAA9o1LidtfM1Cxl8X+i9Xfl?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f5e866ee-6a82-433b-aab6-08dc3c1e4135
X-MS-Exchange-CrossTenant-AuthSource: DM3PR11MB8735.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 07:39:42.3880
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rpHarz6YLzcruLAjRlOVsTQDvu6mlyH0kajA82HHO8JDqsb7Jp4C/r7iP6tHR6XqZgN/GFXxKVmkzi+DbXQLNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8659
X-OriginatorOrg: intel.com


On 2/26/2024 4:26 PM, isaku.yamahata@intel.com wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
> 
> On EPT violation, call a common function, __vmx_handle_ept_violation() to
> trigger x86 MMU code.  On EPT misconfiguration, exit to ring 3 with
> KVM_EXIT_UNKNOWN.  because EPT misconfiguration can't happen as MMIO is
> trigged by TDG.VP.VMCALL. No point to set a misconfiguration value for the

s/trigged/triggered

> fast path.
> 
> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> 
> ---
> v14 -> v15:
> - use PFERR_GUEST_ENC_MASK to tell the fault is private
> 
> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

duplicated SOB

> ---
>  arch/x86/kvm/vmx/common.h |  3 +++
>  arch/x86/kvm/vmx/tdx.c    | 49 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 52 insertions(+)
> 
> diff --git a/arch/x86/kvm/vmx/common.h b/arch/x86/kvm/vmx/common.h
> index 632af7a76d0a..027aa4175d2c 100644
> --- a/arch/x86/kvm/vmx/common.h
> +++ b/arch/x86/kvm/vmx/common.h
> @@ -87,6 +87,9 @@ static inline int __vmx_handle_ept_violation(struct kvm_vcpu *vcpu, gpa_t gpa,
>  	error_code |= (exit_qualification & EPT_VIOLATION_GVA_TRANSLATED) != 0 ?
>  	       PFERR_GUEST_FINAL_MASK : PFERR_GUEST_PAGE_MASK;
>  
> +	if (kvm_is_private_gpa(vcpu->kvm, gpa))
> +		error_code |= PFERR_GUEST_ENC_MASK;
> +
>  	return kvm_mmu_page_fault(vcpu, gpa, error_code, NULL, 0);
>  }
>  
> diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
> index 2f68e6f2b53a..0db80fa020d2 100644
> --- a/arch/x86/kvm/vmx/tdx.c
> +++ b/arch/x86/kvm/vmx/tdx.c
> @@ -1285,6 +1285,51 @@ void tdx_deliver_interrupt(struct kvm_lapic *apic, int delivery_mode,
>  	__vmx_deliver_posted_interrupt(vcpu, &tdx->pi_desc, vector);
>  }
>  
> +static int tdx_handle_ept_violation(struct kvm_vcpu *vcpu)
> +{
> +	unsigned long exit_qual;
> +
> +	if (kvm_is_private_gpa(vcpu->kvm, tdexit_gpa(vcpu))) {
> +		/*
> +		 * Always treat SEPT violations as write faults.  Ignore the
> +		 * EXIT_QUALIFICATION reported by TDX-SEAM for SEPT violations.
> +		 * TD private pages are always RWX in the SEPT tables,
> +		 * i.e. they're always mapped writable.  Just as importantly,
> +		 * treating SEPT violations as write faults is necessary to
> +		 * avoid COW allocations, which will cause TDAUGPAGE failures
> +		 * due to aliasing a single HPA to multiple GPAs.
> +		 */
> +#define TDX_SEPT_VIOLATION_EXIT_QUAL	EPT_VIOLATION_ACC_WRITE
> +		exit_qual = TDX_SEPT_VIOLATION_EXIT_QUAL;
> +	} else {
> +		exit_qual = tdexit_exit_qual(vcpu);
> +		if (exit_qual & EPT_VIOLATION_ACC_INSTR) {
> +			pr_warn("kvm: TDX instr fetch to shared GPA = 0x%lx @ RIP = 0x%lx\n",
> +				tdexit_gpa(vcpu), kvm_rip_read(vcpu));
> +			vcpu->run->exit_reason = KVM_EXIT_EXCEPTION;
> +			vcpu->run->ex.exception = PF_VECTOR;
> +			vcpu->run->ex.error_code = exit_qual;
> +			return 0;
> +		}
> +	}
> +
> +	trace_kvm_page_fault(vcpu, tdexit_gpa(vcpu), exit_qual);
> +	return __vmx_handle_ept_violation(vcpu, tdexit_gpa(vcpu), exit_qual);
> +}
> +
> +static int tdx_handle_ept_misconfig(struct kvm_vcpu *vcpu)
> +{
> +	WARN_ON_ONCE(1);
> +
> +	vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
> +	vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_UNEXPECTED_EXIT_REASON;
> +	vcpu->run->internal.ndata = 2;
> +	vcpu->run->internal.data[0] = EXIT_REASON_EPT_MISCONFIG;
> +	vcpu->run->internal.data[1] = vcpu->arch.last_vmentry_cpu;
> +
> +	return 0;
> +}
> +
>  int tdx_handle_exit(struct kvm_vcpu *vcpu, fastpath_t fastpath)
>  {
>  	union tdx_exit_reason exit_reason = to_tdx(vcpu)->exit_reason;
> @@ -1345,6 +1390,10 @@ int tdx_handle_exit(struct kvm_vcpu *vcpu, fastpath_t fastpath)
>  	WARN_ON_ONCE(fastpath != EXIT_FASTPATH_NONE);
>  
>  	switch (exit_reason.basic) {
> +	case EXIT_REASON_EPT_VIOLATION:
> +		return tdx_handle_ept_violation(vcpu);
> +	case EXIT_REASON_EPT_MISCONFIG:
> +		return tdx_handle_ept_misconfig(vcpu);
>  	case EXIT_REASON_OTHER_SMI:
>  		/*
>  		 * If reach here, it's not a Machine Check System Management