Received-SPF: pass (google.com: domain of linux-kernel+bounces-90188-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <4d09ccba-32f6-453d-a4aa-6c5b127a1721@oracle.com>
Date: Mon, 4 Mar 2024 08:18:09 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes
 group
Content-Language: en-US
To: Igor Pylypiv <ipylypiv@google.com>, Damien Le Moal <dlemoal@kernel.org>,
        Niklas Cassel <cassel@kernel.org>, Jason Yan <yanaijie@huawei.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jack Wang <jinpu.wang@cloud.ionos.com>, Hannes Reinecke <hare@suse.de>,
        Xiang Chen <chenxiang66@hisilicon.com>,
        Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
        Bart Van Assche <bvanassche@acm.org>
Cc: TJ Adams <tadamsjr@google.com>, linux-ide@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240302201636.1228331-1-ipylypiv@google.com>
 <20240302201636.1228331-6-ipylypiv@google.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240302201636.1228331-6-ipylypiv@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NExhRTFMVXh4SHNwM0xQckVscEc5bk8xa01vZVFyNmhlbTFUQjJRTHZzdDFs?=
 =?utf-8?B?cW0vVmoxZHFNS2xFTjMwQTh0VEtobUxTZThqYzFyanFlS1Fsa0tVWVd1bmVX?=
 =?utf-8?B?T2hmUk9zdlRiRnVYRS8reC9YYml4dHBhaXhTanhhWmFmRlhBbnl0MDJGd1c5?=
 =?utf-8?B?RWhKQS9oSFpPSDJNYzZJODlsSE5EZWQrWTh6MEZJQ3dLNjJnR0p0Uyt0eGNo?=
 =?utf-8?B?cEFyZnkzTjJLcUxSYm1pNjI3Q1N1L01nMHVrbE9UeHRKdE16NW44MHpjaEFR?=
 =?utf-8?B?bm10TEF0dGZPRkVkTUxXbVNCTGhsbGsxbktkZTROYUN4TUFscldXTzI0bm4x?=
 =?utf-8?B?cHE5Ny9xdk9BY1dOdTd3anhSUDVPU3hMcG5yN1Ird3ZPeXNleEpTVTh5b211?=
 =?utf-8?B?Y3hLOW9iRHM0ais4VW5WMG5TTkhDRWhOZHF0NG12ZTZWWG1JZlE4YXh4cCtj?=
 =?utf-8?B?Nkx4aWVyWGdWZUhMRDRibjI0anNoeXVYU1hXUlRna0hWbDRuM0FOTVd6TGx1?=
 =?utf-8?B?bnlEVGl3TUZwTCtRQnI3SHdUTThvVlpRczdjL2ZNUjd2bklrRGgyc0dkWUcz?=
 =?utf-8?B?QkRwQUltZFpPMnZ1dnM3Zk9rMUQvNEVOVENuS0JzRGdoUjBkZEFOcUNDcy9V?=
 =?utf-8?B?cFpwRm5JVEh3NVlUR1kydXZ4djNzR3Vzc3ZGZlRYNFlHYkRtandFelRBeEZW?=
 =?utf-8?B?OGRhK2U2RHU5K3hjKzVNYWhqa0VWLzFhUWQyb1dVeFliYVovNi9NQTh3OWR4?=
 =?utf-8?B?bExaTnBHWFduSGNlNU9KQ1BTWjgrdythOW5qYnNVYkxZMlMzbnBlVVE2MnlB?=
 =?utf-8?B?Z2tNQWpXNlZmUnVrMFlEVkg5Rjl4ejkzeWkvN09jd1k4TmhPd3VqeG1zOGJM?=
 =?utf-8?B?U2ZFdFA0TE5BYnBhVnZ2QlFmUUJUZWF1TEUwRFJFamtyTks4WW1LOXl1ckJU?=
 =?utf-8?B?Y0hocTJxSlpVbGpSMGdLc0xETUtMdkY5dVVGM1dnZ1hxWlZwc0NpRHdKb1hh?=
 =?utf-8?B?bW9yalZrMFk2Y0NIMkxRZmROVHhOUlZ1NmE1bXovOW5OSXdVZ2V0Y2ZKNTlQ?=
 =?utf-8?B?UHlPSkRXUGc0aVJsZkhpZWY3OG9kekV0S3IxZkhuL2dnWHFPNi9qblA1Vjl0?=
 =?utf-8?B?ckJmUld5M0JtSVNHZUg2VmVITUwvdVJFenU2Tk9WNFBDQTdoejlHNC9WUmtR?=
 =?utf-8?B?Tk9adHFhc3kxQkxXQ1NJVVhGQjM2Rk1lcW9yZmRRVXM1cFNNUzl5eEg1UXNn?=
 =?utf-8?B?U2xoL0NDR3VzUDlwUzg4NFZJU2hjYkFoRFRSZU4wZVlGdEF1V3N3WlBaUFl1?=
 =?utf-8?B?U3h4MWFlQjQ1bzFYd2MzZ0dBSWFjTHV1NFI1am4yNzZBT2c1OTNsMnA0V3lW?=
 =?utf-8?B?cnNyclI5anJNb1N0RXBWMW5Xc0F2V0FJNzdDTUVXRDhieExldmlDSmJ1TjdZ?=
 =?utf-8?B?M2xMUnFrcnQwYlhxNWxEVTBCR09lTjhZVmEvSEdBajJTMEhvR1orMkV4QTI2?=
 =?utf-8?B?a3p6U0tuZE9BNXdGbHZMVzN4UVpQTTliMzFCSGdFdTY4VXgwRXNwVkdqeDZN?=
 =?utf-8?B?UUVXdW5NUTlJU3hIQ3l1andiL3NSSGZka24zb0tUZnpKL2Z5d20zc1J5eXhj?=
 =?utf-8?B?R2xVa2plRzhFWU1UaVliRzZrMGxVbEx0a2J3VUw0ZW8vdGp6bXUvUnNFdE83?=
 =?utf-8?B?N2U3WXVvWG14OG5FaThRdG4yMUxKVkswSkpud0RRelkyU3VHSzViMHNiYXJs?=
 =?utf-8?B?eEdIa24wZjJ4UjlrTWFUL1NWLzZlK3FLSmZib3FVaER2NDZrQWM2UiszVEZ5?=
 =?utf-8?B?bkNmUFE1ZHB2OXc4TTFQeCtzUTFJSjJQL1E5Z0RnTUVQVG9CbzB4TFFWUmUz?=
 =?utf-8?B?THdSWDVNR0U0SHUrQTB1bGxNRGVLMEQ4cWRzV2p5Sy9DbU9yazVjT1pnS1Rr?=
 =?utf-8?B?VnNKUWxmWm45UkhrUnQxaWhIUUlwb3ZPQzZRYWhMZmovMHlYenhFMURLL09Q?=
 =?utf-8?B?UkhtanNqNXZsNy8wNzJPd3ZKMXFRSEZmV3RSbHJBajJxT1REdTJlYlM2TUg0?=
 =?utf-8?B?SklMZnI3V1dyQ055RGZmOUg1Mk1lTjVCVWZ2MnNvcnpMaVpBSlZTSDRRTlVH?=
 =?utf-8?Q?YwkqwAecKTz/r2p+o0XBx+2LP?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	2HRvbZ7cQB0mlMJrHrlgf4+kMS9uQHJ3QedV8IolAv+nTGTPS+3zCJ3gYNZaXBJBnH1nIND9DYlcYrSkmQlmZ+v3qpBfQONskl2Oxoy01ZkaW416clZ4dmE2WwcShUmm2lxSnLQTvZfak2uQs0wNJxEjXfr6ogb4SRpKgmCvQzrROW7p2YqgpzM183GGOgwgeZt4HaIyjxAdL5mWz0qy5amXvekfQVxPoB9eEflPrKHljfifzsW6bk4JUQSqKxHYGJXgbig5+pj5BhihHYWNckL0oUQMrhO/BMdvSJ8miJCadV96kTULuqCQjQWG1t5nk31DXPHS4qbUE6KIKgNLBagyt4CJf+YBu9/4TT6ggibu60jThI91bYPGVRvyASCfE6rpTLG692Asn9I1i3+YxNB4eRh21PW+fg6jEQUi9djvlZZ5SVWssA4CgIw2MqIDMe5JYanJoOgzqOxOWCsbv0k2jB0/6s4NMsefbge0KgBS/4gYg1hWWl0TI9m140RnMTl54c8kUV7QNC6Qv0iJHc/0VqACFGpka+z7MY2pI/IMB1lUarY2MEK57xOXEjLbw4cccv8Ww8+XPzQXyibZmDi09Yj5qD0YjoQT79OEUsg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0d85551-725c-4476-d219-08dc3c23a165
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 08:18:11.0916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5xXmgoglZ7FDrYo/HiCSA7XBgcW0UdAb1tgwpN/dQu45Gp3CgdjQ3jFUC5VvkmwyuBsQm8ovG9EyvUnmPbDxRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5676
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-04_04,2024-03-01_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0
 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403040062
X-Proofpoint-ORIG-GUID: SamitjNLYaODzSI2ADPunra0ymdBVLHH
X-Proofpoint-GUID: SamitjNLYaODzSI2ADPunra0ymdBVLHH

On 02/03/2024 20:16, Igor Pylypiv wrote:
> The added sysfs attributes group enables the configuration of NCQ Priority
> feature for HBAs that rely on libsas to manage SATA devices.
> 
> Signed-off-by: Igor Pylypiv<ipylypiv@google.com>

Apart from comment on v1 HW:
Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
>   drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 6 ++++++
>   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
>   3 files changed, 18 insertions(+)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> index 3c555579f9a1..97864b56a71f 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> @@ -1734,6 +1734,11 @@ static struct attribute *host_v1_hw_attrs[] = {
>   
>   ATTRIBUTE_GROUPS(host_v1_hw);
>   
> +static const struct attribute_group *sdev_groups_v1_hw[] = {
> +	&sas_ata_sdev_attr_group,

IIRC, this driver never supported SATA

> +	NULL
> +};
> +
>   static const struct scsi_host_template sht_v1_hw = {
>   	.name			= DRV_NAME,
>   	.proc_name		= DRV_NAME,
> @@ -1758,6 +1763,7 @@ static const struct scsi_host_template sht_v1_hw = {
>   	.compat_ioctl		= sas_ioctl,
>   #endif
>   	.shost_groups		= host_v1_hw_groups,
> +	.sdev_groups		= sdev_groups_v1_hw,
>   	.host_reset             = hisi_sas_host_reset,
>   };