Received-SPF: pass (google.com: domain of linux-kernel+bounces-90195-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <910cb9cc-6041-461d-b010-a01e690f42b6@oracle.com>
Date: Mon, 4 Mar 2024 08:22:32 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/7] scsi: libsas: Define NCQ Priority sysfs attributes
 for SATA devices
Content-Language: en-US
To: Igor Pylypiv <ipylypiv@google.com>, Damien Le Moal <dlemoal@kernel.org>,
        Niklas Cassel <cassel@kernel.org>, Jason Yan <yanaijie@huawei.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jack Wang <jinpu.wang@cloud.ionos.com>, Hannes Reinecke <hare@suse.de>,
        Xiang Chen <chenxiang66@hisilicon.com>,
        Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
        Bart Van Assche <bvanassche@acm.org>
Cc: TJ Adams <tadamsjr@google.com>, linux-ide@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240302201636.1228331-1-ipylypiv@google.com>
 <20240302201636.1228331-3-ipylypiv@google.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240302201636.1228331-3-ipylypiv@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QkRXd3o2V01EcWNpSDBxbEtUT3VFRjZWLzZlZ3hlOU9QUEE3L1RlVUJFKzBp?=
 =?utf-8?B?ek1GbEMxdWJvVzdGcDNxbzNMQ2F4K1Vqd1lZa3lkdlFaNm9ja3pZbjBvamJ6?=
 =?utf-8?B?YVUyQjdobm5zUXN5TVE4WTZJM2loc0RDMTZ6UzNsbmV5VDJWNlVOM1FFeHIx?=
 =?utf-8?B?NXJTcjlZa0FpTzNFRUNvSklNdXZTcncrQ2lSNW9lRmZMeEJTU21lMjhGQzlj?=
 =?utf-8?B?UVF6Q3NFbjNVa1JtUWFQNkRxZ05xMjc2dWFFeWFncUFNc2xUaXFjazZTYndM?=
 =?utf-8?B?bkxicDdrMGhiTXo1TDZPdmFXMUlhUlJMY0dBOTIyY3lsNElHeW1oeWR4SElu?=
 =?utf-8?B?SGR5SVlnRjhDT3pZZ1Z3aWRYVjBlV1Bkb09zaVFjY0dRQkZER2ZwRzZhTUls?=
 =?utf-8?B?RnFyeG1Hc0F5M1A5eUhaNDlTZGllTVVLd2NwQ0U2Qy9FNk5yR2c3bWw3ME5q?=
 =?utf-8?B?YnowOFNVaGRBNUdseXFBTmo5Zm55YmVJUkhKOW13KzRLSE9oTEJiR3N3a25Y?=
 =?utf-8?B?VGVYYVpNY0Z0ZXR2ZFh2dDFVcFZyMWxaSU15eGp4M1cxdVlGZWNTWmNta1FN?=
 =?utf-8?B?a2R1a3ZYRE1POUM2QVdvZ3FzYUNnVlM4allyTFdRaDMwNWFPWmkxRDZBZUNW?=
 =?utf-8?B?TXlTdFVXMUlPVDYyNyt6TjRhU3pWY3A0MFMvZng2UmV1aWhiWnd0SkZXbm4x?=
 =?utf-8?B?OWZyUDNSMVE1azF0bFFwVkYyQVhzS3RvRzZJZk0zaldXOHJKaEtFWkMxaWc4?=
 =?utf-8?B?RXlERnoxWjVwdTBlRnJpOHdhSlQwZW41UzNkY2pGcThJbklVbURka2JBcUZr?=
 =?utf-8?B?Y0ZrbVpGVVcvMFZzVkFLbk1MZHdCZE55UEh6aXZaeUNsUU1oS0VtUjdndTRo?=
 =?utf-8?B?YmM1dS9TVVpvTXhDTy9tT1pFZGw2NXRmNHFuUzBmNXdQMmttQXFjY0ttK2Uz?=
 =?utf-8?B?TGZYeVdxWGNDeE5KNzU3THM4cFhGRzRFcSsySENleTdRQVRLSHdEWUR0cWJn?=
 =?utf-8?B?VTFOYnVUTWFSUjlvWkh6QTQ2OGFVdjYvNXVOdjl2eGtKOTAvR2Q4czkrbkMy?=
 =?utf-8?B?b0dmeDlrT1lpeW9zTlNKcTJTd2FvZ3ZvZ2JueDNaSXJRUi9NcTJLcmpvZVp4?=
 =?utf-8?B?OE5FdFlrSThWSTR4VzVVTHdNSUs1VmQ2clhvRWR2N25DSUlkcWl6ckc0dlh1?=
 =?utf-8?B?OVBQdEh4OHVIOTFVVlExWGxlUHdTRUpyS1VDWVpiSDloVmgwVHRpRyt5VWJF?=
 =?utf-8?B?ZUdLVDZ0L0swcVlMUjMrbnRNdkhaeW9RVVFad0RBMXRsTGFHMnpWQnBXdi9D?=
 =?utf-8?B?bGhHN1E1eVNIWXhzNFpaZVlzbmwwSCtxM0F3RmRWeFAwMW9CTDV3bHFraEFT?=
 =?utf-8?B?RUUvdW41dXJuaC9URzEzS3FKUlViTkM3OGU2S0Rwd0dORWNzY0JFM0Z4NGYr?=
 =?utf-8?B?STROMFNxR25oTkFCc1lSdHBOa2JHTWlCSFVQVnZ4NjVJSzFuZlZJZWw2L2tC?=
 =?utf-8?B?UWt6M3FKMjNPdDRvb0VFb3ZxNVBtOVpFOVFjR0Nrd3V0OUg3c1V3ZUVvdDRh?=
 =?utf-8?B?Sy8zcThkL0FTM3A2SFBxSGg0MUdNTjBYdjVRY3hCeUZvMVRFdExsaFg1SEFG?=
 =?utf-8?B?WkxYUEFkOUZCenpUZG1jYWJ3NFZObmpPWFR3TmZpZHliTTZ6TFJlYk1VQVo4?=
 =?utf-8?B?ai9EU3AwaE5RaENvNDJEUUIxR3JmaXdlcFVMdWNHNGJKYzdydkQ3eS81cTl1?=
 =?utf-8?B?NE9GQzNaTFVzZDRvZjVDTHhzQ0VUQ3h4cjd6bE9ObmR4QVJwODdxbTI5UzNw?=
 =?utf-8?B?dXhUaTZDN1crSkUvdnc5d3JxWVM0N1kvVHdWUUVmL29LeGVuSEFtR1ZwN3Qw?=
 =?utf-8?B?ellUbDhHMGNyM1Q0S3VjbXVxRVl0amtVaUZ0NUpNWlpGZjRtSnZOdWRaZ3BF?=
 =?utf-8?B?VG90Ui9zTHpsOXMvODNFU0g5QTRjNVlpV3JYNU9NNDhVRWV6YWVrME1nYmRm?=
 =?utf-8?B?SUN5c255NVZodXJvT282SWRmZ3lnSXFSMXdUdlB6WUhmcUpHTXMrdVV3NDA1?=
 =?utf-8?B?Y25vNmYxRnhmUmpGZDdzTitoMWpuMFBUYlo1akd6YVBqSm1SV2Jqbzd2eHJ2?=
 =?utf-8?B?cWZydGMwa0RkZVBHVXdYR1h0cXQ5S1g4cklkck1jNWkyb0FtWmtHclUvRGdB?=
 =?utf-8?B?YUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ruT5cbqlXtwtQehH9eV/A41jFXAvFwHQdh2GxaqxgaQz0DRvIuBCBxw19w2vlqX3M1XrXfsqwPn+kryZSJFiSlhyeZFBm5HgNBOt6tMx8RazK3fALLQ4R64XzDpA1FKJPiPWF/I/OiZHrgb1wwkhFt9sRugBESwW4SwySd2WbnHQDLBhY3/dPxA7ycUE4z8V0uudh7gBknbBD2QZc266VPmF/IWd/tMBjnfYOG4IDJ+Yd3HPbhzHJWtseLlLBGV9mSeBIi5ZF85VAFfHMHEISk/UvVryxahx3Qsi1Ps0vq50oVIYZ1HtTZyj2c9Q7fWmd9VIkrfGLZ4sYrtA3tnOXnNdz1DRCmqIK9hMt/bf+MFohIrShmthTUwIA0ifiKw1d99xWBMj1TgF9UTA/ity/AFCjdK7feAYktuT9t9FTrYnE/yubDKTtz46b71uZcQv1c/GJKj2K88brkjRTflPpfJcuPh611XfTbmYbmHPwcWeTvv6lLrq2MsQ+KoQgXu3y7rhZMfcYlUqEV62YXlkytGgF9G0jwAcPf7gMpX8GcBqvO25gZiZWpIXMtL5uKVF1KPFIcFMvCm3JeNRPIYHSQwxBa+0tWkSkBBiaHh5NZY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab7e8bc7-0485-4091-569d-08dc3c243fe6
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 08:22:37.0370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cM0owcT8u55z5J60ManaO4PGGQBcdUSa7AxFxuLeLkjZxSpfl8xPMsbL7r4i1DbaPdlhai0B8Bz5FmRSL7Gyhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7206
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-04_04,2024-03-01_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403040062
X-Proofpoint-ORIG-GUID: JZmhUHxodMsg3-lgpCAzVyiaKPma0SPL
X-Proofpoint-GUID: JZmhUHxodMsg3-lgpCAzVyiaKPma0SPL

On 02/03/2024 20:16, Igor Pylypiv wrote:
> Libata sysfs attributes cannot be used for libsas managed SATA devices
> because the ata_port location is different for libsas.
> 
> Defined sysfs attributes (visible for SATA devices only):
> - /sys/block/sda/device/ncq_prio_enable
> - /sys/block/sda/device/ncq_prio_supported
> 
> The newly defined attributes will pass the correct ata_port to libata
> helper functions.
> 
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>

This looks ok:

Reviewed-by: John Garry <john.g.garry@oracle.com>