Received-SPF: pass (google.com: domain of linux-kernel+bounces-90201-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <5e5c0a81-3c60-437c-b164-e1245222d964@linux.ibm.com>
Date: Mon, 4 Mar 2024 13:58:16 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/2] sched/fair: Use helper function to access
 rd->overutilized
Content-Language: en-US
To: Qais Yousef <qyousef@layalina.io>
Cc: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org,
        yu.c.chen@intel.com, dietmar.eggemann@arm.com,
        linux-kernel@vger.kernel.org, nysal@linux.ibm.com,
        aboorvad@linux.ibm.com, srikar@linux.ibm.com, vschneid@redhat.com,
        pierre.gondois@arm.com, morten.rasmussen@arm.com
References: <20240301151725.874604-1-sshegde@linux.ibm.com>
 <20240301151725.874604-3-sshegde@linux.ibm.com>
 <20240303185441.km7c4u7yui3b5nl2@airbuntu>
From: Shrikanth Hegde <sshegde@linux.ibm.com>
In-Reply-To: <20240303185441.km7c4u7yui3b5nl2@airbuntu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/4/24 12:24 AM, Qais Yousef wrote:
> On 03/01/24 20:47, Shrikanth Hegde wrote:
>> Overutilized field is accessed directly in multiple places.
>> So it could use a helper function. That way one might be more
>> informed that it needs to be used only in case of EAS.
>>
>> No change in functionality intended.
>>
>> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> 
> Can we do the same for rd->overload too? A set_rd_overload_status() would be
> a nice addition too. Anyway.


We have some more experiments going around overload. 
For example, currently it is writing sg_status & SG_OVERLOAD without checking if it has 
changed first. On large systems that are not overloaded, that may help by reducing the 
bus traffic. 

I will pick up this after we have some more data on the above. 

> 
> Reviewed-by: Qais Yousef <qyousef@layalina.io>
> 

Thank you.

> 
> Thanks!