Received-SPF: pass (google.com: domain of linux-kernel+bounces-90205-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240304034632.GA21357@didi-ThinkCentre-M920t-N000> <CANn89iJ0yBH3HskjzFUANeTxso5PpihxZcQ4VudzmfsKC-8kDw@mail.gmail.com>
In-Reply-To: <CANn89iJ0yBH3HskjzFUANeTxso5PpihxZcQ4VudzmfsKC-8kDw@mail.gmail.com>
From: yuanli fu <fuyuanli0722@gmail.com>
Date: Mon, 4 Mar 2024 16:30:16 +0800
Message-ID: <CABbqxmc43sfNz0c=CLbYFtHy6zdMMJuKWLbCm3n1OMYE6fxjwg@mail.gmail.com>
Subject: Re: [PATCH net-next v2] tcp: Add skb addr and sock addr to arguments
 of tracepoint tcp_probe.
To: Eric Dumazet <edumazet@google.com>
Cc: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-trace-kernel@vger.kernel.org, fuyuanli@didiglobal.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Eric Dumazet <edumazet@google.com> =E4=BA=8E2024=E5=B9=B43=E6=9C=884=E6=97=
=A5=E5=91=A8=E4=B8=80 16:13=E5=86=99=E9=81=93=EF=BC=9A
>
> On Mon, Mar 4, 2024 at 4:46=E2=80=AFAM fuyuanli <fuyuanli@didiglobal.com>=
 wrote:
> >
> > It is useful to expose skb addr and sock addr to user in tracepoint
> > tcp_probe, so that we can get more information while monitoring
> > receiving of tcp data, by ebpf or other ways.
> >
> > For example, we need to identify a packet by seq and end_seq when
> > calculate transmit latency between lay 2 and lay 4 by ebpf, but which i=
s
>
> Please use "layer 2 and layer 4".
>
> > not available in tcp_probe, so we can only use kprobe hooking
> > tcp_rcv_esatblised to get them. But we can use tcp_probe directly if sk=
b
> > addr and sock addr are available, which is more efficient.
>
> Okay, but please fix the typo. Correct function name is tcp_rcv_establish=
ed
>
> >
> > Signed-off-by: fuyuanli <fuyuanli@didiglobal.com>
> > Link: https://lore.kernel.org/netdev/20240229052813.GA23899@didi-ThinkC=
entre-M920t-N000/
> >
>
OK, I will submit a v3 patch, thanks for your review :)
fuyuanli