Received-SPF: pass (google.com: domain of linux-kernel+bounces-90212-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 4 Mar 2024 16:30:31 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
CC: lkp <lkp@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "oe-kbuild-all@lists.linux.dev"
	<oe-kbuild-all@lists.linux.dev>
Subject: Re: drivers/opp/debugfs.c:48:54: warning: '%d' directive output may
 be truncated writing between 1 and 11 bytes into a region of size 8
Message-ID: <ZeWGpyXXZBeYjnGW@yujie-X299>
References: <202402141313.81ltVF5g-lkp@intel.com>
 <20240214055836.c5i3zmkhdllldwon@vireshk-i7>
 <b41c6cdb78c96d5f4a909fc13c253ef0d8576c86.camel@intel.com>
 <20240304065411.w34vbaeg2rlq6z5k@vireshk-i7>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240304065411.w34vbaeg2rlq6z5k@vireshk-i7>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?G4Yj6emP1uti8wkDYZRphT8ZQ/vVlA5jcp3ht70UJNMCbgpnbhw2kiq5Fs?=
 =?iso-8859-1?Q?SLto1Q3TcdFjdg08YfMqwbLj4+7uR+vM+q24SnLrAXXmUJfe/WOh5S+iz5?=
 =?iso-8859-1?Q?kL1Yx2SGS0sKpN2KYkGqFCGczOahzkxA+lyVibHcZtC6i3lLWGd06aHptt?=
 =?iso-8859-1?Q?HYGNepgK8RtWDbAsYnLOVrPO1uhljQAU1rTTsCB242kTysm3puPV+nlbrW?=
 =?iso-8859-1?Q?WxWVzQEQQqsiNNJzj1j8HZ9dCvDbtDYKlRFA3g4a78uJi7Psgmv7Dngb/S?=
 =?iso-8859-1?Q?Ylt8q/qUQ124cSrxHDzBpvJQog86UWNpLOn62ODXM64WUZ3cRrXr2H6p9E?=
 =?iso-8859-1?Q?Pcu4vsucJL3V+HaS4T3xwlXcI8+X0Gg38G78NYkQTeYeURydfUFKF8IYRM?=
 =?iso-8859-1?Q?HkCRvEMFOxubza/hH81KLeKz5EcS2Pq667Y/vFWmEWnTgSSG9PDEFVI4Kv?=
 =?iso-8859-1?Q?qDJtYGOsndDjZ9MjVliG7IoWadHfuAHsAgGOTX2DC1s6fIZBW2p3TFmK2d?=
 =?iso-8859-1?Q?QbKFJy9Q0oWmNgnthpKGOr4QX9OLPKgZGk9cOBYEoU3IpTzme/IK1A8k8z?=
 =?iso-8859-1?Q?8OihNIPqt/omkDinOSQSBZB6Z+J1IEKgk5OL/F7GYBxwqs93S4bsV3YbDp?=
 =?iso-8859-1?Q?Jxiaa17LrgjbuIZsMZo2VKjgLSLf6+73jVS9DLcxXl0wHEegZ9+n3IXBs0?=
 =?iso-8859-1?Q?GecPElAkXmautxtMtuzcaaUtqJyEHClpWHHw/SFSPqYssgJF4miXMRVuZK?=
 =?iso-8859-1?Q?5JjX/dB21aevfJ7YQoizE2UuV+eZL73IfTCC0tB55AX+qhP67w1f+AMkG5?=
 =?iso-8859-1?Q?8uRbO5hSQ/uPQAyBji7NknSXkcDO3GiAOR4RB7a9iXGip6eDpEOEia6IEa?=
 =?iso-8859-1?Q?RwNLjKpWs+ZcBuhd3UPOY/vuMXfdzvFd/DwPoyECFGlVbUXztPwCEFkjAv?=
 =?iso-8859-1?Q?BYcwrXJJxTYFo6tnZqn9wlauFAduA+vRiJcj2rhq7Usz+/D91+n1Rf7iL/?=
 =?iso-8859-1?Q?P7sv5Rbps+YjHG0+ruIh73Nx82PPuuu8GS5iXQxUxG4GIp04kBIZjffh7B?=
 =?iso-8859-1?Q?LEmNV8i0ngkaj3LBQfYCijYs8gHadIi9UzARZGnvxb31f4yXTFJnwHXu6b?=
 =?iso-8859-1?Q?Q2d0T/O2iYqkHrPB6VHRK1adO5YpDppuOEIO2kJ7iXP6xg3UloGGOsI17O?=
 =?iso-8859-1?Q?Do9bz9wqJ8hoZyyS9eTIU6qgoaLxpUPQ0rG4hD+AZU+112LFBy/Z73x5fr?=
 =?iso-8859-1?Q?qg/rUKjh4SreURiSDGv3KfC6ADNNysY1Eis89ui+R2+YHEUq289lgeWunW?=
 =?iso-8859-1?Q?fn7uMsufyj1lv6sTem4lxBvsQxY1Ms0OejMiC9oi3oQVwM6cbBYkoZbS5F?=
 =?iso-8859-1?Q?v8q38iW/GYUWaY8IjsobT7f46Wr5pIVeu/wisJqqMsaDRlXvInk0ikyyLc?=
 =?iso-8859-1?Q?25mBcmJXDxebJ6rB5AATlWuDwnlC/Fdu+Tajh1+eDGs524fFfG6Xffsjri?=
 =?iso-8859-1?Q?UnmAgsmm7fo/rOkHN/527XwusIws/Ha2hh0wXE+l/XKqOQ7FwKjJj5UEyG?=
 =?iso-8859-1?Q?PlTtvheCmGIWexbjlusAnqxlOxXB+3cuZK/e37pIhF+f37aPKndkrExOzA?=
 =?iso-8859-1?Q?SY8kkW13vnN6U1iI5L2C3j7lk7NokV/k8w?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ed163f1f-f641-4899-638a-08dc3c264e43
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 08:37:20.2667
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WQ7ZpyRsG26E2baADjuo6Km0HRB4dRGAFkbPw7KoEgzLM8eWivxVmTdJS0WoKvnhLN5u2JrQHSz2ip2q6ACVpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6003
X-OriginatorOrg: intel.com

On Mon, Mar 04, 2024 at 12:24:11PM +0530, Viresh Kumar wrote:
> On 21-02-24, 06:01, Liu, Yujie wrote:
> > Hi Viresh,
> > 
> > On Wed, 2024-02-14 at 11:28 +0530, Viresh Kumar wrote:
> > > On 14-02-24, 13:43, kernel test robot wrote:
> > > > Hi Viresh,
> > > > 
> > > > FYI, the error/warning still remains.
> > > > 
> > > > tree:?? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git?master
> > > > head:?? 7e90b5c295ec1e47c8ad865429f046970c549a66
> > > > commit: 46f48aca2e5aef3f430e95d1a5fb68227ec8ec85 OPP: Fix missing debugfs supply directory for OPPs
> > > > date:?? 5 years ago
> > > > config: x86_64-buildonly-randconfig-001-20231012 (https://download.01.org/0day-ci/archive/20240214/202402141313.81ltVF5g-lkp@intel.com/config)
> > > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240214/202402141313.81ltVF5g-lkp@intel.com/reproduce)
> > > > 
> > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > > the same patch/commit), kindly add following tags
> > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > > Closes: https://lore.kernel.org/oe-kbuild-all/202402141313.81ltVF5g-lkp@intel.com/
> > > 
> > > I have informed this earlier too, this report is incorrect and applies
> > > to a very old commit.
> > 
> > Really sorry for not responding timely to the questions in the
> > following reports:
> > 
> > [1] https://lore.kernel.org/all/202311061847.BOtfUmbQ-lkp@intel.com/
> > [2] https://lore.kernel.org/all/202312170608.s9xI4TQb-lkp@intel.com/
> > 
> > We see that this still happens on the latest mainline rc regardless of
> > x86_64 or arm64 arch. Please note that this is a "W=1" warning. In our
> > tests, it can be reproduced with gcc-12 and gcc-13, but not with other
> > versions of gcc.
> 
> Okay, I have a different version of gcc. Can you see if this change fixes it or
> not ?

This fixes the warning for "supply-%d". Seems there are other remaining
warnings as shown below. Would you like to take a look as well?

  CC      drivers/opp/debugfs.o
drivers/opp/debugfs.c: In function 'bw_name_read':
drivers/opp/debugfs.c:43:42: error: '%.62s' directive argument is null [-Werror=format-overflow=]
   43 |         i = scnprintf(buf, sizeof(buf), "%.62s\n", icc_get_name(path));
      |                                          ^~~~~
drivers/opp/debugfs.c: In function 'opp_debug_create_one':
drivers/opp/debugfs.c:90:55: error: '%d' directive output may be truncated writing between 1 and 11 bytes into a region of size 4 [-Werror=format-truncation=]
   90 |                 snprintf(name, sizeof(name), "rate_hz_%d", i);
      |                                                       ^~
In function 'opp_debug_create_clks',
    inlined from 'opp_debug_create_one' at drivers/opp/debugfs.c:162:2:
drivers/opp/debugfs.c:90:46: note: directive argument in the range [-2147483644, 2147483646]
   90 |                 snprintf(name, sizeof(name), "rate_hz_%d", i);
      |                                              ^~~~~~~~~~~~
drivers/opp/debugfs.c:90:17: note: 'snprintf' output between 10 and 20 bytes into a destination of size 12
   90 |                 snprintf(name, sizeof(name), "rate_hz_%d", i);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Best Regards,
Yujie

> 
> diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c
> index ec030b19164a..986c08e18d05 100644
> --- a/drivers/opp/debugfs.c
> +++ b/drivers/opp/debugfs.c
> @@ -100,7 +100,7 @@ static void opp_debug_create_supplies(struct dev_pm_opp *opp,
>         int i;
> 
>         for (i = 0; i < opp_table->regulator_count; i++) {
> -               char name[15];
> +               char name[19];
> 
>                 snprintf(name, sizeof(name), "supply-%d", i);
> 
> -- 
> viresh