Received-SPF: pass (google.com: domain of linux-kernel+bounces-90247-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 4 Mar 2024 09:48:24 +0100
From: Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: Arun Ramadoss - I17769 <Arun.Ramadoss@microchip.com>, "andrew@lunn.ch"
	<andrew@lunn.ch>, "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"hkallweit1@gmail.com" <hkallweit1@gmail.com>, "wojciech.drewek@intel.com"
	<wojciech.drewek@intel.com>, "davem@davemloft.net" <davem@davemloft.net>,
	"pabeni@redhat.com" <pabeni@redhat.com>, "edumazet@google.com"
	<edumazet@google.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, UNGLinuxDriver
	<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v2 2/2] net: phy: micrel: lan8814 cable
 improvement errata
Message-ID: <20240304084824.y42djaciaeq5gqz3@DEN-DL-M31836.microchip.com>
References: <20240229195220.2673049-1-horatiu.vultur@microchip.com>
 <20240229195220.2673049-3-horatiu.vultur@microchip.com>
 <80bea3ec2ec86d2e75002f849da174f50e0b846b.camel@microchip.com>
 <20240301072757.t36qqf47erk4jygr@DEN-DL-M31836.microchip.com>
 <20240302194041.5d8f8fad@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20240302194041.5d8f8fad@kernel.org>

The 03/02/2024 19:40, Jakub Kicinski wrote:
> 
> On Fri, 1 Mar 2024 08:27:57 +0100 Horatiu Vultur - M31836 wrote:
> > > > +#define LAN8814_PD_CONTROLS                      0x9d
> > > > +#define LAN8814_PD_CONTROLS_PD_MEAS_TIME_MASK_   GENMASK(3, 0)
> > > > +#define LAN8814_PD_CONTROLS_PD_MEAS_TIME_VAL_    0xb
> > >
> > > nitpick: TIME_VAL macro is very generic if it can end with specific
> > > like TIME_VAL_100M or something similar will gives more readability.
> >
> > Actually I prefer to keep it like this the name if it is possible..
> > Because the VAL_ represents the value and MASK_ represents the mask
> > value. Therefore the actual bits name of the register is
> > LAN8814_PD_CONTROLS_PD_MEAS_TIME.
> >
> > I am trying to have a naming convetion about how to define names in this
> > file:
> > <TARGET>_<REG_NAME>_<REG_BITS_NAME>
> 
> Why the trailing underscores, tho?

That is not really needed. I will update this in the next version.

> 

-- 
/Horatiu