Received-SPF: pass (google.com: domain of linux-kernel+bounces-90322-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 4 Mar 2024 10:25:38 +0100
From: Wolfram Sang <wsa@kernel.org>
To: =?utf-8?B?VGjDqW8=?= Lebrun <theo.lebrun@bootlin.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org,
	Gregory Clement <gregory.clement@bootlin.com>,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH v2 08/11] i2c: nomadik: fetch i2c-transfer-timeout-us
 property from devicetree
Message-ID: <ZeWTklsK36jSzZWW@ninjato>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
	=?utf-8?B?VGjDqW8=?= Lebrun <theo.lebrun@bootlin.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org,
	Gregory Clement <gregory.clement@bootlin.com>,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tawfik Bayouk <tawfik.bayouk@mobileye.com>
References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com>
 <20240229-mbly-i2c-v2-8-b32ed18c098c@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="rOTSJM5aE4jTNjnX"
Content-Disposition: inline
In-Reply-To: <20240229-mbly-i2c-v2-8-b32ed18c098c@bootlin.com>


--rOTSJM5aE4jTNjnX
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 29, 2024 at 07:10:56PM +0100, Th=C3=A9o Lebrun wrote:
> Allow overriding the default timeout value (200ms) from devicetree,
> using the generic i2c-transfer-timeout-us property.
>=20
> The i2c_adapter->timeout field is an unaccurate jiffies amount;
> i2c-nomadik uses hrtimers for timeouts below one jiffy.
>=20
> Signed-off-by: Th=C3=A9o Lebrun <theo.lebrun@bootlin.com>

I agree to get the DT property here in the driver. We may later refactor
it to handle it in the I2C core. Syncing this new property with the
existing 'adapter->timeout' will be a tad annoying, though. But I guess
the shorter timeouts are a desired feature these days...

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


--rOTSJM5aE4jTNjnX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXlk5IACgkQFA3kzBSg
KbaRSxAAmSt/pzGp5XIF3h7uIsHzvGvEGXZg6PHnvH2DulayTo3u3cBgnGDud+ZP
jHg/FqfwO2Lb6818/uloRuAuoi61YmlxoBRKLwJHUbz2TBGjI5rRIpVLRq8/BVg5
95uVU1/MetVec/Kyrtq8S3DpQhbD8BrzAQrui7RW/VBrr+jIUH9wOevEPWGG439V
35a7yjmQGqV7b4sWgZ3iaqhq7bya6VvCs9UMP7y+N1PVgSfRKrxlR3lIFAxujREV
Ed4yYySDk7A0Hd+KJ/xyUnAJAuzmo8K1cqishU+4oFzvBUJMmgHhXTzDNw2TJtRR
lzXhg/Pc9Uu5ay4qN1Tec7c9+VU/AUyw82UW3/rR64ubxc8x+PCfvxX2lCZNq+gL
uCIydfzj+BoRJyGEipx62qxBzIDZUFYr46v8Xc+xxM6/QRxMtyK4tyHqjGRlHHBx
8GQNCeiYVSgGI64k+bTsWzcPnBDMJpo+ZI1GiSninEZuf3GDhuLNCfg+jhmz+FzK
u2U05gyiV7D8PJuAOEadGOgpwOw1cyj84TEACKcch7yH1zwDO3kQmq2eaBV3NHpk
hdGIOWuIImVEmb0CkAHRDq4xcA4ydluQvcrW8RNSBt1U1pD/n2ka//Xri+gIYVp/
3UnUDoe1Zmz0x6h9xurqZ+ys2PplW047yo16PZ98qJsrtZB5jd4=
=mCbo
-----END PGP SIGNATURE-----

--rOTSJM5aE4jTNjnX--