Received-SPF: pass (google.com: domain of linux-kernel+bounces-90320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Mon, 4 Mar 2024 10:24:52 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Valentin Schneider <vschneid@redhat.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] sched/balancing: Switch the
 'DEFINE_SPINLOCK(balancing)' spinlock into an 'atomic_t
 sched_balance_running' flag
Message-ID: <ZeWTZMnX8uLwzjui@gmail.com>
References: <20240301110951.3707367-1-mingo@kernel.org>
 <20240301110951.3707367-2-mingo@kernel.org>
 <703aad5f-40ce-4b37-bd5d-4a85615085e4@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <703aad5f-40ce-4b37-bd5d-4a85615085e4@linux.ibm.com>


* Shrikanth Hegde <sshegde@linux.ibm.com> wrote:

> 
> 
> On 3/1/24 4:39 PM, Ingo Molnar wrote:
> > The 'balancing' spinlock added in:
> 
> Hi Ingo. 
> 
> > 
> >   08c183f31bdb ("[PATCH] sched: add option to serialize load balancing")
> >
> 
>  
> [...]
> 
> >  
> >  		need_serialize = sd->flags & SD_SERIALIZE;
> >  		if (need_serialize) {
> > -			if (!spin_trylock(&balancing))
> > +			if (atomic_cmpxchg_acquire(&sched_balance_running, 0, 1))
> 
> Thinking from very little I know, I may be completely wrong. 
> 
> Is it possible that arch_spin_trylock, which would be called from spin_trylock is 
> faster in some architectures? Maybe in contended case? 

This code path should never really be 'contended': SD_SERIALIZE is only set 
for the outermost, largest domains (NUMA and up) that get balanced 
infrequently. This change is more for the sake of readability: a flag 
disguised as a spinlock.

Thanks,

	Ingo