Received-SPF: pass (google.com: domain of linux-kernel+bounces-90326-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 4 Mar 2024 10:26:36 +0100
From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] kconfig: link menus to a symbol
Message-ID: <ZeWTzJK8rX35tRnJ@fjasle.eu>
References: <20240303040035.3450914-1-masahiroy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240303040035.3450914-1-masahiroy@kernel.org>
Feedback-ID: 1174286m:1174286a9YXZ7r:1174286syjhgZ2FMH

On Sun, Mar 03, 2024 at 01:00:33PM +0900 Masahiro Yamada wrote:
> Currently, there is no direct link from (struct symbol *) to
> (struct menu *).
> 
> It is still possible to access associated menus through the P_SYMBOL
> property, because property::menu is the relevant menu entry, but it
> results in complex code, as seen in get_symbol_str().
> 
> Use a linked list for simpler traversal of relevant menus.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  scripts/kconfig/expr.h   | 5 +++++
>  scripts/kconfig/menu.c   | 4 +++-
>  scripts/kconfig/symbol.c | 4 ++++
>  3 files changed, 12 insertions(+), 1 deletion(-)

Thanks, the whole series looks good to me.

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>