Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1723209lqg; Mon, 4 Mar 2024 01:31:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVizTNSORmxfOf2VTHi0PyLWqQACG8ZpdMm9HVLDvIsm7NSgKMwhS8oDSfhj5m8ysSfG20YpTAV4k5N1AWMNMKQMt9L+laskHozMCHqZw== X-Google-Smtp-Source: AGHT+IFIq88jbbVPbAk1RS2CxmYKUv2Cs8mrzoVc3YxSBBrdCFhsVZ1iV1bgDVdpTxeHQNTlCcgQ X-Received: by 2002:a17:906:6c95:b0:a45:7a55:8426 with SMTP id s21-20020a1709066c9500b00a457a558426mr340923ejr.16.1709544666603; Mon, 04 Mar 2024 01:31:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709544666; cv=pass; d=google.com; s=arc-20160816; b=oHJtaJtsBDwuRjCgg+EWoZCwzCStS7AjDL54hQFZq2+ynUKkyQ4vk9T+fewLIHN2x2 6RIWCbjNSjcqlHMjm2mYEB1DrR4Zy98szf4csQJuoJFSATCckbJq4D5/QHsVkSbpDE91 fY9haSABl+264Wt50EkOad1rN4N2nTJuEafBBJ9PeCEDzstxEcLBXhEuDtLboMe/B+Lk BOG243roygjy9R9ZcseR8xQdYv5WYUw9fUD49M4TleQlxpveGPzimban9KvFyqQ7maEq bT7a6iYKRwaNG/oX1OHVYLrjszUfEcVgyl0TIrzpLBLxBtiPe569jUFBO6Yp5jjJLf2Z 9tMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=3ZtUP/baM4wlGAbfzQSdyF95L2kM2tRoRNkgP7mjkqE=; fh=WFBbuB0+4EoISoNLKdVxh9iPtkL4XbOGRzOjhABSLNU=; b=j9eujLg90OcGVUQM6y4zF5PilcsRKSoQcIW1H2qI0nMu5XlNt1qzk3+I/jsMo+Hsoh ZOUEuiWrUPjjgfVDJE8+zwXyjw+rzj1X5HLY6YXjG5Tjy90sAT45+2WaCIgkv5Uzpc8o 46Z/r6za0xrf+xfAwIlUGZvSwXhdgWdqQ1cprAZa7n8W+HPq3aqUBuhWDwepUsc5R7sU 04SGPh/Q49+UfvPE9y3tbubmvpK6zF82IBxj6Y0qlKbYkzPia0icghwuVwa039j+1Gvt LZfZlmq6GmxxEKBwHM0+4Om3cwCTvYsqJEOBZLjp++EmbI8WXYMm2z4Z+CuHPFwaExmI ozUQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S+xvoZF2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-90329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90329-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id w8-20020a170906184800b00a457907b21esi144933eje.339.2024.03.04.01.31.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 01:31:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S+xvoZF2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-90329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90329-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 597B81F20F90 for ; Mon, 4 Mar 2024 09:31:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1FDC3A269; Mon, 4 Mar 2024 09:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S+xvoZF2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7DE822099; Mon, 4 Mar 2024 09:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709544474; cv=none; b=YHwJ4pOdtG80LOsTBxbDaG4Ij0yEw8ZaaVF82uFhuT0aruhSYzLG5HD4itHZqyzuu5sSbvjkr5mSsMdkWJQ+1objXYvJ/yANIAHO6IWFHojrsWF6ZOn4fPKVCYcyITXOFLulNth3LEH/9y2g+lLXMM7CPf5DaWQgmxQ7UfjQJUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709544474; c=relaxed/simple; bh=jMsyGLHvO8uB8zv0yGRDRKH0t8IOUmfWepSdtjUOZTE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XV9RwBows4GKzNrOj08j5PyVv8rEtKhgdw/x1HwAsYU1bdReSxUa40hmFKJDEJGJBdVFmGeIuBwTMBZsDJYdGaUn5bRSJcywGyLGq4a6xDUCT90krQAzTW7+XNIoYtUsvjcIhrs1VrwjFShJaC7mDSIqkkcuBWflRxWAITLmAQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S+xvoZF2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBC5BC433C7; Mon, 4 Mar 2024 09:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709544474; bh=jMsyGLHvO8uB8zv0yGRDRKH0t8IOUmfWepSdtjUOZTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S+xvoZF2GTy/RNd7tMYk20WS/5PzimRZfztQAxovLMVTXz69+dyZ3qiz7K0DNMsiv 6loEi8eC5AEsdku3Q/yBt7VJObLtzwbE+H6j62sODfdpE14MVYoyHsitx+xavdlxUy PruOIlewnMt95GVoqhhkGEsuqfiwu87CfLAX4HCLoxi1Ivfl0p+W6cskTwun1xDCQj qZTPn4K2ZZ489A54xop/I1dsnBIReBy3WHECGJ9z+zeURekb/l8eQaf2QeHtFsFRq2 1/+JhT9HPehKi3+Jm2w3yg7HKXwxHJAKw1F5rw0R+fSPvNkb9JTY4kcd7CVPNUMVj+ lNHjw5HJhXmjg== Date: Mon, 4 Mar 2024 10:27:51 +0100 From: Wolfram Sang To: =?utf-8?B?VGjDqW8=?= Lebrun Cc: Linus Walleij , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH v2 09/11] i2c: nomadik: support Mobileye EyeQ5 I2C controller Message-ID: Mail-Followup-To: Wolfram Sang , =?utf-8?B?VGjDqW8=?= Lebrun , Linus Walleij , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com> <20240229-mbly-i2c-v2-9-b32ed18c098c@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k8nmJLf0eP41vvSM" Content-Disposition: inline In-Reply-To: <20240229-mbly-i2c-v2-9-b32ed18c098c@bootlin.com> --k8nmJLf0eP41vvSM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + if (of_device_is_compatible(np, "mobileye,eyeq5-i2c")) { > + ret = nmk_i2c_eyeq5_probe(priv); > + if (ret) { > + dev_info(dev, "%s: %d: %d\n", __func__, __LINE__, ret); This is debug code, or? Please remove it. Especially since nmk_i2c_eyeq5_probe() prints something out on error. --k8nmJLf0eP41vvSM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXllBcACgkQFA3kzBSg KbYjBg/9FCc3QH08DNHSDclrHAf1fg5Z5zrN+QWrseFFm2Snxk2BMxDn5RV7YGpa 5ElyrLnZX1DpRQtokMYrejy1yTOJlwVUUZIIbdB958ASVTLp47vkRw6Diz5s0Jh1 Jy8Lry+P72uLeSdagK31sLOw4Hoys31DkkGZhzRotEO6G3VvgjQ5mXU64Cyz5xfy 1LV0uiL5iJ3d1a3rV9cFmjDroHjeVQ6UA+cahAr10S3BHsaxgt6q5ZyCbsSQWr8C YETLFQfCU6MjgDikEPch4GcpX6g2uNUR4nicVtvclxdT4C7b2dK8iWNTYRqncbcH QgcfhX6sYT5J23tMqnuKKfCHD0Fmo2nlyFNlHUUkLnZrMgCXU7APz8JUsN70Eahn tN0St7ccWN79BntxXyUeAooDOopPAhklSvN/rc0epG0/PGUlx4QZrZK+SGPWtTdP JX9tRIDavd4Swd7DRiL9hCmFQE2P6DhPlvO10TPoz7KI9LvZCZ0Fd2WJAsajo5mD MdgK0n4jC1XdqSC3WFTm7+MiAJUZJTsdkq7OFlGfWGgy0T0AQwq0FYX0sjREswQB 05xfcgLhn9XjUzAQIRErvh459o4IrxwfB3zgJtnL5RN64YN0P89+FBm5kkxfcATC 72f3ECGuiYFDiCbEWCuIT5OX5hiY37WcWVfynwSOgcAeBfRRT/c= =SBTB -----END PGP SIGNATURE----- --k8nmJLf0eP41vvSM--