Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1723846lqg; Mon, 4 Mar 2024 01:31:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV+vm48jdgSBz92qhHBa/AyiFC/H7Hv3g1j4iYKtolApUtGtiQipdVKDWrF3BxspjNx6Z4RRj0xJe/L9AmgQ0rLF9TUTE7LZYewfQ4JcA== X-Google-Smtp-Source: AGHT+IH7wP3fPE+zw+EMkjuYWpvw6pT2v+58BqUbCjZ2uZSuTkMWaBzU0oW3WRcH+TXJoLBoUF+Y X-Received: by 2002:a05:6e02:1c46:b0:365:175e:e7a3 with SMTP id d6-20020a056e021c4600b00365175ee7a3mr11696299ilg.20.1709544713431; Mon, 04 Mar 2024 01:31:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709544713; cv=pass; d=google.com; s=arc-20160816; b=h/rFtsHFccd32+ok3FXV8GjwnmedqR9C+0micWDBFLIZ2GpiXONo9HYofGTlNTs1ff VbhmLDPzYBhNKyxkEO4kDx2Fd906j5JRxrkLmnhvL/8AWus7+NGg3UyVVC/Rq8Z8mebL x6bKmQQVHlK3xto3oblDQExDk7kGo8+FzecpVB5KMPqmdc7JEdTkEcAszxUdZjtmBI1q Qul7AQnpbhJBGLaToSVTO/VCD7rio+nShPsffx2P65cN3p6qF+ZlTLDsohUKQCpEmPQ5 yl3/SmNxfgg1ZgI4CMnwvmk2TvbVKp6uNkojAMvd4KX2PNzkuCthZ1xuy6O+2AgIJ0/R HUMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:wdcironportexception:ironport-sdr:ironport-sdr:dkim-signature; bh=S3q7ViSJX3rT4ypEKFuG8rjnvKffHInUjucmG/xw4WQ=; fh=lbnuh9Va1UwcnWxZPbjQjN30xhVZh+Gs5sSzMLG81NY=; b=ffTf+rUAHXBLp8O5BJ2CRUWA+m/AfaMpqo13boZYTtUf2EWQJoyEEIqvvlx2W7VkNe tNtof4Hw0BH7jndq8MZx7zhsq0nENVwYdoYrcSd0mk4KdOwwkEKhvGcWedlDM8tw0G3N ewlbqSEvSYoijAKtNxWKO6dLnuiTstRL0pbpgJ9IcH1MX2BUFXXNN66qXkKKPZ91wXiS qp5JHJarOKxDyEAR2nJ8Xqzk73rZNXqDvkphFBkXhvqZ923qu4dZxXLkjmnQI8dj68Ih FJGpvCcMV8m5vyX2r4BDekBTKVEnXgDoDg0E5KEagrlTsb7PVPiCs8yJu0pqm31bvLGZ K53w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@wdc.com header.s=dkim.wdc.com header.b=kK3BzVN8; arc=pass (i=1 spf=pass spfdomain=wdc.com dkim=pass dkdomain=wdc.com dmarc=pass fromdomain=wdc.com); spf=pass (google.com: domain of linux-kernel+bounces-90310-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90310-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=wdc.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id s6-20020a6550c6000000b005d8bc09efb4si8163750pgp.886.2024.03.04.01.31.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 01:31:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90310-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@wdc.com header.s=dkim.wdc.com header.b=kK3BzVN8; arc=pass (i=1 spf=pass spfdomain=wdc.com dkim=pass dkdomain=wdc.com dmarc=pass fromdomain=wdc.com); spf=pass (google.com: domain of linux-kernel+bounces-90310-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90310-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=wdc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 19C0EB20CA1 for ; Mon, 4 Mar 2024 09:25:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DDD6236AED; Mon, 4 Mar 2024 09:23:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="kK3BzVN8" Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B05F210F8; Mon, 4 Mar 2024 09:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.71.153.144 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709544239; cv=none; b=bWMqKhU301SgcSU83Rw/JjtWTWRfS0LpOD89qU6E3ED8dRfaIUyf6WtGN4fZiC4E9GWPSETmoPPrXy33bPk2IHBMzKtz2SOh3fvNSnbhdvWjM4GWRlSHwFANt7DD9tR9XxKDL73CGUoY6pIkPPAdIHKodIQaV9VCKIcA1JczC8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709544239; c=relaxed/simple; bh=OjdXgl996KJ6kcslz1prq+1oitdyPh2abPpCxnR1xpg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=B66hYUr7avwQnsI6JxQT2RfTQ6sdGNF0rOEdiCu2AT4pi+SIE44WzeuCtgfI0hVPsdxagx3IReiJjnd3ZQ0B99IEC26ibd/llHH+icWVkb/vYkHRYLVMOTmDW48n3l5qZohUbputoRgouu0ZCjw7d44Y3D/vn/NPkWKrbd6hdkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wdc.com; spf=pass smtp.mailfrom=wdc.com; dkim=pass (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b=kK3BzVN8; arc=none smtp.client-ip=216.71.153.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wdc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1709544237; x=1741080237; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OjdXgl996KJ6kcslz1prq+1oitdyPh2abPpCxnR1xpg=; b=kK3BzVN8tjaY6aVEu9bhqDIl3dXYAuRb/6QcQ7S08gIIsEgltS8OGPWr +oaVSF6pSFtDT8mTOQOHCat8QyW9a7e2Q3aQu3y1FZZPKkJFDS2fxMI19 pkOkCObqbFGFUfgM3hm3ZDxSy8rdhDry/fm/WNs+Wgi1QpuNDJeLWLwek y86yAo2j+FVtqmGXKV+FooZKd9kSNMhDnotGriA5XPWzKM3P1aIV93hgT Tv+IUvGHGDobA20D9kVd1wes8CYbfwoFGNAvFMQS/szeisW/eeMUiQ9u/ HcIusHUyPVqOf7Dwo1LkXfLkGoxfyRCEoWAR3FIEqRlOB5DCrVMonewrt Q==; X-CSE-ConnectionGUID: QtHxfmh5SDeQnsihbwmKPA== X-CSE-MsgGUID: PO1S7Z45Rk2GPXSr6Cw3lw== X-IronPort-AV: E=Sophos;i="6.06,203,1705334400"; d="scan'208";a="11326487" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 04 Mar 2024 17:23:55 +0800 IronPort-SDR: 7nMD2euxlH8wRyz0fa3qFmKXlm+vV5EBzPgY6Q+IkRs85yNv7JaJrkkxcwH8ovDff5evndahfK PPGGQI4M6f7w== Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Mar 2024 00:33:08 -0800 IronPort-SDR: yZR0QJVOQPPKwAx+ursqZJ8HQsOKyOKft4ayJ7RdLkyl4H8LLIWxqbLDp8e0mzcg3B5oerY+SA 5EAcvFk/6dxA== WDCIronportException: Internal Received: from bxygm33.ad.shared ([10.45.31.229]) by uls-op-cesaip02.wdc.com with ESMTP; 04 Mar 2024 01:23:53 -0800 From: Avri Altman To: "James E . J . Bottomley" , "Martin K . Petersen" Cc: Bart Van Assche , Bean Huo , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Avri Altman Subject: [PATCH 0/4] Re-use device management code fragments Date: Mon, 4 Mar 2024 11:23:42 +0200 Message-ID: <20240304092346.654-1-avri.altman@wdc.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Device management commands are constructed for query commands that are being issued by the driver, but also for raw device management commands originated by the bsg module, and recently, by the advanced rpmb handler. Thus, the same code fragments, e.g. locking, composing the command, composing the upiu etc., appear over and over. Remove those duplications. Theoretically, there should be no functional change. Avri Altman (4): scsi: ufs: Re-use device management locking code scsi: ufs: Re-use exec_dev_cmd scsi: ufs: Re-use compose_dev_cmd scsi: ufs: Re-use compose_devman_upiu drivers/ufs/core/ufshcd.c | 200 ++++++++++++++++---------------------- 1 file changed, 83 insertions(+), 117 deletions(-) -- 2.42.0