Received-SPF: pass (google.com: domain of linux-kernel+bounces-90332-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 4 Mar 2024 09:34:03 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: "JiaLong.Yang" <jialong.yang@shingroup.cn>
Cc: Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/s390/perf: Register cpumf_pmu with type =
 PERF_TYPE_RAW
Message-ID: <ZeWVi6pua5QVqz_y@FVFF77S0Q05N>
References: <20240304022701.7362-1-jialong.yang@shingroup.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240304022701.7362-1-jialong.yang@shingroup.cn>

On Mon, Mar 04, 2024 at 10:27:01AM +0800, JiaLong.Yang wrote:
> The struct pmu cpumf_pmu has handled generic events. So it need some
> flags to tell core this thing.

It's not necessary to register as PERF_TYPE_RAW in order to handle raw events,
and PERF_TYPE_RAW is not a flag.

Have you encountered a functional problem, or was this found by inspection?

Mark.

> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
> ---
>  arch/s390/kernel/perf_cpum_cf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kernel/perf_cpum_cf.c b/arch/s390/kernel/perf_cpum_cf.c
> index 41ed6e0f0a2a..6ba36cf50091 100644
> --- a/arch/s390/kernel/perf_cpum_cf.c
> +++ b/arch/s390/kernel/perf_cpum_cf.c
> @@ -1213,7 +1213,7 @@ static int __init cpumf_pmu_init(void)
>  	debug_register_view(cf_dbg, &debug_sprintf_view);
>  
>  	cpumf_pmu.attr_groups = cpumf_cf_event_group();
> -	rc = perf_pmu_register(&cpumf_pmu, "cpum_cf", -1);
> +	rc = perf_pmu_register(&cpumf_pmu, "cpum_cf", PERF_TYPE_RAW);
>  	if (rc) {
>  		pr_err("Registering the cpum_cf PMU failed with rc=%i\n", rc);
>  		goto out2;
> -- 
> 2.25.1
> 
>