Received-SPF: pass (google.com: domain of linux-kernel+bounces-90412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <22110872-8915-43cc-b074-112644b16e3b@collabora.com>
Date: Mon, 4 Mar 2024 11:16:34 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] arm64: dts: mediatek: mt8195: Add missing
 gce-client-reg to vpp/vdosys
Content-Language: en-US
To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
 Tinghan Shen <tinghan.shen@mediatek.com>,
 "Jason-JH.Lin" <jason-jh.lin@mediatek.com>,
 "Nancy.Lin" <nancy.lin@mediatek.com>, kernel@collabora.com,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
References: <20240229-gce-client-reg-add-missing-mt8192-95-v1-0-b12c233a8a33@collabora.com>
 <20240229-gce-client-reg-add-missing-mt8192-95-v1-2-b12c233a8a33@collabora.com>
 <22e2cf1b-9560-4f4b-b08b-a112e8e272a8@collabora.com>
 <40ae06f4-0cbe-40f0-84c8-9b57dfbeb91f@notapiano>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
In-Reply-To: <40ae06f4-0cbe-40f0-84c8-9b57dfbeb91f@notapiano>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Il 01/03/24 15:39, Nícolas F. R. A. Prado ha scritto:
> On Fri, Mar 01, 2024 at 09:50:31AM +0100, AngeloGioacchino Del Regno wrote:
>> Il 29/02/24 20:44, Nícolas F. R. A. Prado ha scritto:
>>> Add the missing mediatek,gce-client-reg property to the vppsys and
>>> vdosys nodes to allow them to use the GCE. This prevents the "can't
>>> parse gce-client-reg property" error from being printed and should
>>> result in better performance.
>>>
>>> Fixes: 6aa5b46d1755 ("arm64: dts: mt8195: Add vdosys and vppsys clock nodes")
>>> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>
>> Can you please squash patches 2,3,4 in a single one?
>>
>> It doesn't make a lot of sense to have them separated in this case, only
>> generates commit noise for no practical reason imo.
>>
>> arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdo/mutex
> 
> I split them like this so that each has its own fixes tag and can all be easily
> backported (as mentioned in the cover letter). That said, the commits fixed in 2
> and 3 both landed in v6.1-rc1, so they could be squashed and still easily
> backported. But the commit fixed in patch 4 only landed in v6.4-rc1, so if we
> squash them all together, the first two won't be backported to v6.1.
> 
> Let me know how you want to proceed.
> 

Oh, I'm sorry I didn't notice that. Ignore my previous comment then, I'll take
those for the next fixes round as-is.

Cheers,
Angelo