Date: Fri, 4 Jan 2008 11:43:22 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, olof@lixom.net
Subject: Re: [patch 2/2] Add the end-of-trace marker and the module list to
	WARN_ON()
Message-ID: <20080104104322.GA18199@elte.hu>
References: <477D5340.9090809@linux.intel.com> <20080104074523.GD17447@elte.hu> <477E0CAB.2040402@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <477E0CAB.2040402@linux.intel.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 978
Lines: 28


* Arjan van de Ven <arjan@linux.intel.com> wrote:

> Ingo Molnar wrote:
>> * Arjan van de Ven <arjan@linux.intel.com> wrote:
>>
>>> +	printk(KERN_WARNING "------------[ cut here ]------------\n");
>>>  	printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
>>>  		line, function);
>>> +	print_modules();
>>>  	dump_stack();
>>> +	print_oops_end_marker();
>>
>> another thing: could we also put the marker into dump_stack(), and attach 
>> the marker to the Call Trace line?
>
> I have a preliminary patch for that already but I'm not happy with it 
> yet; I need to redo it properly. It's neither depending nor 
> incremental to these 2 patches though..

yeah, it was a sidenote - it should be separate to these two patches.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/