Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1754304lqg; Mon, 4 Mar 2024 02:47:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUIO01Ko87FU3NaSQ4zZZxZAgXNbsC2wtI5stI3O9OI2B0qHMLM4D0BzOH+2CE1g52xdJ6GvYP0hTnTbEAWbBoIvzin4CkPMjRd97VKMw== X-Google-Smtp-Source: AGHT+IF/bkyvveA8cPybChAp6gDF4//c9pLY9vPKsHa7OiwIhpnvaKFUpqtS2fnJwVBAXq98BWT1 X-Received: by 2002:a17:906:f195:b0:a45:40e4:8c8 with SMTP id gs21-20020a170906f19500b00a4540e408c8mr2162517ejb.16.1709549229170; Mon, 04 Mar 2024 02:47:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709549229; cv=pass; d=google.com; s=arc-20160816; b=c7G/yZAnVstlx09mV5aJgeA/0ubtrUgHRIXQEwV02yHcslYq94+4RkijfNVLd7T/d4 swQ3DjIIWBHZMNxid7aMTegSQBlvJzvCiyg4I1eTltl/lodEM6lN5vzEZvsGgWu32JSS li0096aOjhHPpaxxyG91kooxKW3YQW+t9M7/bydQ6ZVGIiKlQItVcteUTqVAM4ckCVVw bFSBQ3rwyM9aU2gf5NHjPnzsNy2O2dV036uDHPj6a2PaeH2AMgDV5mARzvWkkzFzuemk 74QQlD2vqpDg470RDt88eZr7KxDsotTPiDuCT056o+51zQ+zEiAEmprWmK74Y3TWehim oIEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ztqxNc62ilEiiomZuQZyglakJvz8sfZEaKzsNmup5ao=; fh=/w8WtlxsuOt7tkKbGK+d49AGKxcLlDDj6I6hhOA0z+E=; b=aojIycu6pE1jB5EQ0dylWBFRtbY8CUw2Tn2d0E34bHopUizu8skOehYkDlUJoQ5c0B HX/mVSPsV/uFX++P28hvosuF79J1GHnCC9Fj9+7iWcuKwexZ8BE7npuZbnEYlxrVDpBB EGj7LC83WrR2sO54g8mF4E0HmbEmt51UaKZ8QvxoDO/pxrIkN2Yb7QcnFurm8Ixy7MHW UN8/eZGgkO63jqSXr3liWI3XZPTM2yXsozG0DnfxE6QOpoBmGRPZjjZHUhNortLyVzyP inT6sfV4ns6ueg0IsdYOGJeu48DUgl3rXBisyFsX2hyKQhC/UTmXfhlGV2J/dzBbd6Px oF4Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ms94XLj3; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90455-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90455-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id cw21-20020a170906479500b00a44b3d10436si2467985ejc.948.2024.03.04.02.47.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:47:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90455-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ms94XLj3; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90455-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90455-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E144E1F21873 for ; Mon, 4 Mar 2024 10:47:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BC5AE374E0; Mon, 4 Mar 2024 10:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ms94XLj3" Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364F0364C8 for ; Mon, 4 Mar 2024 10:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709549221; cv=none; b=VFTpi14fIRehGymfWiNuHdcrUvRhJ9JJVzOFkdT6c/OGUECeeq7Ry5G+jEiWSbEb3VVcjmMHIEKJGilBUqsZNJjJaL50LE1d63u1+iqPdWSmAYj5WRvxX90c3PNVjQBE41bNeCcUKA9BuhxrEZxfdMhedQJ2CNFCzsBZ1tcmTe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709549221; c=relaxed/simple; bh=ztqxNc62ilEiiomZuQZyglakJvz8sfZEaKzsNmup5ao=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gijggdKOcX8zMBhx3ksT5krM9M7yTMhCsdgotyh9qZm39ZnDQ96XsHlgqxwgN/zpnhJXMzeL8J5HINWRruH/lefjRUkDGiOuwjwwwDfMVV0fKpR8s/j/5w+N8L1rBs/RpiAwWdxgnxy/3PlLbL8CAg3N+oKYEASWu4oE1pMSskE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ms94XLj3; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-412e784060cso1848775e9.1 for ; Mon, 04 Mar 2024 02:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709549218; x=1710154018; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ztqxNc62ilEiiomZuQZyglakJvz8sfZEaKzsNmup5ao=; b=ms94XLj3+eNTnxnGxOFScwCjm5FoZ7WZ8qoFpr177uVUQRxIYpu9qZ9o+X8AcfpFo4 9ERoa5PrO/PiDCWlbdT/dvUUeaw7MQau0TtVj20sULZXlrt36NIpiclxwxDQmKyJbzuc RVWCci+YlgkVmI8eU+nIJ5cuIVxu9l6hC/GVZMH1k0m4mbWyVtwgoCPYr44VtF8i6Xmq kKgNwI8+A2TOFwvHV7Q7KQ8VWK8VokS9aG7AdWVFRkxGDtSLpXSwGfqeaSQRdIHg3Ytr JH+xvnI86fmM/STrbrCMFn+Mnc6uSk4S8S32UdvUKQaj8JG3IcLLaW24nZveo6PJiUzZ wAdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709549218; x=1710154018; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ztqxNc62ilEiiomZuQZyglakJvz8sfZEaKzsNmup5ao=; b=L+hvbA9loL/UrEu7jWnXpf9Rjd4EEOL47V4BuY83iHlk4bIGcB53ECbTOPs84Dyt76 SViIwP+VJ/lWYglQneIRRCAr4p811FBu7+VwMTHKHEgQewevw1TfQpr9fwa/JW/B7y0H iqHhBCNBgi42a0HKrF9iLlId6YenN5hdqUgl0nDSHg5QPu5mS9GBSSm424GNIJ3wgmCL 6VKJmkBmWKH0hbhSTB3QUEYsmpOi7uhRaurncN9aOXYF+jOOHqqHpk1MClgHmai7wLzR hOo88BvwP0szVt7FiarrJxHRHJ4vcEMuwcANFtzxF1QhPc/t2qRFHNFSfFfVKGSf9VfK i1oQ== X-Forwarded-Encrypted: i=1; AJvYcCWmDXRFfx4HBpRHt8nU5g1kF0BKxhT55wYifRpSRefojldJKeTGYEJIwFkyqY4b0/agcVNgHjz3n+ugMcS9lIpNcp11O8ZNgJAiUCG1 X-Gm-Message-State: AOJu0Yz5E73EEVavHb5vL3jtC1ZTFcMseIo7fXXHX6IzD0C7HsWANUyM rxS/z58EE7THb8fBCrBuE9Jgzv/Picd7EWYofz7zUmHvXJh2cLj7WGGTY9ceKEk= X-Received: by 2002:a05:6000:1cce:b0:33d:d7c7:4c33 with SMTP id bf14-20020a0560001cce00b0033dd7c74c33mr7776162wrb.29.1709549218568; Mon, 04 Mar 2024 02:46:58 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id ch14-20020a5d5d0e000000b0033e18421618sm10161297wrb.17.2024.03.04.02.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:46:58 -0800 (PST) Date: Mon, 4 Mar 2024 10:46:56 +0000 From: Daniel Thompson To: Krzysztof Kozlowski Cc: Lee Jones , Jingoo Han , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Message-ID: <20240304104656.GF102563@aspen.lan> References: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> <20240304-backlight-probe-v1-6-e5f57d0df6e6@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304-backlight-probe-v1-6-e5f57d0df6e6@linaro.org> On Mon, Mar 04, 2024 at 11:11:43AM +0100, Krzysztof Kozlowski wrote: > Code can be simpler: return directly when devm_gpiod_get_optional() > failed. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.