Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1768308lqg; Mon, 4 Mar 2024 03:18:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX6BZJtcjvvNkk+y3ba21+uC00L702gJrqe5y5qZtPRcr4Exkzn9gHPCIj9HhPFYutnx3sbGHPh3sVlngxGiNhx/faQ0XHsTJowOl6nHg== X-Google-Smtp-Source: AGHT+IHj7pbk+Nybn+HmmRr2CeeeFJBYwingSlg2MmzyN19gaJ3V5nXkfaTAAywwgGfvDGZpLZyE X-Received: by 2002:a05:6a20:1454:b0:1a1:20be:6024 with SMTP id a20-20020a056a20145400b001a120be6024mr10958568pzi.17.1709551082256; Mon, 04 Mar 2024 03:18:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709551082; cv=pass; d=google.com; s=arc-20160816; b=NthTdnu4P5khZtYnsz3tQRHV00h9bUH/l+uFWM9pAVyV2jYgs3dEBJwL/odkDCyJ62 DK4Lb0FJ2chXT0wyfYcY7thYqkXs5atYhYYH5pqxF6MwsPtCY5H/LuUJzlwlhjp3eENp fNZV/d1zj67ZJemkyPPDPtZUKPArF1NMFkIX1evyQ2EmEw0045hO3N8HJpsh+9jk2IOs MsZrFTuIEYxpeWmDZJs/eunjQgRCkH76owM5q8oyzxXDgMTHoUoCxE4wALTOuO2m6Bm1 XeOpB1IeBc4Qt0Af7p4wo845OiQ1jVLWgOEFXxRf8Y4C5MmoUE/7LyP4ZCXQm1GYbNml WVkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DPUD3naOzI7U6jLpCCkxFwa6T8a3pJ7jOrwXbJt7XTY=; fh=cZgHAXp66/lv6eEk8IQVn7CkFRVSFDLp157P4LA9h9M=; b=Wxlywprqw55SMWWA2+dXCUTI9ZKzhKp++gIVRiNsja9rRg5MJypV2meNmiNRH2nKqd H9m61OLoMlx8VxwS7OVP/gyKf8oVURO0a0hdrtkP7bsregHn2Hzsu0QgJnUkxErHOATT PeVnqXcp8Ju/4lEKwQfXNN5tI0HTsnI9CxTp5rjCQrkFze9EBST46S4FqCz0J/ljkH3Q zUUnOsvF18mrwYyNH/ZNmRJJEudxTq45znsP6XK98sWNsAfBXot5iodwwa0dzhayIKjv iRzdWm7VB9qmJ9t4a7NPCxmUOCbMqAkoRhlnZHBWDdxnV2me3TBQLXKwGva8aDwmEk5N g6Dw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Sop8FN6d; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 7-20020a630a07000000b005dc4da211fdsi8039145pgk.141.2024.03.04.03.18.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 03:18:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Sop8FN6d; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DF32728465D for ; Mon, 4 Mar 2024 11:17:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6BDF838392; Mon, 4 Mar 2024 11:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Sop8FN6d" Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ABA5383AF for ; Mon, 4 Mar 2024 11:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709551023; cv=none; b=BXH4w+KWurz50eIN5Ttab4li/f/Jo8mrK6pzxeKj4g1+NDEXHwzIaYvRix7UJu19AJ5gggu35+PU45dkMAfpjbOJiJ/1VlAFk2SE6Pi7y1oAdtUUrK0txLP5tEoQWfX4+mr8/WmMbKm+yJYJ2EnlTPegmQNZty3w985Ep4CuXLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709551023; c=relaxed/simple; bh=1BlIC2w6gZRcb1Jdtr26xUooK5VTCCvRxi1fD+9dmjU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jVFFvLQKMNeeNy6SqScD2fwpKCy1AbvUnCI0IWspNVf1Mmq8Jj1u62mGItKnzRu3SXnqCSP+F3AiErBN1sqFwzyGhmvs135uD9CRR1tcV+zA1QPeM+aDNrdipOmOlP45Z7ax10bd51lglI7hJVo0hTQB5LED69dOsMpuGxrgTmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Sop8FN6d; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-412e784060cso2084885e9.1 for ; Mon, 04 Mar 2024 03:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709551020; x=1710155820; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DPUD3naOzI7U6jLpCCkxFwa6T8a3pJ7jOrwXbJt7XTY=; b=Sop8FN6dK6CxzkRm+YtGJ5SIU8GCTvMBSK+QW/8ZmCwyQ71Qx0VlGTnjaBAoplBzn7 /tPeYjx0RwbWoEZXZGJmBczDNLsKtAL0py3YxBi9yz5KSmAh9pRaw2EKCJNbkKkGLPCz Z/e5iIoGad0Su1hovQ/nQUbzFi1fukotQdzx2lgv/qCIoqxLNuEfqV610Lt26kxGcwqL 7ldjC0jTx92vFJd4XU9rkuA4g3Sj9AkoiHExCye+KlxOiAvag8kurPvq5MKSE0bDnV7f c8CDDLO214JwHEnyubXlFt+7xvQaSLt4hqokjky01b9L1fcIzVC551gLxEfcJwr+OXvl BQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709551020; x=1710155820; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DPUD3naOzI7U6jLpCCkxFwa6T8a3pJ7jOrwXbJt7XTY=; b=HgUsjatRsXlXY/dhdznD8mdmUIHviP52pr4t5TeZ8KUA9RI7xsHVFapj6GdvLGTpGz aB4fR4MppriOKhvpNH9MvSNZ3dXLWR6aMChYq/MS1Vb+yZWamwW7TYlWXeRA06uUyM+S BwaFHwNqnarRG1P9Q3h22MaoCItB/TUGozyBOxlq3dF3M7C7thna90DArkq/60+m+9jN EcgwCSMoGhlT1N/9C7oT7P5JNDipyTgNoJBL7EU5nNIbtBir+h32McAmiTTtHfSUwd/8 fLXkHlo4mj6lgOnBp81D/w+WOGFC0C/9P0LfWsGj7InNpuTpAr7Oedr21xFgIsXREse7 seXA== X-Forwarded-Encrypted: i=1; AJvYcCX6zxrmMEdW02YBYr5msOGLkV997n+S3eHwqO/ERhyhpWIFjGUgNUpzMVSlskKyXWhB3hWW40oFysK7U3uH2nM+X4ZjlPs8E3Mrgny1 X-Gm-Message-State: AOJu0YyOaxS6KDmK7ikMNVvcwIC9STJRkT4y1cZ1nYMmzkPvKMHm4vNC dmA6aqxjT88dsEIQqnReyJu3ax5DWfHXCzMInq1DJ+4k8f41hj/KrTCcItyf+9A= X-Received: by 2002:a05:600c:3849:b0:412:e568:a123 with SMTP id s9-20020a05600c384900b00412e568a123mr1251187wmr.10.1709551020575; Mon, 04 Mar 2024 03:17:00 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id n6-20020a05600c4f8600b0041273fc463csm17525439wmq.17.2024.03.04.03.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 03:17:00 -0800 (PST) Date: Mon, 4 Mar 2024 14:16:56 +0300 From: Dan Carpenter To: Sakari Ailus Cc: Geert Uytterhoeven , Markus Elfring , linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab , Niklas =?iso-8859-1?Q?S=F6derlund?= , LKML Subject: Re: [PATCH] media: rcar-csi2: Use common error handling code in rcsi2_parse_dt() Message-ID: References: <8b4203dc-bc0a-4c00-8862-e2d0ed6e346b@web.de> <260d82b6-e7fc-40c3-b414-50a883709fd7@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 04, 2024 at 10:48:47AM +0000, Sakari Ailus wrote: > Hi Dan, > > On Fri, Mar 01, 2024 at 04:42:01PM +0300, Dan Carpenter wrote: > > Sakari Ailus pointed out in another thread that we could use __free() > > instead. Something like this: > > > > Looks good to me. Thanks for checking! I've never used these before. > > We could merge this with your SoB (pending Niklas's review). :-) The driver > has been since moved under drivers/media/platform/renesas/rcar-vin/ . Alright. I can resend this as a proper patch. regards, dan carpenter