Received-SPF: pass (google.com: domain of linux-kernel+bounces-90508-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <6ef6c5bf-e6e5-4711-81c6-6ae41de2e61e@wolfvision.net>
Date: Mon, 4 Mar 2024 12:26:48 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [REGRESSION] Missing bcm5974 touchpad on Macbooks
Content-Language: en-US
To: Takashi Iwai <tiwai@suse.de>,
 Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org, regressions@lists.linux.dev
References: <87sf161jjc.wl-tiwai@suse.de>
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <87sf161jjc.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjA4NkFmY282SklETFRvSFpqMm1MYlQwdzY1N2lsRkJsQkkrUWVDUDU5ck1m?=
 =?utf-8?B?ZUR6QXVoYUQ1WFZuRzk5NFI4M1J2eUhOQVNuSnIxS2I1MUo0bzJVYWJzR2xU?=
 =?utf-8?B?NlkrT3k5V0VkMUtFMCtza1ZCWGNYdzVkZng1RDlUeklOR0EreGZQaDN5SDNP?=
 =?utf-8?B?SytkZjJmQUlpZm1qOGM1cE15eUFNMERqYnJrTTZyV2k5S0Jnb2FYQmFQdzc0?=
 =?utf-8?B?ZjN2bzdXY2tleitkZTZJNFBQdVQyNzY4dVAxcXVERURIcUZsRm4zUVRmWVNr?=
 =?utf-8?B?UkRSbG5QWTVmb0xVUmRyVUl4NzZDbVVpZmh3YzdyeEcxZUhVcXFSMFJqeHRE?=
 =?utf-8?B?d0JTNFkvRmJrNVd6ZGZwS00vL2J5Vkh5NmZKUG1xWEVqay92dk1TbmcvTnN5?=
 =?utf-8?B?NnpnMUZuRkd1d0o3emVzMEZ1M3hwL242T29WRmRseVdyL3lXSG1ObmZCYWNX?=
 =?utf-8?B?RGFGNVYzdXlJS0RrOVdjSjZrOUVWS1hwb0dqZmRiUkNQNUNnTk9MbmNxNmtB?=
 =?utf-8?B?dTkxSmJ1QWI2Qy9rbHJPcmZqSEcxZ2hFemtDZFVWaTFSU09ZV1ZsYWFLSThD?=
 =?utf-8?B?YmNQK1NBdy9zc0xtY0VHOUZOUWVWS0hOdVM5Y0VkdUxpOWc1QmNibHNNS2Jw?=
 =?utf-8?B?WE9yTW1RQ3ZBTVEzWlkzUTcwcitTS0VNL055bVArby92OUJDNUpTdE9GQmQ5?=
 =?utf-8?B?WWd0MmJWYTNXeVBzNCtLcGNZb1NtdnVDNHlMSTBOUVN5dEgxT2hNYUNnWlN1?=
 =?utf-8?B?NThJUlRweWVCRjJhTEVHWGU2NWN6d3pPQVZZdEFDWkZsOHBXN3RVY0NuNFJS?=
 =?utf-8?B?ZDZkaytEL2NRQUVVemJDQjY5YUxCTDJGTHBZYzlFbUpKL3BQSDdYZUlkOEFr?=
 =?utf-8?B?dFpxMFc5d29JbnpzNm1veEU1VXMxQ3piczdoQXpzK2xMT1BSOCtEVlNDa2Fx?=
 =?utf-8?B?bG91Y1dyWFhyLzhRMUhsakMvb1R6a01qWTkvRE02NHJDaUV2S3piRDFxc2Ux?=
 =?utf-8?B?U0dqK2prek9tTENVTVhTMnlqVzRhQk5rUHBINGV4NUpxSzF0b2ExbUhzN2ZT?=
 =?utf-8?B?ZDZOTjBFNVYyd2xiYTFWbGZmQ1RYdlJDRXJ6RFFQSjVaN1BkWlZYRUVXSU85?=
 =?utf-8?B?WHV4RDcreTNibS9vQncvMkNXWUlkc09xL05kbkJMbXZHOHV0a01uYVZqODNU?=
 =?utf-8?B?ZkcyUTZycHY5aXdhNy9malkrS1BiRGwwQkxCS3Y0OUVKaVhuTUk3NTcwLzJu?=
 =?utf-8?B?MDRKOVF1MERTZFFScmhRMkVTMlg0VkZjM2hzU05kd2RiMmpKMWpFMnVqaWtP?=
 =?utf-8?B?OTdrWlVUc2ZYNmw2V0dGRFB6T3AvRVVtRW5mTkh1MDU5QWNIa3RIRHVPVzhq?=
 =?utf-8?B?UWJQazc1ZUN5UGhaWFltQmZvQzYya2piR2lYRUFhRElocFI2Z1B3RlR3QWxr?=
 =?utf-8?B?eUtQMzVXalIybCtNZmdqY2JuRDAzSC9zWmtuazlQb0VhMHptTlpTR2owNnND?=
 =?utf-8?B?MUM4T1YzRW4zT3Q5dEM4SW1XeTY5eVJSVXJ6VmptMjJtaUM5dUhpUVlIS0U3?=
 =?utf-8?B?eEo4cWxlNDZLM2pndG9KdXRucjZCSU52ZDhCbE5BS01jbTQxQkFvSWNSWUZ3?=
 =?utf-8?B?N0hVa1RERll5SmlFTGRsRG9ycnNycWxrZVNMNkZTQkd0MTgrUVZqelBKK1A0?=
 =?utf-8?B?YitGYVhWd3hzZGVra0V5MmwrLzhsUGZWU0d4SXdnQ0JEYnBVdTdLODhyYXBn?=
 =?utf-8?B?bTJ5SzR5ekhTTGZGQWw5SFNTL0daRWJGWWUra0VrNEhJaFhUVDMzNFE2RGo4?=
 =?utf-8?B?N0hSN21MNHVUMENjYkdiRXNoU3lMa3gvSnErS2E2S3J1M1NoOXRZTUdaUkNK?=
 =?utf-8?B?ekY1dnA0SGR1d3JtanJMNDg3T3kvaSsxc0dVb0ZvaWE0b0I3VHM2ak4vcmVW?=
 =?utf-8?B?d05qQUh0UmZ0ZGJNT05zZFlyRG9Cb3BuTkJ1cWJqM3RuNEY5cG0vNGRxSFEx?=
 =?utf-8?B?MTRQSWZ2VXVDUmIrR2E4WUFTaE91eU10WTZ1R0tIV01hNzdlNVJ2UFpQenV2?=
 =?utf-8?B?blBGRG9abS94eVBhQ2NxdkNOQi93WHh1a0VNRGtzSE5tSi9ncis1aGsyalZK?=
 =?utf-8?B?Y2U1UFVsUnhkcEhLeE9ncXdlN3R4b0V3REtITnBZRnZ4eDFKY09BT3BscGF3?=
 =?utf-8?B?Z1docGdSakxjeU15SFlIZ1RETXdXeUJkaHJYdjJ4LzVHTVAwL0xpeDRxWE9q?=
 =?utf-8?Q?8Yzz8dSUMCpOhx2hiLSAtmmgKLpmSs+8ctRDH1XP6o=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 60590d7e-0bf8-4af2-cdf1-08dc3c3dfcdd
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 11:26:51.4248
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j5blr7XNyZiYVW1qbfEFuBf5q9c7cFW+10uxvQmaieZ1sM0DdbTXG11k9rLAWV2gFBNXwo2Dp+xpA1oxCWB0N1j/WI5iODusCm3ecQFRcgk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10315

On 04.03.24 09:35, Takashi Iwai wrote:
> Hi,
> 
> we've received a few regression reports for openSUSE Leap about the
> missing touchpad on Macbooks.  After debugging, this turned out to be
> the backport of the commit 2b9c3eb32a699acdd4784d6b93743271b4970899
>     Input: bcm5974 - check endpoint type before starting traffic
> 
> And, the same regression was confirmed on the upstream 6.8-rc6
> kernel.
> 
> Reverting the commit above fixes the problem, the touchpad reappears.
> 
> The detailed hardware info is found at:
>   https://bugzilla.suse.com/show_bug.cgi?id=1220030
> 
> Feel free to join the bugzilla above, or let me know if you need
> something for debugging, then I'll delegate on the bugzilla.
> 
> 
> thanks,
> 
> Takashi
> 

Hi Takashi,

The commit adds a check to ensure that the endpoint type is interrupt.

According to that report, the issue arose with a MacBook Pro 5.1 (no
button, only trackpad endpoint), so the check on the tp_ep address
(0x81) returns false. I assume that you see an error message
("Unexpected non-int endpoint) and  the probe function fails returning
-ENODEV.

Do you see any warning in the logs when you revert the commit? It was
added to prevent using wrong endpoint types, which will display the
following warning: "BOGUS urb xfer, pipe "some_number" != type
"another_number""

I am just wondering if for some reason the check on interrupt type is
wrong here.


Best regards,
Javier Carrasco