Received-SPF: pass (google.com: domain of linux-kernel+bounces-90512-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <172bead3-6b65-4598-9d5d-a560da4b153e@amd.com>
Date: Mon, 4 Mar 2024 17:00:16 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/2] vfio/cdx: add interrupt support
To: Alex Williamson <alex.williamson@redhat.com>
Cc: tglx@linutronix.de, gregkh@linuxfoundation.org,
 linux-kernel@vger.kernel.org, kvm@vger.kernel.org, maz@kernel.org,
 git@amd.com, harpreet.anand@amd.com, pieter.jansen-van-vuuren@amd.com,
 nikhil.agarwal@amd.com, michal.simek@amd.com, abhijit.gangurde@amd.com,
 srivatsa@csail.mit.edu
References: <20240226084813.101432-1-nipun.gupta@amd.com>
 <20240226084813.101432-2-nipun.gupta@amd.com>
 <20240301104521.228f8e84.alex.williamson@redhat.com>
Content-Language: en-US
From: "Gupta, Nipun" <nipun.gupta@amd.com>
In-Reply-To: <20240301104521.228f8e84.alex.williamson@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S3FrUVhLL214RVcwcWpzSll0ZUE5M0wzbjdYeUtidzZyS3FGb3BpVHpwZmJZ?=
 =?utf-8?B?WmtxY01HM0tWRkF0N1Vsa294djJaZ01WSXlOMlJoeVpKUk13bDFjU3ZzQThH?=
 =?utf-8?B?WEdleEdJSUpkaUUxWThlSjl0VUlML1h4R2RVWkVwZjlIazYvaVU3bEg4VlNO?=
 =?utf-8?B?QXhieHVOQzZ5eFdTVEp3bkxBK3hFNXpoZ3JyYlNRL3NUYklxUkNZRERkS1RN?=
 =?utf-8?B?T2JoUnZNYkNId1BjamNUcXJQOHloVHFlem43YkJCTHhnMDRtTVRmSkxRY0VV?=
 =?utf-8?B?c0JQT1RUYnFtZmF0MkdEZy9xaVRrN2QwMHJiYkh1TzBOY2xRUW5WbmkzbVpS?=
 =?utf-8?B?dFRqT1lJZGl0QUU2SThIeERPajBrQzVGRGdqbkFCUkxjV0ZuOEMrWDlpZUZl?=
 =?utf-8?B?Zmd5L2Y4SkhneDVVUzJ4c0JaWVZ4V2U0UU9ZUzRtY2RvTC8yck9vUTlkdWtQ?=
 =?utf-8?B?WEtxbFg4K2dGay9zM1M4RXltem1jd29pb1crWG9uMDJNUEVZNUFTQzZ6dkZO?=
 =?utf-8?B?SU4vSEtBZGRFNzAzWEZGQlZ6WVY4ck1kZHlQUzJVcmd2ZGJIaXZWVEhkN21m?=
 =?utf-8?B?ZlBtazJZWW1FUURwR09mSU9IK3plbVdSNk5OUmpOeEpaL2NUR211NTNHdjVF?=
 =?utf-8?B?OUJRVkllY05BM2VvQVArT1k2TkpKZmNPMllnVGRISmwzT2Z4Slpxa1grYStG?=
 =?utf-8?B?ZGhDNTdrRDR4Njh4L0lXNVR4ZStsaU5lZWtEeDNtZ3NBaTlnRzU5QTRrc0kr?=
 =?utf-8?B?WEg0eHYycDlSajI5NVJTckkzRCtxaXdER2w0OWplSW9SWkR4MTA5MjUvK0Zk?=
 =?utf-8?B?MThXaTgzSC8vaVFBdFRZQUh1Wkhwd3BJaFBoNG5FVnlkUTE2Z0Faek5VczNl?=
 =?utf-8?B?LytBbE9PSWtRUXEyM2hXYlEyb2tRS2FXUmd2eUtUK0czZy9DMHB3Wml4NFkr?=
 =?utf-8?B?eG9NaXdvUFovQ3NxTlpuUENQckE2Y3oxT015MG55SmVOVlBIdXI0am4zUVl3?=
 =?utf-8?B?VjB3aVZ2eEphRkVDaXFRZzR2RUk5cjhmaGNucndjM1FkMWF3YzZvRHE0TWhU?=
 =?utf-8?B?Q3l1RjdveWNzWXFuVTFlUG0wSTNFV3pReDVhcFM3aitXcUZQVXJ6ZHVzNVZ5?=
 =?utf-8?B?QmVyYnQ2T2U5Z1VwLzU3UTdmd3JCM3ZlZFBVVXFnS0hlZ0x4VDdwSm9wbno3?=
 =?utf-8?B?TlFzdlEyRTBveE1jeStRNnRtOUw3M2prUFY5TXp0UkVRRmhPemZFSXVxd3p0?=
 =?utf-8?B?MExMR2x2aXZrZlh1TnVMMU9uUG4raXFwSk1oVG9hQVkwZTZQWXlSMjNocGh6?=
 =?utf-8?B?Zmo2WHQzTkdMbkN2VlBhc2NhczlkaXlIdlByRHJ1dkVnTDZLV25jYmpLMHlU?=
 =?utf-8?B?R3hqODNGeFhmKzZRS2Q2YVdUSVhSZ2M1dkdHWkgyVFN4SFIrR21MYTJSSSt2?=
 =?utf-8?B?ZDJYeVBCNVhaUklGV2xiTDdReVNhc25keGhMSlR2ZnBpQWZSYU1Od1pEdXZL?=
 =?utf-8?B?V1d0UHBpbDhWNzVsN2FrUnd0TWRmMG1DZlhwa1NZaDRSbjJCdlVoY3RJYVNp?=
 =?utf-8?B?QjdOajkxSVo4a3d4dWFEczZRc2JubDZYS1FsRHM2UkkrQndiMjB0aGcvOVgy?=
 =?utf-8?B?emE5cjgvZ2FORnIvUG5yQzJETEh1Tm9hY1lOTnNzUnFESEpxSWRhcU1Bby9r?=
 =?utf-8?B?SnB3OHE1bk1MVk1OU1YwalFqaUEybmI2dmowY3Jxd1dUN292MWZndmNsOWtj?=
 =?utf-8?B?d09NVXpqNEpqSnZ2QVJZUG1xdEh6WlhjTU9NMlFaUlN4aEg1eXBBZVZReCtj?=
 =?utf-8?B?emh1TEtSYVdMcmwzS24xNlhwK1Q1MlpRSFhUT0pWZHRSZi9XUGJGeWdaN2ZM?=
 =?utf-8?B?VitoODQ2cFFuNjEvbGs1eStRdk9mOXdhdHlZS1hhOXNnTXcrZmFVN0l6NFZU?=
 =?utf-8?B?b3VGT25VVTUzayt6aVRpaVZjbk9hMXV2OFpzVjREbEM3aVVBSEgrUTh3YTIy?=
 =?utf-8?B?QnZQR0ljMGkyakMxSHZ5c2xjTk40VURFYU85aHBnSVEwQXR3SHpEKzgxdWtk?=
 =?utf-8?B?dWhRTGVWMjNldndEZHovQld0TllOTTZIUGpJQitETjhFdFhweG0xY2VQdEhG?=
 =?utf-8?Q?lQWhyfTdTG426LQ5xusAWjzok?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11f73971-0f98-41c9-af05-08dc3c3e7de7
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9193.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 11:30:28.1733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /QYbm6M0EOjD9RhlxvWeeFNQsWq4kOXMK3t4yRxL6yS42qShEpYfjMBInn7z8jcl
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4230


On 3/1/2024 11:15 PM, Alex Williamson wrote:
> On Mon, 26 Feb 2024 14:18:13 +0530
> Nipun Gupta <nipun.gupta@amd.com> wrote:
> 
>> Support the following ioctls for CDX devices:
>> - VFIO_DEVICE_GET_IRQ_INFO
>> - VFIO_DEVICE_SET_IRQS
>>
>> This allows user to set an eventfd for cdx device interrupts and
>> trigger this interrupt eventfd from userspace.
>> All CDX device interrupts are MSIs. The MSIs are allocated from the
>> CDX-MSI domain.
>>
>> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
>> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
>> ---
>>

<snip>

>> +static int vfio_cdx_ioctl_get_irq_info(struct vfio_cdx_device *vdev,
>> +				       struct vfio_irq_info __user *arg)
>> +{
>> +	unsigned long minsz = offsetofend(struct vfio_irq_info, count);
>> +	struct cdx_device *cdx_dev = to_cdx_device(vdev->vdev.dev);
>> +	struct vfio_irq_info info;
>> +
>> +	if (copy_from_user(&info, arg, minsz))
>> +		return -EFAULT;
>> +
>> +	if (info.argsz < minsz)
>> +		return -EINVAL;
>> +
>> +	if (info.index >= 1)
>> +		return -EINVAL;
>> +
>> +	info.flags = VFIO_IRQ_INFO_EVENTFD;
> 
> 
> I think the way you're using this you'd also need the
> VFIO_IRQ_INFO_NORESIZE to indicate the MSI range cannot be expanded
> from the initial setting.  Thanks,

Yes, agree. Will update the flags in the next spin.

Thanks,
Nipun

> 
> Alex