Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbYADLaI (ORCPT ); Fri, 4 Jan 2008 06:30:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751065AbYADL34 (ORCPT ); Fri, 4 Jan 2008 06:29:56 -0500 Received: from E23SMTP02.au.ibm.com ([202.81.18.163]:45268 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbYADL3z (ORCPT ); Fri, 4 Jan 2008 06:29:55 -0500 Date: Fri, 4 Jan 2008 16:28:58 +0530 From: Gautham R Shenoy To: Mathieu Desnoyers Cc: "K. Prasad" , mingo@elte.hu, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, dipankar@in.ibm.com, paulmck@linux.vnet.ibm.com Subject: Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost Tracing Message-ID: <20080104105858.GA13865@in.ibm.com> Reply-To: ego@in.ibm.com References: <20071231060911.GB6461@in.ibm.com> <20080103163055.GB27651@Krystal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080103163055.GB27651@Krystal> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3220 Lines: 82 On Thu, Jan 03, 2008 at 11:30:55AM -0500, Mathieu Desnoyers wrote: > * K. Prasad (prasad@linux.vnet.ibm.com) wrote: > > This patch converts the tracing mechanism of Preempt RCU boosting into > > markers. The handler functions for these markers are included inside > > rcupreempt_trace.c and will be included only when PREEMPT_RCU_BOOST is > > chosen. > > > > Signed-off-by: K.Prasad > > --- > > include/linux/rcupreempt_trace.h | 46 ++++++++ > > kernel/rcupreempt-boost.c | 211 ++++----------------------------------- > > kernel/rcupreempt_trace.c | 183 +++++++++++++++++++++++++++++++++ > > 3 files changed, 251 insertions(+), 189 deletions(-) > > > > Index: linux-2.6.24-rc2-rt1.MARKER_PATCHES_NEW/include/linux/rcupreempt_trace.h > > =================================================================== > > --- linux-2.6.24-rc2-rt1.MARKER_PATCHES_NEW.orig/include/linux/rcupreempt_trace.h > > +++ linux-2.6.24-rc2-rt1.MARKER_PATCHES_NEW/include/linux/rcupreempt_trace.h > > @@ -102,5 +102,51 @@ extern int rcupreempt_flip_flag(int cpu) > > extern int rcupreempt_mb_flag(int cpu); > > extern char *rcupreempt_try_flip_state_name(void); > > > > +#ifdef CONFIG_PREEMPT_RCU_BOOST > > +struct preempt_rcu_boost_trace { > > + unsigned long rbs_stat_task_boost_called; > > + unsigned long rbs_stat_task_boosted; > > + unsigned long rbs_stat_boost_called; > > + unsigned long rbs_stat_try_boost; > > + unsigned long rbs_stat_boosted; > > + unsigned long rbs_stat_unboost_called; > > + unsigned long rbs_stat_unboosted; > > + unsigned long rbs_stat_try_boost_readers; > > + unsigned long rbs_stat_boost_readers; > > + unsigned long rbs_stat_try_unboost_readers; > > + unsigned long rbs_stat_unboost_readers; > > + unsigned long rbs_stat_over_taken; > > +}; > > + > > +#define DEFINE_PREEMPT_RCU_BOOST_MARKER_HANDLER(preempt_rcu_boost_var) \ > > +void preempt_rcu_boost_var##_callback(const struct marker *mdata, \ > > + void *private_data, const char *format, ...) \ > > +{ \ > > + va_list ap; \ > > + int cpu; \ > > + struct preempt_rcu_boost_trace *boost_trace; \ > > + va_start(ap, format); \ > > + cpu = va_arg(ap, typeof(unsigned int)); \ > > (sorry for late response, I just came back from vacation) > > Instead of passing the cpu id as a marker parameter, why don't you > simply use smp_processor_id() right here ? > Agreed. Also in patch 1, in cases where we're using markers in place of RCU_TRACE_ME(), we need not pass the parameter and simply use smp_processor_id(). It's only the RCU_TRACE_RDP() that requires cpuid to be passed. Thanks and Regards gautham. > -- > Mathieu Desnoyers > Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- Gautham R Shenoy Linux Technology Center IBM India. "Freedom comes with a price tag of responsibility, which is still a bargain, because Freedom is priceless!" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/