Received-SPF: pass (google.com: domain of linux-kernel+bounces-90547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a8cae5ad-8a2a-4752-a2cd-634c1746af8f@web.de>
Date: Mon, 4 Mar 2024 13:10:11 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] Input: iqs626a - Use scope-based resource management
 in iqs626_parse_events()
Content-Language: en-GB
To: Julia Lawall <julia.lawall@inria.fr>, linux-input@vger.kernel.org,
 kernel-janitors@vger.kernel.org, Dmitry Torokhov
 <dmitry.torokhov@gmail.com>, Jeff LaBundy <jeff@labundy.com>,
 Rob Herring <robh@kernel.org>,
 =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Jonathan Cameron <Jonathan.Cameron@huawei.com>
References: <8a7607f8-d634-415e-8269-e26dcc0f9fdc@web.de>
 <ZeU8ENmnPj3sKxAv@nixie71> <ZeVOPSt0L1D4BxuZ@google.com>
 <e8a2b63f-4f9a-463b-b419-c5f673191111@web.de>
 <b91fe21-fe2-eac8-d1ee-ea8922a08861@inria.fr>
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <b91fe21-fe2-eac8-d1ee-ea8922a08861@inria.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:DNcDAss1Lss=;J+Ty/FXrv4R1l3N0EljlsZQhbMX
 e+tYAqBtBYmJg3e1gA/d67ve0J8cQuNw8Suas1sIgfGZskJNuPTkukqwm5UEkxdAyT3vjckmv
 MfS109EG+fH2VtNp2C/BawYffFYWMW9lZ8lpYLAXBGN4u3nxG20Z1ZG6XtyDeibgNN/Sb3MyI
 kPzYEWLfBJkurOUy/DUda/zblrQ6TjxL64yoLxWmVV9gNZzK3e8T0dp37B5zjz543w6hhlKH9
 u8gKEF9Z5/fe5yzvpIwa2EMvp48ckEy2LcwlYpSu8+pUj06CgQU9KLB1RhJoMvtRu9KM3c9uk
 vtcT6xkEGZHAuAuzyF+/BBXqwIUimqmdNJ7amxLSoqbDu1lGvW+Zy3ew47SRTlgnWkz81Wf2Q
 TXpAMGuYEXXZpTh2ZTPTAOG2XwuR9l79ELZ6Do2BnClxmjK3C3RIRa353YTCYXSSI0FA3RW9y
 t86kC61H1uT4X/PF5dRMOf7wsgWQuVu0XJP/cddIQLH51Xth/Wz2DdLOsxq8lyy97PMEVyqjy
 V0USe2t7YzRfEsASjdMYCx+6WqmYVn+u04PCHq+zx8lrNHit2qsz8T5zLQXh5N1y+KU1wlbES
 skxAYskP2K2dmC8NAe2mqsX0VV0pM8U4Sri5v8OTLaqkZ4GrqaQJVoGBsqnKky2WoZ1eMPMlE
 uj/Y1/9e3Hf4McYl1Ei0B7RBDoX4GRC0FAn0Yf2CBwO5PjY2YMIM8QztXF80s6q1NLZ8D02KQ
 6U5IuNmef30R3FscUbMWRY4fUBiSR9/yKmzazpyHVEr4R8F9LTYKLBErRCsLOC5vY0hZEw8ar
 3NQ/UZ9RmGms6lWsFxT+ZwvlA/kIdiknUNt6d/rpB4Ak0=

>> Scope-based resource management became supported also for this software
>> area by contributions of Jonathan Cameron on 2024-02-17.
>>
>> device property: Add cleanup.h based fwnode_handle_put() scope based cl=
eanup.
>> https://lore.kernel.org/r/20240217164249.921878-3-jic23@kernel.org
>>
>>
>> * Thus use the attribute =E2=80=9C__free(fwnode_handle)=E2=80=9D.
>>
>> * Reduce the scope for the local variable =E2=80=9Cev_node=E2=80=9D int=
o a for loop.
=E2=80=A6
>> +++ b/drivers/input/misc/iqs626a.c
>> @@ -462,7 +462,6 @@ iqs626_parse_events(struct iqs626_private *iqs626,
>>  {
>>  	struct iqs626_sys_reg *sys_reg =3D &iqs626->sys_reg;
>>  	struct i2c_client *client =3D iqs626->client;
>> -	struct fwnode_handle *ev_node;
>>  	const char *ev_name;
>>  	u8 *thresh, *hyst;
>>  	unsigned int val;
>> @@ -501,6 +500,8 @@ iqs626_parse_events(struct iqs626_private *iqs626,
>>  		if (!iqs626_channels[ch_id].events[i])
>>  			continue;
>>
>> +		struct fwnode_handle *ev_node __free(fwnode_handle);
>
> Doesn't this need to be initialized?

This variable should usually be set in both branches of the subsequent if =
statement,
shouldn't it?

Please take another look at the proposed scope reduction
for the affected variable.
May additional curly brackets be omitted for this source code transformati=
on?

Regards,
Markus