Received-SPF: pass (google.com: domain of linux-kernel+bounces-90585-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 4 Mar 2024 13:41:19 +0100
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Lena Wang =?utf-8?B?KOeOi+WonCk=?= <Lena.Wang@mediatek.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kadlec@netfilter.org" <kadlec@netfilter.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net v2] netfilter: Add protection for bmp length out of
 range
Message-ID: <ZeXBb6dKL0GQe909@calendula>
References: <d2b63acc5cd76db46132eb6ebd106f159fc5132d.camel@mediatek.com>
 <ZeL1_-Pdq6Kw0NIO@calendula>
 <20240302115241.GA7494@breakpoint.cc>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240302115241.GA7494@breakpoint.cc>

On Sat, Mar 02, 2024 at 12:52:41PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > +	if (f->sz > 32)
> > > +		return H323_ERROR_RANGE;
> > 
> > Could you possibly place this in get_bitmap()? IIRC these are the only
> > two calls to this function.
> 
> How would you signal the error?  I think this patch is fine as-is.

Provide the bitmap instead as parameter, but this opencode variant
also LGTM, I am probably overdoing, we can take this as is.

Thanks.