Received-SPF: pass (google.com: domain of linux-kernel+bounces-90592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 4 Mar 2024 08:56:58 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Yang Shi <shy828301@gmail.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Muchun Song <muchun.song@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>, x86@kernel.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Subject: Re: [PATCH v2 1/7] mm/ppc: Define pXd_large() with pXd_leaf()
Message-ID: <20240304125658.GO9179@nvidia.com>
References: <20240229084258.599774-1-peterx@redhat.com>
 <20240229084258.599774-2-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240229084258.599774-2-peterx@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3ZLSK6vx0PuJjpwC/dtd4APjFbaUGZEh37Y/xzviyTSLoWaOoEiN58lBH5kP?=
 =?us-ascii?Q?Pk8+WRrvj6rrm8gFFi954quSjY9QYqA7h7nWqUALqMjoNbTtphBjz+oTXqrJ?=
 =?us-ascii?Q?3z0Mq3ML/s1rpqzUb3ZiFkzI7o18CVMZ+DoMDrExl7UZnInj2oF63a6GGAqk?=
 =?us-ascii?Q?F1xhb4VpLlIH4AYc2oR1G9T/Wn6pY8IFFVHOFYX8Pm1yZpim4j2a7eLd7Qz5?=
 =?us-ascii?Q?FfiorBIIYIg1XWIKm7jbtcz+OFGhOe1sHmMWsgEQfh1D+gJK9sqjT2OCnqPJ?=
 =?us-ascii?Q?kH6WEBoIJEvf9aQJ2XbwAmXu3TqkfgF+nVewyEVY78bIOdLdkHkdwT3ftKFz?=
 =?us-ascii?Q?IVQhlY5yebjqcYgmYiZqhA6KhpFnEZ920YnO5PMsbfNl33rHhEbCejMr+A2y?=
 =?us-ascii?Q?OguqCiuNiIUB3kAEYL64enMZMbruYrzFfGFoWlvcV5aGF193K6ox/Vc+PcKy?=
 =?us-ascii?Q?9D+KeaFV2K2zd5f7I33b9KAZhJ1xUmmUi2+xGpKFkLzML0uYCkzBPoKT4EYx?=
 =?us-ascii?Q?TQOXI/6oE1FImd2OrFBx9AbC7yub6OogDyWl+MT5Y2mrdp/vbiRn1UlSBdj0?=
 =?us-ascii?Q?Y7jeZe0mDB3LtUzeK47n0+kVANZH1thVznG+BiU5DaDpsGEaQ3LYcOk3ULQR?=
 =?us-ascii?Q?qqVUg0EWcMOm3N1DmbfDoBVNpReWs/m13MKZXiH/KSD3FnpXPsoWsgpeD4OW?=
 =?us-ascii?Q?AskbxW49DOPRPSaOfpRKp+Kp4Yhh69/aun0yNFYyf98VY1JfZ8Z9Q1ZobN/S?=
 =?us-ascii?Q?gn4EqYTqlLD+39fhqv+tzHt1mUTjz3tepW1uglYzGQqVutmIrzxmQpbTCdcE?=
 =?us-ascii?Q?QRMrU0UtRu23tQNz+iU3RGWFjnu5zXZ6ISDqtNAYbMLIZPEC2/owZCEMIzgw?=
 =?us-ascii?Q?+vKSQuya2KgplcAa8xXym5xW22x+xrI0xZRq2fZgZ/rI0aF8/Sl2/qGYA4c4?=
 =?us-ascii?Q?EzbxCaLvweKazRLkRAEEJIRCjXjOIxY0te9P9fDjV1VLUpoDqKPbAEyoks0X?=
 =?us-ascii?Q?KAQwPpVVwHY5gRlSJ0z8d71HMrFO2KKt2rQ8bZKyybdXBMYCt+HWyu88cD1V?=
 =?us-ascii?Q?C0adpyWbGPfYk41XbO/ez3NF+JzAr0UYDdPfu2xTTNqKk3OGF51aiA6NNom0?=
 =?us-ascii?Q?fX/FSikgQXkBQ5appEKjN7JE3xp/wCWaqMojr0seI+zeFDUIzabP5yOV012X?=
 =?us-ascii?Q?uSmVvZu6FgT56iNJCmSUO8TCRcgHPbDJPpR9dJowgInkarbmcdqPPXViLWgw?=
 =?us-ascii?Q?oXvaH3OtKLQmk943jeXJyZBoK+JkpG7DvaOg9TnKHwkMkI4xKJ2Wjexx/tVu?=
 =?us-ascii?Q?ryK6VmXYAgQTCBbNrmVI1FZccwkRgXaHzysoyujUHcpp8hgzzdxjMT5Nk7PE?=
 =?us-ascii?Q?024imH0ZZMXFUS2o2vN1Jf/CnRlMsjT8gcAcIb+3lqgw7LKxEcqTTJgQ+9Pv?=
 =?us-ascii?Q?Rpp+fOAPAA7SrR+Z14WeJylxDVlfGCUzMFTBcWjo3CrjVmwn3P1qHlqEHUak?=
 =?us-ascii?Q?O0CPrNfP4HKHDvgxPKual46xibEYcED/5cM0/9vfiK1uf7OkZfpdg9Q7X1et?=
 =?us-ascii?Q?Dos521BVeq/gJOcImKw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6c66146-ef2e-403b-cb0e-08dc3c4a9525
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 12:57:00.8576
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HlSYmGJrkRnPbpxhJQY6ZK/P4L/md3J0UZzKqPWUXzTaDqJ2CtQ64UmEJOHfuyH6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8102

On Thu, Feb 29, 2024 at 04:42:52PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> The two definitions are the same.  The only difference is that pXd_large()
> is only defined with THP selected, and only on book3s 64bits.
> 
> Instead of implementing it twice, make pXd_large() a macro to pXd_leaf().
> Define it unconditionally just like pXd_leaf().  This helps to prepare
> merging the two APIs.
> 
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
> Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  arch/powerpc/include/asm/book3s/64/pgtable.h | 16 ++--------------
>  arch/powerpc/include/asm/pgtable.h           |  2 +-
>  2 files changed, 3 insertions(+), 15 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason