Received-SPF: pass (google.com: domain of linux-kernel+bounces-90593-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 4 Mar 2024 08:57:47 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Yang Shi <shy828301@gmail.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Muchun Song <muchun.song@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>, x86@kernel.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH v2 2/7] mm/ppc: Replace pXd_is_leaf() with pXd_leaf()
Message-ID: <20240304125747.GP9179@nvidia.com>
References: <20240229084258.599774-1-peterx@redhat.com>
 <20240229084258.599774-3-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240229084258.599774-3-peterx@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?c9CoqiLC5t+9SYdqNC7Vp8icceCaoaaFlKPtWih6QnSReW2U8sIzSYCiR1xO?=
 =?us-ascii?Q?HIU2YxF2c/onTmRPEYAf1ogzX2nHxPP0ogWBOsbiwcXof6d95j5PylctdJ9P?=
 =?us-ascii?Q?nJmeTIYn7+o4f6k9mqk+yjMJUGCdZJZ5B1iiHC0xD8qRm0VsFcfxzRmUzLKK?=
 =?us-ascii?Q?mtLqKE35GIAsceMOnYxSJj+l0nlpQNV69mBkETpU/KU52RkMiV+LlUU7FKR6?=
 =?us-ascii?Q?49x3If4BYCifbU0V9sS2gmriy850rn+4J/CpvnX2tkoBQC9A9Wf3YmTZPPq7?=
 =?us-ascii?Q?BmvJpAQLGZ664bIUJZioGKktweUuEc5U76Gc5tAbVtnvjbK8KJn5UojqKG6L?=
 =?us-ascii?Q?emhqXS/FCa8arzrQdYq/HLB9X6MatcofLH9ItgmzzbpPoBb2wpVhvrpHctIs?=
 =?us-ascii?Q?iZlhG87r6R4zzZBQTk/82YY9JAN1EPjifIjaIAO8PknVbuLkFgZZInyK6AfU?=
 =?us-ascii?Q?+3d7RM8Xq2qNtRxLug1HNl7UUo9fXu5Va4QPXPccvueUtn3fHgSmxLKTYCua?=
 =?us-ascii?Q?zkNpObyoHJHcQg1X3m7ThQDS5TsiBZvU3ng32MFtc4QL3H05cMXdHm56C7mH?=
 =?us-ascii?Q?UCgQYfjGHXu7kiLB/hMv/iJFfDE6qBTxhupnyHIiui0+15hWXumqzevZ8p2z?=
 =?us-ascii?Q?gxcc9Y2+ZWrCtljK4WTuGPhw5cuDq8d/XMRosu6G+HyqEKb4enj3053FX/AS?=
 =?us-ascii?Q?ihfaST5VvP4VXelU2qQ3jgVOugEyiKjNBNYR4ZPUVCRnAFYD2VWk2sNcc2LI?=
 =?us-ascii?Q?1oe5M9wzDstfqo/1aM+HsOtV9QV2vLW0dAhWBFpfAj9fHTASSklcHkmM+Smx?=
 =?us-ascii?Q?e19JzU5nNPi5TRdsyQih2364d/R8NvgzU9c/wZ6L3AyCMCqzyday8lhGxgGm?=
 =?us-ascii?Q?7coiL7jeWsLehIRb95QTtwJsBjjZ4z0M0EFlBFSX4yQdOyS6xAh6ONN3BqAr?=
 =?us-ascii?Q?6QG3FOICj62kZ6thGtC6p962qPRXyWDuhdTcgUTxh+fuvZJS2ee2yMW7bYYU?=
 =?us-ascii?Q?h760dcBgsMODU9FtktISAnVDb0R/M3DYS2xzH218y7zIoF9Wh7QjwaRAtM5T?=
 =?us-ascii?Q?wu8h+uuneu37IdkW2/EOpZwFHHZedqmNR/yMl2uDrFb8tXF8wOXkDfLHgND1?=
 =?us-ascii?Q?axY8pYiCKK/GSmTUBqMaKh7PofxxACKUfYohst6T6PW9AvyZiJFtSiMHwNdu?=
 =?us-ascii?Q?65oNSIZ7uE6WaajfVOjvsufBg0qW7X7UeZpySwzS+avBwgzI8VFgQ8wynKCa?=
 =?us-ascii?Q?1GcJr47P8E8loBI4BvECKzLGdsOUw8s6HFpkDR1BmfUV8XMYW07TtT7eVhZi?=
 =?us-ascii?Q?b6LVzSdM7oJjN0PPQM+daCniFvOIFu+udwt1I0Mp+TASGeb3EQkiJ5JbzgXq?=
 =?us-ascii?Q?4UAxupOXsuyzqwSFTjjfbtwViCIthHWCd7IlWLWayN27krcuEZ2Tscb4NFhZ?=
 =?us-ascii?Q?KOnRRZjcwI+4rPr2Yrwk5I3KTSGEAUN+oLI5Gt7Q7M3qvOFm5S7Uaw7lCF1g?=
 =?us-ascii?Q?Y9MZsqoG2vioTFYMWVzIU9NOgI1XeFLuFbSXJK5poRVLo5gdxde+9wH5CXZh?=
 =?us-ascii?Q?JR/p3qyY5EGL1zYjqgs=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 243c78cc-2ff1-4f82-c8a0-08dc3c4ab1f7
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 12:57:49.1803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4wR2u/wST/p+GUEk5mAWELIiPbUorKDoavVbtlCgAv9XqWRTl6eHdQuWopgiYsjW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8102

On Thu, Feb 29, 2024 at 04:42:53PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> They're the same macros underneath.  Drop pXd_is_leaf(), instead always use
> pXd_leaf().
> 
> At the meantime, instead of renames, drop the pXd_is_leaf() fallback
> definitions directly in arch/powerpc/include/asm/pgtable.h. because similar
> fallback macros for pXd_leaf() are already defined in
> include/linux/pgtable.h.
> 
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
> Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
> Cc: linuxppc-dev@lists.ozlabs.org
> Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  arch/powerpc/include/asm/book3s/64/pgtable.h | 10 ++++----
>  arch/powerpc/include/asm/pgtable.h           | 24 --------------------
>  arch/powerpc/kvm/book3s_64_mmu_radix.c       | 12 +++++-----
>  arch/powerpc/mm/book3s64/radix_pgtable.c     | 14 ++++++------
>  arch/powerpc/mm/pgtable.c                    |  6 ++---
>  arch/powerpc/mm/pgtable_64.c                 |  6 ++---
>  arch/powerpc/xmon/xmon.c                     |  6 ++---
>  7 files changed, 26 insertions(+), 52 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason