Received-SPF: pass (google.com: domain of linux-kernel+bounces-90599-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 4 Mar 2024 09:03:34 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Yang Shi <shy828301@gmail.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Muchun Song <muchun.song@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>, x86@kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2 4/7] mm/x86: Drop two unnecessary pud_leaf()
 definitions
Message-ID: <20240304130334.GR9179@nvidia.com>
References: <20240229084258.599774-1-peterx@redhat.com>
 <20240229084258.599774-5-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240229084258.599774-5-peterx@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Yix7zzUWlmQhIuX1op0uRkhcHilIPZOpgmJnaJ9TIIkB5WMoFXMZxZY0r+fu?=
 =?us-ascii?Q?NjswBJuFDd4ywTS+FVpz3R2GKCtWkGarK38cl/RakSGlJE0DgLIjerESUdwO?=
 =?us-ascii?Q?1TrYvvRv0w+66Cna6ZizE4Wojax86v3o9enxY3bW+DrOC3lTkZtGxLWU+YFQ?=
 =?us-ascii?Q?XnPgHGhsaQqXMOST73ZGesBXA99e6zLskeXLrAZBzoXbJHElQr+p/LhHdpRq?=
 =?us-ascii?Q?ErARxtZgoYOXHl4wkWEpzoJZk2UD9mhHJDSRGQT/gKnozxa9Vi8j6GZmS34n?=
 =?us-ascii?Q?MJzbDEpsU+pfji6U/1wJU8wFFTi/YUHc35XCNj1DbPXEkhAMW7qir7AMfRK+?=
 =?us-ascii?Q?Cyxp7TpHHNuMln8uERlYKJMaIFZXa+JPwqI5QVkq7AcTRSauWE/1nKJCJrRr?=
 =?us-ascii?Q?CsuE4GEormSic+ojYZSADd/rfvB73Azvp7YOb7abd3OhhGgA5aWcsbdsPS05?=
 =?us-ascii?Q?aHadnRl+5qA1QdW36WpOOAgCqI4Xz06vuyXVPC88sX4KbkhHSC3dpEszQjXV?=
 =?us-ascii?Q?RWrGrKfdku/D2742D2Rmcu2UyfwiU2udMM97Azq3B/PXopVJXHFZO00r7l7S?=
 =?us-ascii?Q?2XpXvOc8saKDxuTrrW/5dXPQEG/l7x5wyZUsgGdj09noSdJNrOPrOT+wDt/n?=
 =?us-ascii?Q?QfXmorafRDlfkiqU7fqE3wraNq0gnRRqOA97JwSRk7WkwSIi2SHbpSj2d9Rb?=
 =?us-ascii?Q?EGBbVj3oy4frSLXvbefnDE7f2sHHzLtRVTjyJW7V+jZCDHBJjaomT42wDWGk?=
 =?us-ascii?Q?GqG//C6unWzIBQILqisy0VWZfQF55PgyYwxijZtOS4Em7VVIqCBtc+YAOWxG?=
 =?us-ascii?Q?4cFSuMjuGX7s2lh/P674rV6IOb2NPAX3HZDpcb84Qtvbcw+9KnieFhHGHnAf?=
 =?us-ascii?Q?+pdsWXbPGanyRFeD83rXfs4u27zCiEVFXExdk9Tr64M92bhjvLHjAqrvCSu4?=
 =?us-ascii?Q?r4KD2kLurls8vO5uXBnHgIh40FMr+sUyYSHE0AdANgZ83vjYgyqB8Bkf1qjZ?=
 =?us-ascii?Q?Xel69gL/RrjdXmBqQz9ZMkFg+sh9hv/jLi8z6uRZKDztOtbo1RwOXFO3+tk7?=
 =?us-ascii?Q?Nm/jVSP14uGUxsU5rtVgJQVAXvcUIy26R1tHrec5UV4QrtusSYoEEBM3NYGw?=
 =?us-ascii?Q?tMJs0RIKElVhshKUIbmLcDW9hZzpJD90i40A47M1hpnhJhtjj0qupQMlCl1D?=
 =?us-ascii?Q?seHQ+Ktwe3tNR2YASskNOA2hupe3SUjvuSjLiKs2S2buToHtoA4/BTfR3ukv?=
 =?us-ascii?Q?tmhHmexUDebQKohTp/Gc4qvW+geYgwnRn7Fy2UHH8L2N71YF78QcaBnN0Bw6?=
 =?us-ascii?Q?Uj1fRPJ4DA3OHPqZ6uRozGcFLoGBG+gpu91inJHxPfdRVOh0j0G8Ul7WqYCl?=
 =?us-ascii?Q?OJJsXWn8uggCHvg28f5KLzlGvMhQf3GHYEzAq9u2IIg+D96ia8hRdADdkCqX?=
 =?us-ascii?Q?eZePIkRMKiSO2C0ZZ5y1/n/E1qohh9iqQjfLcXtJlE5CRxJKj53pX1cV0Sd/?=
 =?us-ascii?Q?SpTzQR2jFLSmrQXWKvBhl0fYZczWF2BictbPhJU511nbFFo+zON2+YCtBjMZ?=
 =?us-ascii?Q?lCrsEzccSlHZaL3NWf8=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb166c61-980c-4b52-f026-08dc3c4b80ff
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 13:03:36.6990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W+huBfKBTuwXTWWd/f0PxQhar4UJV4imd1/2voIR3aQEF9FvsKr+IjNhpSt4yoH6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6397

On Thu, Feb 29, 2024 at 04:42:55PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> pud_leaf() has a fallback macro defined in include/linux/pgtable.h already.
> Drop the extra two for x86.
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: x86@kernel.org
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  arch/x86/include/asm/pgtable.h      | 1 -
>  include/asm-generic/pgtable-nopmd.h | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

> @@ -31,7 +31,6 @@ static inline int pud_none(pud_t pud)		{ return 0; }
>  static inline int pud_bad(pud_t pud)		{ return 0; }
>  static inline int pud_present(pud_t pud)	{ return 1; }
>  static inline int pud_user(pud_t pud)		{ return 0; }
> -static inline int pud_leaf(pud_t pud)		{ return 0; }

It would be nice to have a final patch making the signatures
consistent on all the arch inlines, it should return bool not int.

Jason