Received-SPF: pass (google.com: domain of linux-kernel+bounces-90610-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: John Garry <john.g.garry@oracle.com>
To: djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        jack@suse.cz, chandan.babu@oracle.com, david@fromorbit.com,
        axboe@kernel.dk
Cc: martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        ritesh.list@gmail.com, linux-block@vger.kernel.org,
        John Garry <john.g.garry@oracle.com>
Subject: [PATCH v2 14/14] fs: xfs: Support setting FMODE_CAN_ATOMIC_WRITE
Date: Mon,  4 Mar 2024 13:04:28 +0000
Message-Id: <20240304130428.13026-15-john.g.garry@oracle.com>
In-Reply-To: <20240304130428.13026-1-john.g.garry@oracle.com>
References: <20240304130428.13026-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?gwg59AP0HP2z5S7qPXlgRcd7fo+7mZDP9l31ldrsDc36aPrB/HxY8px+Y80T?=
 =?us-ascii?Q?DpU2XGVxu2y3+wuaRtnPvU5R8jbRipX7r4bRawhQUGL4Hwo1OwZuojNQMx1P?=
 =?us-ascii?Q?S+o0LBGipFuejhuazjcmSYXP79LG+fEKu9ekpAbtCo+leOwZKp4frEyg7rHl?=
 =?us-ascii?Q?+AE0tSkp2Yaw+YEFUzonyfdYeqxooAEWdJ/C3ebBjbuPPMXT75XA0ByPmqgz?=
 =?us-ascii?Q?5YXzBNeeYKj9Gr1EGR3YUC1vMYUYEbzv1zsLqVkRGn/0/65Dqmn9DiVV4HrM?=
 =?us-ascii?Q?3SUzmq1H+s/waTP98XeNn4IYuQrn6++1LLZM+J3Q5lYQRabzFb3fowSarjWQ?=
 =?us-ascii?Q?blmSYf/77TAZWxwGKBhlLAUcZJbjuc790oZTxRxqHHNq/cyDxAKoq7UWl4jb?=
 =?us-ascii?Q?fIgsWfLSlsofAv3WLklmlY9RPu5SRND4h031XBdmkXIP5iSz7j/yEYShgwsY?=
 =?us-ascii?Q?Vus+rwsG17cTw439Jr3PfylgVrKT9Mwyvs7SauMQOKe2M5EZe8c2wl4WPMTr?=
 =?us-ascii?Q?vlBL3Q+exd/FDmsk7WtJiwV3SNHZmxVlnyCD9VbsK7IG0/J7ixDTNvYTX6AV?=
 =?us-ascii?Q?U8SI+v5N3x8kSkAUtU0d7OThmZ79aFcF3ww+m5XcQyeUv8QP8KSL5AS1wOC4?=
 =?us-ascii?Q?egsPGm/RHd8HSQrYEy13ZjHpFcquyG13L0zct7IW8oXlue4dAEA2ffVDmNlt?=
 =?us-ascii?Q?a9pH+ALE5SIW1y6nEMfV7XLqEgpsPUf0Yt9y5uxMw+6G+m2V+eOgGNLYy2yt?=
 =?us-ascii?Q?GEPtMtRZ5sTkVi6TpvZd9N3ueJO3j2l1BU8FjAXhTYyTK2szhs9EsGibwIQ1?=
 =?us-ascii?Q?cT5Q76geQKY2KMUkb0K2kCp3DdbsOKbCBQj/JN73jy1rtTy87O5smt8812k6?=
 =?us-ascii?Q?8MQzcATgXUUjPyDkzlwg/7zMfrIgT66eh7XY/n2eFa+4FMfLVxhxU9FTjiFb?=
 =?us-ascii?Q?htVmsDilvDokq9OLqwfcLIUTuoAYU9LMoIpmcwTnnhcfusitTUh6vm6ksPpJ?=
 =?us-ascii?Q?mRIEd45EaAO4lgIcOveEtefSL3OCQYp4rvyCBioQlKtVVNgpP+zM4l3ZUSAJ?=
 =?us-ascii?Q?gDW5bHequUzIb9dS+WMeCFfoO8SZa/EDlpDJK8Q5nzlf6aQb1T6wxuziA5+p?=
 =?us-ascii?Q?Gb/yDung7KS5O7/5zPRki6+I7PaO1RTdLSHnypQ+nIZdFMgyQtir9aI037ht?=
 =?us-ascii?Q?XSCOAqt9gorT5COeNMhXL55McYOOaS+Sm5YYUwXv6vmcYCbLUTYx/an9Uu0U?=
 =?us-ascii?Q?HBWCO7jr41d9+ioViKjRoy3utBCUFarowHXQmUwz46hG3gTkkgqkj8c5yTY+?=
 =?us-ascii?Q?31KidgCXFVTq/LsRAs0kP4Wxv3Mqj93u1k3v1Q6S248EpSW2xjbt/H1/8hP3?=
 =?us-ascii?Q?ve2vplXGVWy9MLlW1iv7Eae5vqmaIuNfsiazru1Nsdw8zpJufjFP9paO9zRh?=
 =?us-ascii?Q?IvMws+hbBlImaC//sD7k648dMRcoQ14+7x6yZ7/ZDhiwM5JHpJIq4ldY7Wd/?=
 =?us-ascii?Q?QG11NkHKlC32ssmXJpHf6/dLlqJeZv7xFjnwjXzLlU+ov1XmJ6lwasWcvhoY?=
 =?us-ascii?Q?rl9+qg1snw+3Q+xzL5gsjtC8Dki3j0WTGwIwsopUWNXJx4gAaeH0BsgmbCJk?=
 =?us-ascii?Q?SA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	NS7S2K6D9rTLiuOKkjJG3HnFUelKdiwkNwnkOqgluA3IS4QxZROKkvKen0+tQbj5z1NeNlUOmn4vbt33TDnWZjp26MWFcw9tOwWNYkNDlPDcDPalrGplEu+JwxIQ4Ve2dh1GS1qZ50YS1zD9giTZMHuHS2CICTDQ0xiI+r0asUC2fIlpCrd8auKjaa3pbewb9QuTHafvV+BwS+d399u+F5ZiUQwCjGn9JBOa6MKv53Woo+4PUlRNf3Wl1gVbojQgCfYuW/UbW3Y9OiRyn1vGekm7UBgkvJlz2u+wFRaSiGhQx9aZkvVmqi1TO+GDcYScGraIEkW8MBbvBYYwhOl74+pxBrINy2eirS9FA2gX0BVNyUbLH9lRGY7h0C0QFwJBYALIfxwE8Rm4KpBSJnBzoJWMc2N25Jw44tipZ0FPFWaK0VxGG1mEWZC+8W/MiYbzM0ELa/jhgnAgp7inJBSVamOekK6S8oLen1znr44GnWEC+L3vBCYgSyNCuxiqYpHPKUmqrHYiwOAd81QsDrG9YwXB/uMs+QE/52bvMZixXX71nJROf9RzI5x9SPgx6VnxA7oru/4R9iFmHCQw6CfCj5mLJQaOktMVhcUUca1D7wo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a610abf4-5fa2-41bf-ec84-08dc3c4bc320
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 13:05:27.4821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EXnc4QBlczFqCAxtfRrenSOSc24a4GQoxm0oziDsLi3eRdnz4ad8ooFckxitTpDvcSAr/iNz4/5O8iHPAHw1/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6860
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-04_09,2024-03-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0
 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403040098
X-Proofpoint-ORIG-GUID: PJYtT9aPmANXv9VyL6IKpufYRqwz0rdx
X-Proofpoint-GUID: PJYtT9aPmANXv9VyL6IKpufYRqwz0rdx

For when an inode is enabled for atomic writes, set FMODE_CAN_ATOMIC_WRITE
flag. We check for direct I/O and also check that the bdev can actually
support atomic writes.

We rely on the block layer to reject atomic writes which exceed the bdev
request_queue limits, so don't bother checking any such thing here.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 fs/xfs/xfs_file.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index cecc5428fd7c..e63851be6c15 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1234,6 +1234,25 @@ xfs_file_remap_range(
 	return remapped > 0 ? remapped : ret;
 }
 
+static bool xfs_file_open_can_atomicwrite(
+	struct inode		*inode,
+	struct file		*file)
+{
+	struct xfs_inode	*ip = XFS_I(inode);
+	struct xfs_buftarg	*target = xfs_inode_buftarg(ip);
+
+	if (!(file->f_flags & O_DIRECT))
+		return false;
+
+	if (!xfs_inode_atomicwrites(ip))
+		return false;
+
+	if (!bdev_can_atomic_write(target->bt_bdev))
+		return false;
+
+	return true;
+}
+
 STATIC int
 xfs_file_open(
 	struct inode	*inode,
@@ -1243,6 +1262,8 @@ xfs_file_open(
 		return -EIO;
 	file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC | FMODE_BUF_WASYNC |
 			FMODE_DIO_PARALLEL_WRITE | FMODE_CAN_ODIRECT;
+	if (xfs_file_open_can_atomicwrite(inode, file))
+		file->f_mode |= FMODE_CAN_ATOMIC_WRITE;
 	return generic_file_open(inode, file);
 }
 
-- 
2.31.1