Received-SPF: pass (google.com: domain of linux-kernel+bounces-90594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 4 Mar 2024 08:58:24 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Yang Shi <shy828301@gmail.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Muchun Song <muchun.song@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>, x86@kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2 3/7] mm/x86: Replace p4d_large() with p4d_leaf()
Message-ID: <20240304125824.GQ9179@nvidia.com>
References: <20240229084258.599774-1-peterx@redhat.com>
 <20240229084258.599774-4-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240229084258.599774-4-peterx@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mLfXtoYkYAKc/vX/S6X/KkoGhUrVU0YibyhebyGU0e+64YOJ9gw30ORKVECt?=
 =?us-ascii?Q?igvabsU1IvOZqZqfNJ7TDj1H+ZZ1Bj0gAr4l7ppNeYUMZApN8ewGFMSO5ZGs?=
 =?us-ascii?Q?HmkjiUC/b4p3fRMs4BVRUttPcm9vRMNreLkJvxy+IF5k4/Xh9GZ659NYh/Ne?=
 =?us-ascii?Q?uiBc5ikJLEVdudQATp3ouDlHB+HSw+Ey/AE6bjLMy1f6SNv8vQMqXdBGKhu3?=
 =?us-ascii?Q?jzO96lCnQCwBmGJcXbjt/QOrkike+LinFgRu61nFVGPkjl7gNmgpDCG0KLw3?=
 =?us-ascii?Q?CUzjLKDSzWuywjTzSPLfIm2DWpSCzWCCB2vsmT1xHaGK+5hX7Hn1ufMg+XMe?=
 =?us-ascii?Q?8LNPR4vGF99uDGj7ZWwqwRIj7kidOFBpaylulWFInueZW8t+sp813ZRAeIjM?=
 =?us-ascii?Q?PaOShrzsqKrz9oJuTDPd3HgDHhR2nzxkFM5uEhSPmMkKX/EGmLWIkJNxy6KU?=
 =?us-ascii?Q?i4zP7xjGS7HQ6CZF48cNdLVavLhY3F5w1vckt+6+JERS65ckPl7rd48KZas7?=
 =?us-ascii?Q?/+to0catgTWyHOAZ45yPYh+qPeZfDJuWrsJQ5pnprjOMxFBQ+V5P4iyhbB0C?=
 =?us-ascii?Q?TUQBKFv98c1AT4b0/pvCEVKnrlJqMurlBrt8xwpWSdfvi/57lqrEtraWMK/y?=
 =?us-ascii?Q?dSL5veTaVo7duGydWAFIH5isweUx8ouu6qLYvQvufndnuRajqMSRKfyy38gF?=
 =?us-ascii?Q?D76q+WXpcTA0cZMbf3jduzcVOk11BqpNFyQEen3ZmHeDwSkya7wqPS2JV2g3?=
 =?us-ascii?Q?fkB3kDfk6wS+z750SdsLNUv16n4yd/BlLUkACEtms0JHN90aQxB+AmqJkAy9?=
 =?us-ascii?Q?yk9bobU7M6bic+II2s6ufU2EDkcf9fOs+RoW1fUizzxgH/YsKl3Lb6JmrbAJ?=
 =?us-ascii?Q?/eOaSt7If9L9HlGk/hs2GQoCvab1JznexS3X8CT80Xqn/NPhvXtJ/QOlu4cN?=
 =?us-ascii?Q?QMoGQyXbSBJ+W73fJlUZvUkYYYmE1Y/mBqvSR/C1xRmfEh5rPV1Ty649MzDm?=
 =?us-ascii?Q?V1e67n+taxWpmkg7UDG4F6N330qkOGo6fF/Vm9L9M7F9GQ/3qQgITrYKgLNw?=
 =?us-ascii?Q?a5g0SFRPMkl87rUQoTeJ0EIQnnnI4U3vsxnwtQgJ84pxBMzaWn8bHfngDLUV?=
 =?us-ascii?Q?CXrABR+GWnWi8xDGnTDOYjyWRF6YcZ52+mkg7MCwxf06jPmExhxfGEgaLy0l?=
 =?us-ascii?Q?Kd7obqAV3ZpdLCs9emUram8+Ov3pEwmAeePQCFpFcIzxY/SEG1C+zjf3a2o3?=
 =?us-ascii?Q?/JvZjZcdyJdLbivoblxk6jdBeWtZg053A/5xWek2fC/TUGCjFrs9DgFJfla9?=
 =?us-ascii?Q?YXIKvcs3WlDP3cE7opkpEOWoxh4DjvnvfgOPfbItqmKtHHoiCZbdJjOmWwPk?=
 =?us-ascii?Q?Yw5ILbxEX0EHNruY2CJFSf8kNrAH8+wjCv5522QbS6INVT7xJy3owJ8E+5om?=
 =?us-ascii?Q?blW39CTmaeDCeIbfnMK03unyYF3nVDW6gYyBWmmuLwYevbQy2D+yrJ8JO3ax?=
 =?us-ascii?Q?kcORbsw455iAaOK8VosY++2UeLY1uX3lEquLeYONWBB3m2Hd7QvwxIqRg30x?=
 =?us-ascii?Q?KB1MbWb3qRcdtRrXkeE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80b38d0c-919f-4958-c623-08dc3c4ac818
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 12:58:26.3260
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F/+DyZOFXMNzHUc6ncTApWUU2iRseFDLz1crCiY/7JRTXu6WFUJKahFK1WWAfUjR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8102

On Thu, Feb 29, 2024 at 04:42:54PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> p4d_large() is always defined as p4d_leaf().  Merge their usages.  Chose
> p4d_leaf() because p4d_leaf() is a global API, while p4d_large() is not.
> 
> Only x86 has p4d_leaf() defined as of now.  So it also means after this
> patch we removed all p4d_large() usages.
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: x86@kernel.org
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  arch/x86/mm/fault.c          | 4 ++--
>  arch/x86/mm/init_64.c        | 2 +-
>  arch/x86/mm/pat/set_memory.c | 4 ++--
>  arch/x86/mm/pti.c            | 2 +-
>  arch/x86/power/hibernate.c   | 2 +-
>  arch/x86/xen/mmu_pv.c        | 2 +-
>  6 files changed, 8 insertions(+), 8 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason