Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1826677lqg; Mon, 4 Mar 2024 05:15:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWa1eaN5sXNDQtDg+CnWYZdKBi7u2poezin1eESMXB/hB17C+60jliV5kHyVQj4XFgEn1RIwDqAyx+cc25xt+B5nKAk8Ef0OOMIdebZCQ== X-Google-Smtp-Source: AGHT+IHwKbFbB7oay7U1nRLRN+Q6lbNscSVPgnTSeUAU8VE9T6Wua7wLzyeQnFXRbWASXVPACUNY X-Received: by 2002:a05:6a20:2d06:b0:1a1:2d03:f651 with SMTP id g6-20020a056a202d0600b001a12d03f651mr5816297pzl.21.1709558143299; Mon, 04 Mar 2024 05:15:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709558143; cv=pass; d=google.com; s=arc-20160816; b=Pxv0XB4mmz5cv5kIPM4hea9mU1+oBmKn0b6S4kxap0zC7DooHVKt27jJBhfoGwGq20 +nMoIVpQNLdquLEiDxaqJWfZBhH9axIy9QteEi5BCWcukw+rzpXnp9HKfrIee9Csyq8P 62gNJCNm4PMMksboB3PYckghNhh64bo8EYJAqgay0Am9tQQQhDbvyfOH3g01SF7VMvIH rEpBU2TkroW+UdKQmDlLl05FOWV5JJ8VwdZV7Ur29sbrOBhSKZBfjYDaX1w+bF699eaW 9CYdmO/NX8APXX4hP9ir1/OI8ZYti3dTDX02mRLp/IqlG+s+UBBLELucMcV6yzR1fcw2 Yjng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=8rQDbUg4RJu/7k91VfbHeq15VU8NDHILv/3Ta8lMlPU=; fh=7DoC4csp3iEP2ApB/PQFW5VyCez5wC4t5hJ93wh1SB8=; b=g/W2uCY8pE2ncHacrCPZcBQNE/VUcoSjvkdLwSosv+n3Y+UO1hDqxm5IUHd7UyXAcV DHvkiCQhCKvi0r+igW73IahNB0lesYbIonBgQiF9uWQsQdcCp7hZ8YZKLl26QWOh+smc pPQrEbE7v9gQ4t3XeLuxGO+3fPG0loJUFtVz0pYQRLFgDzNnPWiBpl6zpFaTigj1eO3l ERPkjA6oo2amdZFSNLXJZUmEoOr92B0W3z+Ly3u57U8/p3qDskWvkjYD/UHaTPCtH79d MYHCjf3n1rtLNn9fTd9cIhT+yHoRy/6XH9elp9gyMWDzy6pr/ilvH2cBWNRvN+zDng3Q eksw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@codewreck.org header.s=2 header.b=J775hL3H; dkim=pass header.i=@codewreck.org header.s=2 header.b=FPwlQoLT; arc=pass (i=1 spf=pass spfdomain=codewreck.org dkim=pass dkdomain=codewreck.org dkim=pass dkdomain=codewreck.org dmarc=pass fromdomain=codewreck.org); spf=pass (google.com: domain of linux-kernel+bounces-90597-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90597-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codewreck.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h27-20020aa79f5b000000b006e5ad30334dsi6891853pfr.69.2024.03.04.05.15.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 05:15:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90597-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@codewreck.org header.s=2 header.b=J775hL3H; dkim=pass header.i=@codewreck.org header.s=2 header.b=FPwlQoLT; arc=pass (i=1 spf=pass spfdomain=codewreck.org dkim=pass dkdomain=codewreck.org dkim=pass dkdomain=codewreck.org dmarc=pass fromdomain=codewreck.org); spf=pass (google.com: domain of linux-kernel+bounces-90597-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90597-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codewreck.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 67A47B25237 for ; Mon, 4 Mar 2024 13:03:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C5ED33D56D; Mon, 4 Mar 2024 13:02:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b="J775hL3H"; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b="FPwlQoLT" Received: from nautica.notk.org (nautica.notk.org [91.121.71.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 829593D542; Mon, 4 Mar 2024 13:02:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.121.71.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709557375; cv=none; b=U49Fg7Uu3GC1pyVbMLUH9S2knRsYvxhD956dKBjIoqeYRTgAG/zVl3CzOZcgBwnPWUoHFo3u4cvd281WvZFbNxm33VVPEMZWHoT264J7CqR5k0EKHNY+Qq4kBEZEFtE5GBRiMoVEA/3Xr6afTjeQJcqMugVR8SwqhKPGOrT271Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709557375; c=relaxed/simple; bh=B3K21OgLoz1W5sfrl2E27+1K7ioRlos5ZCdVDYriGdc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PhpjWOzOlG1tkPfGG8/U1i/c+LPPQFGo1euiBoxxWP8IrUy+kO7vcNXc9sVipZcEsbtJXP2pZFkMHSLNZhXVzIhX4rJy6yH2weBjWOyW/AWdnCzQSp+0QEbSC07qgwbhke0D54GjZN/DCCOo9wx3JrhAAkxO+sYC0fgpU9hULGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codewreck.org; spf=pass smtp.mailfrom=codewreck.org; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b=J775hL3H; dkim=pass (2048-bit key) header.d=codewreck.org header.i=@codewreck.org header.b=FPwlQoLT; arc=none smtp.client-ip=91.121.71.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codewreck.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codewreck.org Received: by nautica.notk.org (Postfix, from userid 108) id 2D2E7C01A; Mon, 4 Mar 2024 14:02:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1709557372; bh=8rQDbUg4RJu/7k91VfbHeq15VU8NDHILv/3Ta8lMlPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J775hL3H666TqcYafAW6nPLUlBwCi5BPIgQGaRMNENlN9ZxRMIl4NkyE6828ENO// 3UtRFgfqc9kjt2i0et95Y4VVq/giBtAAqVlITPkbgUT+MyI6TcQ8F5doWclmzbOoZ+ 0j2CMxby+i71kzPIaeJXMC+MBUcq+/kSIHLIwiJ2HgFKWBESfh7mUO3HtOkWPE0R2W 41TiYBY2lgkV9blyfJMkDwmkEaBGjWwp0xkZSfON7dHcJOsAYLaT/X41ADHHZ4uidh q8+fD9iKBYvY0YyYK8pNZsFZHCnW/jQaZkyKzxYH3C9rM8cABs54cXIuRGUuq6o0ob BlFrLUNw4MYuA== X-Spam-Level: Received: from gaia.codewreck.org (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id 9D91BC009; Mon, 4 Mar 2024 14:02:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1709557371; bh=8rQDbUg4RJu/7k91VfbHeq15VU8NDHILv/3Ta8lMlPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FPwlQoLTbRX1K7l+u0Ctk3mgREi6ZbFt+BJ72Fkor1L122gf3OZtU0UmEzyX7GIWd QnCtvmqLNkbq7LqoKcptWW0WXpnWBcmgTuzGn/ykKgAlQZJW9XS2pzfuA/4hLwIWwN 3gKlMKl+GS2Szu+gfg/jns+UTybgpmhTR37r8ikiqZF0fvPjfxQsLf1bVuvzghnH+M wqZvuwOTQnGYdvZOh9VuUIDGWfOcWK3bSBJ7qj+BaKIi+Corxg9wWvK6l+bicANhhl U4cpe3/ohhioj5HUh2Z2yQwOfpPxUghBAO5Cr9jwFKZg6sPk2lU5j4OGy2+rZGEBQ7 TmaANxm+Yf0Cg== Received: from localhost (gaia.codewreck.org [local]) by gaia.codewreck.org (OpenSMTPD) with ESMTPA id affe790f; Mon, 4 Mar 2024 13:02:44 +0000 (UTC) Date: Mon, 4 Mar 2024 22:02:29 +0900 From: asmadeus@codewreck.org To: ericvh@kernel.org Cc: Lizhi Xu , syzbot+7a3d75905ea1a830dbe5@syzkaller.appspotmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux_oss@crudebyte.com, lucho@ionkov.net, syzkaller-bugs@googlegroups.com, v9fs@lists.linux.dev Subject: Re: [PATCH next] fs/9p: fix uaf in in v9fs_stat2inode_dotl Message-ID: References: <00000000000055ecb906105ed669@google.com> <20240202121531.2550018-1-lizhi.xu@windriver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240202121531.2550018-1-lizhi.xu@windriver.com> Lizhi Xu wrote on Fri, Feb 02, 2024 at 08:15:31PM +0800: > The incorrect logical order of accessing the st object code in v9fs_fid_iget_dotl > is causing this uaf. Thanks for the fix! Eric, this is also for your tree. > > Fixes: 724a08450f74 ("fs/9p: simplify iget to remove unnecessary paths") (careful if you rebase your tree as this commit isn't merged yet) > Reported-and-tested-by: syzbot+7a3d75905ea1a830dbe5@syzkaller.appspotmail.com > Signed-off-by: Lizhi Xu Reviewed-by: Dominique Martinet -- Dominique Martinet | Asmadeus