Received-SPF: pass (google.com: domain of linux-kernel+bounces-90602-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: John Garry <john.g.garry@oracle.com>
To: djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        jack@suse.cz, chandan.babu@oracle.com, david@fromorbit.com,
        axboe@kernel.dk
Cc: martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        ritesh.list@gmail.com, linux-block@vger.kernel.org,
        John Garry <john.g.garry@oracle.com>
Subject: [PATCH v2 02/14] fs: xfs: Don't use low-space allocator for alignment > 1
Date: Mon,  4 Mar 2024 13:04:16 +0000
Message-Id: <20240304130428.13026-3-john.g.garry@oracle.com>
In-Reply-To: <20240304130428.13026-1-john.g.garry@oracle.com>
References: <20240304130428.13026-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?ZY+bJBlF+6kX4ZID/cc3AwvPyP/oDMzh0jaR8APAGdNPGaKxf1utb3nD1p6h?=
 =?us-ascii?Q?E1Zlr/g13dIwi8bBU9HVt62J46QVV1fgfLvOcHmPPo3kJVGfxCv/9GdzbNih?=
 =?us-ascii?Q?UA8H9R49KNVwnwYO8XlRVB/7VcG4r8sWD1hyKjmkeV2uNv7DjYDSFR0tGgml?=
 =?us-ascii?Q?P6KIPeAWFl/kk2SmpO8o2np4D4nEm8mCPsYhscNYEjL7Z2d8bPGAnvq0rrhO?=
 =?us-ascii?Q?oEvRS6PH1VzwqVOixvbWqsRDN1selVasMzpLoYyRfDKsYGDLPEJNoX32mA75?=
 =?us-ascii?Q?p/loeIZU23ngHRg+HSjaSv7qLfTM07gfJwmcdCfwl6QdrhKs+eHNIFlNHQLB?=
 =?us-ascii?Q?LFccSIk1jcWPWOA60lWCjklLD3rt4JUWOpQP7IqNjhzjLuDkznQCKNDAc/oI?=
 =?us-ascii?Q?pGv2xxLh+EZsD7C3T/XFSU27TQ6GMhKl1lcgZei88n87HBSQsziZvMI7FqJC?=
 =?us-ascii?Q?rryV0dk26UMCI5V/2s0W+ur8HusIXTchxWNoUY/qPa7zBEz3ZUFKFWp8nBL0?=
 =?us-ascii?Q?fCXEsHd7vRxQie94PXgIGgUcLMNbxWWuFe//qu3psdcJr38PglrSNkTCASOG?=
 =?us-ascii?Q?ia4fT+ygtGIGVoV3gNV0MA6UxgtdNIOdQ/UULvnbb1/l+/Zmfx3/zcOMsv2R?=
 =?us-ascii?Q?lg7Voth4I43NXUguDiS4sKcU9ZBbvwAb4s0C/T2TY2OyyYFH5vvcw9bTAgID?=
 =?us-ascii?Q?KygATu0FxctKuRfiPSN5j1K2nyRaHWcadtkl7YXKXL/0tbM9qn+NeH6LbsaQ?=
 =?us-ascii?Q?Er92JDDqszRpKiPFsszp1P7/vhKyQ9EYHHX/WfK4hBHQdiWOSf2+kCJUmVG2?=
 =?us-ascii?Q?xd4I3+lnZJ0YFxSSs/DmIVfrYdjHcOlsKinf1StH/B/Mct3jdPtLEPhoYz5S?=
 =?us-ascii?Q?P3uXiUrvX5xzmylSzg8y4gNBWrIfLtjagk3Lg+63JhhiTDbt1WMdmxPC0I7F?=
 =?us-ascii?Q?/clpD0mJrAT8BQ1z5P1q8SYNc+/8dtEScE+W/Y8aL3TeqyW9t6Z4q+yLTulr?=
 =?us-ascii?Q?oYt4AyKxe7PC++Hm8n4ZZWXIhpmHy1UmCi2mHW4CeoRsOMf1/lvmfwC1ce12?=
 =?us-ascii?Q?YQ/tWuWydlxAtYQ0vT8ugY9zxqBrx2u2MCqAKvg8KYB+4L/exhZYLRQHzh/d?=
 =?us-ascii?Q?UExQFt0rC+rQsZr9VSnac61r64PdHMzD2Mr+jZfo/m8wW1/HmEaiEz2QiHBg?=
 =?us-ascii?Q?1nY0spRhTtK0rCsj7A6hz3TZj6B0cuAuBq/Fp5MzKjARyI7venTPafteXSnv?=
 =?us-ascii?Q?k40CivwtOBzebsny5FT6ZUX7O7p/CGI61mO7yFs/dUcWPSwBT57WbivzlOwo?=
 =?us-ascii?Q?ZMIs2Y3mt5A0C3lki396kSNaDGml664BVPBYB43LFdLk5z8X7j6v8nxuR2AQ?=
 =?us-ascii?Q?nWf8vj4lHP9MsPYXqONSluq2zpj9k0IxQbOxRR+JzylFBr7CZbNaTvtErgCT?=
 =?us-ascii?Q?Apzc1U40qjSIEoGZus5nS/0MvLw0Iz9Opzphi7mLKQu0hYZAERIGspOPhXvh?=
 =?us-ascii?Q?VGNKw3Pai2Ui4J4P6VstZIM5gB/mecO7h7LTDFMTXcoIbAXxPmaDVanlUQ7y?=
 =?us-ascii?Q?PHuReKFKbSAuRD5k5fIXwyPIfpbwYUS4qhqIt8P8RD9dm6PnhABnZmHfh3EZ?=
 =?us-ascii?Q?fA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	XKB1rnHjq0utvPD3Hg5f8kS8njzw3DvB0dHMAHw6GGp6UwLClB/pGRnfXCCW0i7Y+NdR1Xg+9PsiH7vR9AdzOJeNaYO9VPdfNmLNj2ctXRZHKKCDYu7bwGidxi2nzAopus2O53TJofQpO+iYPllpx4k2PL8qFPla9qVgGBJD+JyELMKZ6oCKzqrvvUXcMyFisF26gDPDZgXpsY7a/DgXAlW4+f/iIOao6uiqDdzDX+bK9QHitSYwG1rzM/FjbdaQoIllCZv2DySIWslUuc4VzZb37cEs+98gZvvB6g+8BrMW3T86Eey1eySEXsI2rbGfXr7x7l+rc9tUW7PqPKYwLVpxU79Qfltnk5MeYFoty8DS44Whtqtrxavo5xSAGu3kFzNlbKuk12JJ6/2paAiq+zdQcMctfbPlgyGUeP0lRKvKWe1CwFtvPKeLgHSPFlg63C3WPuhS0rCXm5Mqp3Y9hOmuKJ7Q+S+ToCljQBg8Qyb0I93F6KjhCF09ER0C29Hd9qP/uadQlzVKnijOlXERoBovPLVLcAim2h2NZmgeBEpQeR8rIGHUPiwnwmIlBUB1XQ3aNsnR0OONyK2R15UdaGpU9jnIethvhZDGgmWzVvs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33106870-0f6a-4a65-dfdd-08dc3c4bb396
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 13:05:01.3906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w9KDo2KfYw8ny48PSQ50AQk5qNJtLU3hBzQJusz9hUqzuhr0w27BRAV/cbRqzoCWBdHI/NgA0MbSTedBnuDTBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7805
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-04_09,2024-03-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403040098
X-Proofpoint-ORIG-GUID: 2wqFaGHbUswHckFaghkkHgiDsTaNTnLn
X-Proofpoint-GUID: 2wqFaGHbUswHckFaghkkHgiDsTaNTnLn

The low-space allocator doesn't honour the alignment requirement, so don't
attempt to even use it (when we have an alignment requirement).

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 fs/xfs/libxfs/xfs_bmap.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index f362345467fa..60d100134280 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -3584,6 +3584,10 @@ xfs_bmap_btalloc_low_space(
 {
 	int			error;
 
+	/* The allocator doesn't honour args->alignment */
+	if (args->alignment > 1)
+		return 0;
+
 	if (args->minlen > ap->minlen) {
 		args->minlen = ap->minlen;
 		error = xfs_alloc_vextent_start_ag(args, ap->blkno);
-- 
2.31.1