Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1832297lqg; Mon, 4 Mar 2024 05:26:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXvJfEQRf1ggX8Uiwb3ovOCfyN5lJly9BitGnxCZPq8sLdW7HZYd5FENSF6IdM1bBKSzxYDP1M8IPB/GEL1LdIuLlOY3fkh4vVvBkTxdA== X-Google-Smtp-Source: AGHT+IFx617Rf+vIsq80g31I/pAi7xdvVECHjv8KCjwLS2nFigVTtgLT+sKnYjteaYsANDl4l5je X-Received: by 2002:a05:6a21:3288:b0:1a0:9ab5:1e83 with SMTP id yt8-20020a056a21328800b001a09ab51e83mr13042614pzb.24.1709558774902; Mon, 04 Mar 2024 05:26:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709558774; cv=pass; d=google.com; s=arc-20160816; b=kVlX4QNGUjIkt3zAuF6UvVnP3V27X35DTAc9D8+5uaFHvDPchiMDXOXCcaXh9VUT69 ApV6r0mIcFgxGgA8U9p69bfw7bxcujsp/bnmbhrY1w85+xlkgmY8+/kXE5Jvj1xE/ilF RL7iuHVVAQTOBiEz/wtoJAaKGxcCUSXPwzr0xAlCZxF6eP2ZWk/0zf4Z3kb4semH4nMc fxgwufEPaJz6H/WPAP+4vjNQFpKJMIhiK12gV2EOXP11np91a22wJhcuHTIMjQLgyPDP zg5sIVXesBxm0lZmkg3zpYPi6J8D/Oj65FPTmj7lee9rD3YAFkR9HoJn4/N52cfPyMaB gc0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=1v0A7i2+W2cHjoJY6glR5gGnX34Ee+tCNN+/JkQeFN0=; fh=+3YdNmHfhYtmX+NNk3UnstDTmOs4XLNfgA+EtrwEChw=; b=whwvuFTpnkCpMGNF7fB/NDzG3bCJMBZPamF+uvoESB1A148n9cHGBMzXopRzKpsPWx CECqhXcJixcWuK7ESyy43zSaCC44J1Hf+7ZTdSL3ABm4gN7dmESpmH+l/NEH/YwjQlhj XRFlko6ZYlzNEuxkY6bUt712a3bHeAN2/0VrGmDIfSF02TUBVZuYoZLIfaekPSuFdKy4 QpAu71X+AOVu8rYzIwI7YpAoscFpLleauVjgFWaSn45LIDeHM6BZRlTb3lPgugyXPAFB pCiGVe3sF3DQ5F3Zg4RKsmsgc1b4LjGiME1Pa7IQQqh0ZpcBb6iHnssID+8GvY1ZlLxS ZA2g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cPWl5M1Z; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-90641-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90641-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s18-20020a634512000000b005dc85a758cfsi8182670pga.169.2024.03.04.05.26.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 05:26:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90641-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cPWl5M1Z; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-90641-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90641-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3A6A328A5BE for ; Mon, 4 Mar 2024 13:26:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 115BB3D996; Mon, 4 Mar 2024 13:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cPWl5M1Z" Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A94323D55E; Mon, 4 Mar 2024 13:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709558764; cv=none; b=Z+MR5MqLxsM1wH+g+LsS1BJf6UGLbW9GtLCW3pdmuE7ENfPmJlwwmoBbYky8qYfW5tprOWJw+m4I+MjN1dquKp8/iVBUrFLocC2bWEQeNSigQ35FYbkht06iFUwIopptMRs5mIEMa//KB9NnlCfnDROc7xq4eGhaZ6QsqcV36nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709558764; c=relaxed/simple; bh=1v0A7i2+W2cHjoJY6glR5gGnX34Ee+tCNN+/JkQeFN0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=K6Yuae0OJnrIKFtSCgP4dKd6b0W9MmgxwzvZhXz6Gq5NmqftF1UzmS7tUnSZywrqb5OI1/NyJg6I1crdKpJ4hmTQvXFyQLmQh6b03mA75qrtG3MZ1d8pCuy9EkgVUkkdrxZCPA+wWoZh7n8Ud9eYrHY+RwAgQ1wihkydTzEgTvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cPWl5M1Z; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-512d19e2cb8so5258581e87.0; Mon, 04 Mar 2024 05:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709558761; x=1710163561; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1v0A7i2+W2cHjoJY6glR5gGnX34Ee+tCNN+/JkQeFN0=; b=cPWl5M1ZfMTtxaeV2ik5WCXTygplocnUUXPaiRcvEouokzc8YwDgd7Pdso79gFQ6zJ ke2SX3aivo+M9i1zmN/ffPROXG+LtdzJVxg1xpuOHz449CXp+XI4r86VUs2llDhUjQ/M ZSD5H6F1etd5is3wjAfbuV195RsbvqsPITRYxlFSYa4WDKinT462EDlQlGXaJZ56I074 tgncWVY6aKtaRD64xpDitUSrfNiNGQFmHVeyDqETD43soeWCBfaiXIbC8rhLGP/Mp1f6 1Ap8Sfu6F/a4+wWvef118DAj9SWJ5KwF+45PtZ83WYMWqVEmwVOsHQi2UVLofU3y14qi eZGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709558761; x=1710163561; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1v0A7i2+W2cHjoJY6glR5gGnX34Ee+tCNN+/JkQeFN0=; b=QkkwELC0FTJPMOh67EzGvwWg3N6D6vHJeEgMCD2hCgM0cNriZHHqIjucbNmr1ecwTD +L/Bry2VtKyUde93Z51Acpj8wb2bGHEImQaojNdve+ertDxMzYtp162cAfN2utFemPeJ wAlSkThJilCJmqNux3VRQCre7X8jtcxLooAJ8L2eY1qV5YpenHjyUCbq+UxRBwjkZKTf fHY0u86OkPFjAEZZMlJtxcqOMoNLghkMNnbqVT7wpR32rWTGFLScArYUt4MDtHtEFr7R JVJBRr6geckRz4Trg5Deqy0zBjCJiY8z88G3mi3Y4YAjTlItg2apS0Fpn6Ua9MYct8Nb CK8g== X-Forwarded-Encrypted: i=1; AJvYcCXpuQOuGVtb3AY8Rn9ZBYj1rblm6s+aR0VnagNDUi5mAzcHruvrdUF1SbF+CvHWp2LGUdk3/VPAfYhswf3iW8fZ7FSIahKxFqLc5kSMeJi3R+Macybg5NGTJpUb0HfP5lCqYq+p X-Gm-Message-State: AOJu0YwwOz9eRhJ5wC/n80alisdvnRv/H0C3q238L2+Tv3QPLUD5jkUL 7mfNu+xRn1txf5YRmhCMRRZZ8Ld0DGXFZV26NntefhHtNb21dinPm1HxGhZJs9eYWlDOOBC3llG +JFRnmSZ+pf7yC+tblSnCKvRwq24= X-Received: by 2002:ac2:48a2:0:b0:512:f1a5:709 with SMTP id u2-20020ac248a2000000b00512f1a50709mr5560291lfg.41.1709558760578; Mon, 04 Mar 2024 05:26:00 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240303114139.GA11018@didi-ThinkCentre-M920t-N000> In-Reply-To: From: Jason Xing Date: Mon, 4 Mar 2024 21:25:23 +0800 Message-ID: Subject: Re: [PATCH net-next v2] net/nlmon: Cancel setting the fields of statistics to zero. To: yuanli fu Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, fuyuanli@didiglobal.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 4, 2024 at 7:14=E2=80=AFPM yuanli fu w= rote: > > Jason Xing =E4=BA=8E2024=E5=B9=B43=E6=9C=884= =E6=97=A5=E5=91=A8=E4=B8=80 15:05=E5=86=99=E9=81=93=EF=BC=9A > > > > On Sun, Mar 3, 2024 at 7:43=E2=80=AFPM fuyuanli wrote: > > > > > > Since fields of rtnl_link_stats64 have been set to zero in the previo= us > > > dev_get_stats function, there is no need to set them again in the > > > ndo_get_stats64 function. > > > > > > Signed-off-by: fuyuanli > > > Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-Think= Centre-M920t-N000/ > > > > Suggested-by: Jason Xing > > See https://lore.kernel.org/all/CAL+tcoA=3DFVBJi2eJgAELhWG_f+N-kwmrHc+X= RfKXhYk2RJcPKg@mail.gmail.com/ > OK, I will submit a v3 patch which updating commit message, thanks. I don't think you need to send a new version of the patch unless someone points out other changes that should be made. Thanks, Jason > > > > Reviewed-by: Jason Xing > >