Received-SPF: pass (google.com: domain of linux-kernel+bounces-90642-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 4 Mar 2024 15:26:12 +0200 (EET)
To: "David E. Box" <david.e.box@linux.intel.com>
cc: rajvi.jingar@linux.intel.com, platform-driver-x86@vger.kernel.org, 
    linux-kernel@vger.kernel.org, hdegoede@redhat.com, 
    ilpo.jarvinen@linux.intel.com
Subject: Re: [PATCH V2 3/9] platform/x86/intel/sdsi: Add in-band BIOS lock
 support
In-Reply-To: <20240228000016.1685518-4-david.e.box@linux.intel.com>
Message-ID: <4502a46c-cd1f-f030-f0e0-5ed717a38a02@linux.intel.com>
References: <20240228000016.1685518-1-david.e.box@linux.intel.com> <20240228000016.1685518-4-david.e.box@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-531824783-1709558772=:986"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-531824783-1709558772=:986
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Tue, 27 Feb 2024, David E. Box wrote:

> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.=
com>
>=20
> As per SDSi in-band interface specification, sec titled "BIOS lock for
> in-band provisioning", when IB_LOCK bit is set in control qword, the
> SDSI agent is only allowed to perform the read flow, but not allowed to
> provision license blob or license key. So add check for it in
> sdsi_provision().
>=20
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@lin=
ux.intel.com>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
>=20
> V2 - Move sdsi_ib_locked() check after overflow check
>=20
>  drivers/platform/x86/intel/sdsi.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>=20
> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/int=
el/sdsi.c
> index d80c2dc0ce71..bb3eaf5eb382 100644
> --- a/drivers/platform/x86/intel/sdsi.c
> +++ b/drivers/platform/x86/intel/sdsi.c
> @@ -67,6 +67,7 @@
>  #define CTRL_OWNER=09=09=09GENMASK(5, 4)
>  #define CTRL_COMPLETE=09=09=09BIT(6)
>  #define CTRL_READY=09=09=09BIT(7)
> +#define CTRL_INBAND_LOCK=09=09BIT(32)
>  #define CTRL_STATUS=09=09=09GENMASK(15, 8)
>  #define CTRL_PACKET_SIZE=09=09GENMASK(31, 16)
>  #define CTRL_MSG_SIZE=09=09=09GENMASK(63, 48)
> @@ -346,6 +347,11 @@ static int sdsi_mbox_read(struct sdsi_priv *priv, st=
ruct sdsi_mbox_info *info, s
>  =09return sdsi_mbox_cmd_read(priv, info, data_size);
>  }
> =20
> +static bool sdsi_ib_locked(struct sdsi_priv *priv)
> +{
> +=09return !!FIELD_GET(CTRL_INBAND_LOCK, readq(priv->control_addr));
> +}
> +
>  static ssize_t sdsi_provision(struct sdsi_priv *priv, char *buf, size_t =
count,
>  =09=09=09      enum sdsi_command command)
>  {
> @@ -355,6 +361,10 @@ static ssize_t sdsi_provision(struct sdsi_priv *priv=
, char *buf, size_t count,
>  =09if (count > (SDSI_SIZE_WRITE_MSG - SDSI_SIZE_CMD))
>  =09=09return -EOVERFLOW;
> =20
> +=09/* Make sure In-band lock is not set */
> +=09if (sdsi_ib_locked(priv))
> +=09=09return -EPERM;
> +

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-531824783-1709558772=:986--